[gnumeric] Fix prercentage histogram . [#590375]

[Andreas J. Guelzow <guelzow src gnome org>]

commit d24832e573fd1d901b2980c74bd755b9c868bb5d
Author: Andreas J. Guelzow <aguelzow pyrshep ca>
Date:   Sat Aug 1 00:55:57 2009 -0600

     Fix prercentage histogram . [#590375]
    
    2009-08-01 Andreas J. Guelzow <aguelzow pyrshep ca>
    
    	* analysis-histogram.c (make_hist_expr): only free expr_data
    	  if we didn't already use it. Fixes #590375.

 NEWS                           |    3 ++-
 src/tools/ChangeLog            |    5 +++++
 src/tools/analysis-histogram.c |    4 ++--
 3 files changed, 9 insertions(+), 3 deletions(-)
---
diff --git a/NEWS b/NEWS
index e77c86c..b1755f9 100644
--- a/NEWS
+++ b/NEWS
@@ -18,7 +18,8 @@ Andreas:
 	* Add some sheet object support to ODF export.
 	* Export basic charts to ODF.
 	* Fix format labels in configurable text importer. [#590257]
-	* Add warning for missing plugins needed by tools [#590175]
+	* Add warning for missing plugins needed by tools. [#590175]
+	* Fix prercentage histogram . [#590375]
 
 Jody:
 	* Fix col/row resize. [#588297]
diff --git a/src/tools/ChangeLog b/src/tools/ChangeLog
index aa7164d..fd1aab6 100644
--- a/src/tools/ChangeLog
+++ b/src/tools/ChangeLog
@@ -1,3 +1,8 @@
+2009-08-01 Andreas J. Guelzow <aguelzow pyrshep ca>
+
+	* analysis-histogram.c (make_hist_expr): only free expr_data
+	  if we didn't already use it. Fixes #590375.
+
 2009-07-31 Andreas J. Guelzow <aguelzow pyrshep ca>
 
 	* analysis-tools.c (analysis_tool_fourier_engine_run): combine
diff --git a/src/tools/analysis-histogram.c b/src/tools/analysis-histogram.c
index 5362c57..307e76d 100644
--- a/src/tools/analysis-histogram.c
+++ b/src/tools/analysis-histogram.c
@@ -101,8 +101,8 @@ make_hist_expr (analysis_tools_data_histogram_t *info,
 					    gnm_expr_new_funcall1 
 					    (fd_count, 
 					     expr_data));
-
-	gnm_expr_free (expr_data);
+	else
+		gnm_expr_free (expr_data);
 
 	return expr;
 }