[gnome-scan/gnome-scan-0-6: 17/23] Properly unref created objects



commit 8244c20055e83be4547d89f2345dab230ab29a75
Author: Ã?tienne Bersac <bersace src gnome org>
Date:   Sat Jan 31 16:19:48 2009 +0000

    Properly unref created objects
    
    svn path=/branches/GNOME_SCAN_0_6/; revision=805
---
 ChangeLog          |    6 ++++++
 src/flegita-gimp.c |    5 +++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0bf7cb0..d6e1570 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2009-01-31  Ã?tienne BERSAC  <bersace03 laposte net>
 
+	* src/flegita-gimp.c:
+
+	Properly unref dialog, job and sink. Fix #523251.
+
+2009-01-31  Ã?tienne BERSAC  <bersace03 laposte net>
+
 	* src/Makefile.am:
 
 	Link gimp plugin before installing it.
diff --git a/src/flegita-gimp.c b/src/flegita-gimp.c
index d13439b..b7ccaa8 100644
--- a/src/flegita-gimp.c
+++ b/src/flegita-gimp.c
@@ -142,7 +142,6 @@ run (const gchar      *name,
   gdouble xres, yres, res;
 
   /* if we are scanning, create a new image */
-  g_debug (G_STRLOC " " PROCEDURE_SCAN);
   if (g_str_equal (name, PROCEDURE_SCAN)) {
 	  image_ID = 0;
 	  is_new = TRUE;
@@ -168,9 +167,11 @@ run (const gchar      *name,
   }
 
   gnome_scan_job_set_sink (job, sink);
-  gnome_scan_job_set_settings(job, settings);
   GtkWidget*dialog = gnome_scan_dialog_new (NULL, job);
   gnome_scan_dialog_run (GNOME_SCAN_DIALOG (dialog));
+  g_object_unref(dialog);
+  g_object_unref(job);
+  g_object_unref(sink);
   g_object_unref(settings);
 
   if (is_new && fgs->image_ID) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]