[empathy/gnome-2-26] Fix memleak in log_store_empathy_get_chats_for_dir. Only build filename if its



commit 08f0f28844dc9a7bb2bda6ffd781fb3df239318e
Author: Lars-Peter Clausen <lars metafoo de>
Date:   Fri Apr 17 23:00:10 2009 +0200

    Fix memleak in log_store_empathy_get_chats_for_dir. Only build filename if its
    needed and freed again.
---
 libempathy/empathy-log-store-empathy.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/libempathy/empathy-log-store-empathy.c b/libempathy/empathy-log-store-empathy.c
index 3414d66..ccdfee5 100644
--- a/libempathy/empathy-log-store-empathy.c
+++ b/libempathy/empathy-log-store-empathy.c
@@ -640,17 +640,15 @@ log_store_empathy_get_chats_for_dir (EmpathyLogStore *self,
   while ((name = g_dir_read_name (gdir)) != NULL)
     {
       EmpathyLogSearchHit *hit;
-      gchar *filename;
 
-      filename = g_build_filename (dir, name, NULL);
       if (!is_chatroom && strcmp (name, LOG_DIR_CHATROOMS) == 0)
         {
+          gchar *filename = g_build_filename (dir, name, NULL);
           hits = g_list_concat (hits, log_store_empathy_get_chats_for_dir (
                 self, filename, TRUE));
           g_free (filename);
           continue;
         }
-
       hit = g_slice_new0 (EmpathyLogSearchHit);
       hit->chat_id = g_strdup (name);
       hit->is_chatroom = is_chatroom;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]