[gnome-video-arcade] Remove overly strict assertion from process_read_line().



commit d8094d3dcdbd6ee3592fe0def2edeea21bb036a3
Author: Matthew Barnes <mbarnes redhat com>
Date:   Mon Apr 6 12:47:47 2009 -0400

    Remove overly strict assertion from process_read_line().
    
    2009-04-06  Matthew Barnes  <mbarnes redhat com>
    
    	* gva-process.c (process_read_line):
    	Remove the assertion before process_propagate_error(), since the
    	function can handle NULL GErrors.  Hopefully this fixes a crash on
    	OpenBSD, but I'd still like to know why g_io_channel_read_line()
    	returns G_IO_STATUS_ERROR without setting the GError.
---
 ChangeLog         |    8 ++++
 config.h.in       |   97 -----------------------------------------------------
 src/gva-process.c |    3 --
 3 files changed, 8 insertions(+), 100 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 33923a3..981ee1b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-04-06  Matthew Barnes  <mbarnes redhat com>
+
+	* gva-process.c (process_read_line):
+	Remove the assertion before process_propagate_error(), since the
+	function can handle NULL GErrors.  Hopefully this fixes a crash on
+	OpenBSD, but I'd still like to know why g_io_channel_read_line()
+	returns G_IO_STATUS_ERROR without setting the GError.
+
 2009-04-05  Matthew Barnes  <mbarnes redhat com>
 
 	* Actually release 0.6.6.
diff --git a/config.h.in b/config.h.in
deleted file mode 100644
index cf909a3..0000000
--- a/config.h.in
+++ /dev/null
@@ -1,97 +0,0 @@
-/* config.h.in.  Generated from configure.ac by autoheader.  */
-
-/* Location of the category file */
-#undef CATEGORY_FILE
-
-/* always defined to indicate that i18n is enabled */
-#undef ENABLE_NLS
-
-/* Package name for gettext */
-#undef GETTEXT_PACKAGE
-
-/* Define to 1 if you have the `bind_textdomain_codeset' function. */
-#undef HAVE_BIND_TEXTDOMAIN_CODESET
-
-/* Define to 1 if you have the `dcgettext' function. */
-#undef HAVE_DCGETTEXT
-
-/* Define to 1 if you have the <dlfcn.h> header file. */
-#undef HAVE_DLFCN_H
-
-/* Define if the GNU gettext() function is already present or preinstalled. */
-#undef HAVE_GETTEXT
-
-/* Define to 1 if you have the <inttypes.h> header file. */
-#undef HAVE_INTTYPES_H
-
-/* Define if your <locale.h> file defines LC_MESSAGES. */
-#undef HAVE_LC_MESSAGES
-
-/* Define to 1 if you have the <locale.h> header file. */
-#undef HAVE_LOCALE_H
-
-/* Define to 1 if you have the <memory.h> header file. */
-#undef HAVE_MEMORY_H
-
-/* Define to 1 if you have the <stdint.h> header file. */
-#undef HAVE_STDINT_H
-
-/* Define to 1 if you have the <stdlib.h> header file. */
-#undef HAVE_STDLIB_H
-
-/* Define to 1 if you have the <strings.h> header file. */
-#undef HAVE_STRINGS_H
-
-/* Define to 1 if you have the <string.h> header file. */
-#undef HAVE_STRING_H
-
-/* Define to 1 if you have the <sys/stat.h> header file. */
-#undef HAVE_SYS_STAT_H
-
-/* Define to 1 if you have the <sys/types.h> header file. */
-#undef HAVE_SYS_TYPES_H
-
-/* Define to 1 if you have the <unistd.h> header file. */
-#undef HAVE_UNISTD_H
-
-/* Define to 1 if you have the <wordexp.h> header file. */
-#undef HAVE_WORDEXP_H
-
-/* Location of the arcade history file */
-#undef HISTORY_FILE
-
-/* Location of the MAME program */
-#undef MAME_PROGRAM
-
-/* Location of the number of players file */
-#undef NPLAYERS_FILE
-
-/* Name of package */
-#undef PACKAGE
-
-/* Define to the address where bug reports for this package should be sent. */
-#undef PACKAGE_BUGREPORT
-
-/* Define to the full name of this package. */
-#undef PACKAGE_NAME
-
-/* Define to the full name and version of this package. */
-#undef PACKAGE_STRING
-
-/* Define to the one symbol short name of this package. */
-#undef PACKAGE_TARNAME
-
-/* Define to the version of this package. */
-#undef PACKAGE_VERSION
-
-/* Define to 1 if you have the ANSI C header files. */
-#undef STDC_HEADERS
-
-/* Version number of package */
-#undef VERSION
-
-/* Define to 1 if you are linking against GNOME libraries */
-#undef WITH_GNOME
-
-/* Define to 1 if you are linking against libwnck */
-#undef WITH_WNCK
diff --git a/src/gva-process.c b/src/gva-process.c
index 58474c3..b6a2cea 100644
--- a/src/gva-process.c
+++ b/src/gva-process.c
@@ -171,10 +171,7 @@ process_read_line (GvaProcess *process,
                 g_signal_emit (process, signal_id, 0);
         }
         else
-        {
-                g_assert (error != NULL);
                 process_propagate_error (process, error);
-        }
 }
 
 static gboolean



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]