[nemiver] Some IDebugger/GDBEngine cleanup

[Dodji Seketeli <dodji src gnome org>]

commit e1d63fb33b803ab43a649843a8abaffe632505a1
Author: Dodji Seketeli <dodji redhat com>
Date:   Fri Apr 3 15:57:26 2009 +0200

    Some IDebugger/GDBEngine cleanup
    
    	* src/dbgengine/nmv-gdb-engine.[cc|h],
    	src/dbgengine/nmv-i-debugger.h: Added some comments. Don't pass
    	IDebugger::VariableSafePtr by reference as signal template parameters.
    	It just bypasses the reference counting. Also, a SafePtr is not bigger
    	than the underlying pointer, so the is no need to do that in that case.
---
 src/dbgengine/nmv-gdb-engine.cc |   19 +++++++++++--------
 src/dbgengine/nmv-gdb-engine.h  |    8 ++++----
 src/dbgengine/nmv-i-debugger.h  |   13 +++++++++----
 3 files changed, 24 insertions(+), 16 deletions(-)

diff --git a/src/dbgengine/nmv-gdb-engine.cc b/src/dbgengine/nmv-gdb-engine.cc
index 8457982..5813aba 100644
--- a/src/dbgengine/nmv-gdb-engine.cc
+++ b/src/dbgengine/nmv-gdb-engine.cc
@@ -178,23 +178,23 @@ public:
 
     mutable sigc::signal<void,
                          const UString&,
-                         const IDebugger::VariableSafePtr&,
+                         const IDebugger::VariableSafePtr,
                          const UString&>             variable_value_signal;
 
     mutable sigc::signal<void,
-                         const VariableSafePtr&/*variable*/,
+                         const VariableSafePtr/*variable*/,
                          const UString& /*cookie*/>
                                      variable_value_set_signal;
 
     mutable sigc::signal<void,
                          const UString&,
-                         const VariableSafePtr&,
+                         const VariableSafePtr,
                          const UString&> pointed_variable_value_signal;
 
     mutable sigc::signal<void, const UString&, const UString&, const UString&>
                                                         variable_type_signal;
 
-    mutable sigc::signal<void, const VariableSafePtr&, const UString&>
+    mutable sigc::signal<void, const VariableSafePtr, const UString&>
                                                     variable_type_set_signal;
 
     mutable sigc::signal<void, const VariableSafePtr, const UString&>
@@ -2429,19 +2429,22 @@ GDBEngine::global_variables_listed_signal () const
     return m_priv->global_variables_listed_signal;
 }
 
-sigc::signal<void, const UString&, const IDebugger::VariableSafePtr&, const UString&>&
+sigc::signal<void,
+             const UString&,
+             const IDebugger::VariableSafePtr,
+             const UString&>&
 GDBEngine::variable_value_signal () const
 {
     return m_priv->variable_value_signal;
 }
 
-sigc::signal<void, const IDebugger::VariableSafePtr&, const UString&>&
+sigc::signal<void, const IDebugger::VariableSafePtr, const UString&>&
 GDBEngine::variable_value_set_signal () const
 {
     return m_priv->variable_value_set_signal;
 }
 
-sigc::signal<void, const UString&, const IDebugger::VariableSafePtr&, const UString&>&
+sigc::signal<void, const UString&, const IDebugger::VariableSafePtr, const UString&>&
 GDBEngine::pointed_variable_value_signal () const
 {
     return m_priv->pointed_variable_value_signal;
@@ -2453,7 +2456,7 @@ GDBEngine::variable_type_signal () const
     return m_priv->variable_type_signal;
 }
 
-sigc::signal<void, const IDebugger::VariableSafePtr&, const UString&>&
+sigc::signal<void, const IDebugger::VariableSafePtr, const UString&>&
 GDBEngine::variable_type_set_signal () const
 {
     return m_priv->variable_type_set_signal;
diff --git a/src/dbgengine/nmv-gdb-engine.h b/src/dbgengine/nmv-gdb-engine.h
index 833ec75..58f79d5 100644
--- a/src/dbgengine/nmv-gdb-engine.h
+++ b/src/dbgengine/nmv-gdb-engine.h
@@ -125,21 +125,21 @@ public:
 
     sigc::signal<void,
                  const UString&,
-                 const IDebugger::VariableSafePtr&,
+                 const IDebugger::VariableSafePtr,
                  const UString&>& variable_value_signal () const  ;
 
     sigc::signal<void,
-                 const VariableSafePtr&/*variable*/,
+                 const VariableSafePtr/*variable*/,
                  const UString& /*cookie*/>&
                                      variable_value_set_signal () const ;
 
-    sigc::signal<void, const UString&, const VariableSafePtr&, const UString&>&
+    sigc::signal<void, const UString&, const VariableSafePtr, const UString&>&
                                     pointed_variable_value_signal () const  ;
 
     sigc::signal<void, const UString&, const UString&, const UString&>&
                                         variable_type_signal () const ;
 
-    sigc::signal<void, const VariableSafePtr&, const UString&>&
+    sigc::signal<void, const VariableSafePtr, const UString&>&
                                     variable_type_set_signal () const ;
 
     sigc::signal<void, const VariableSafePtr, const UString&>
diff --git a/src/dbgengine/nmv-i-debugger.h b/src/dbgengine/nmv-i-debugger.h
index 35ed562..15a77f9 100644
--- a/src/dbgengine/nmv-i-debugger.h
+++ b/src/dbgengine/nmv-i-debugger.h
@@ -607,32 +607,37 @@ public:
     virtual sigc::signal<void, const list<VariableSafePtr>&, const UString& >&
                             global_variables_listed_signal () const = 0;
 
+    /// Emitted as the result of the IDebugger::print_variable_value() call.
     virtual sigc::signal<void,
                          const UString&/*variable name*/,
-                         const VariableSafePtr&/*variable*/,
+                         const VariableSafePtr /*variable*/,
                          const UString& /*cookie*/>&
                                              variable_value_signal () const = 0;
+
+    /// Emitted as the result of the IDebugger::get_variable_value() call.
     virtual sigc::signal<void,
-                         const VariableSafePtr&/*variable*/,
+                         const VariableSafePtr /*variable*/,
                          const UString& /*cookie*/>&
                                      variable_value_set_signal () const = 0;
 
     virtual sigc::signal<void,
                          const UString&/*variable name*/,
-                         const VariableSafePtr&/*variable*/,
+                         const VariableSafePtr /*variable*/,
                          const UString& /*cookie*/>&
                                     pointed_variable_value_signal () const = 0;
 
+    /// Emitted as the result of the IDebugger::print_variable_type() call.
     virtual sigc::signal<void,
                          const UString&/*variable name*/,
                          const UString&/*type*/,
                          const UString&/*cookie*/>&
                                         variable_type_signal () const = 0;
     virtual sigc::signal<void,
-                         const VariableSafePtr&/*variable*/,
+                         const VariableSafePtr /*variable*/,
                          const UString&/*cookie*/>&
                                     variable_type_set_signal () const=0;
 
+    /// Emitted as a the result of the IDebugger::dereference_variable is call.
     virtual sigc::signal<void,
                          const VariableSafePtr/*the variable we derefed*/,
                          const UString&/*cookie*/>