banshee r4601 - in trunk/banshee: . src/Core/Banshee.ThickClient/Banshee.Gui src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea

[gburt svn gnome org]

Author: gburt
Date: Wed Sep 24 16:28:02 2008
New Revision: 4601
URL: http://svn.gnome.org/viewvc/banshee?rev=4601&view=rev

Log:
2008-09-24  Gabriel Burt  <gabriel burt gmail com>

	* src/Core/Banshee.ThickClient/Banshee.Gui/BaseClientWindow.cs: Add a
	SetVisible method to allow explicitly setting the state, as opposed to
	relying on the Toggle logic, which breaks alt-f4 closing because
	apparently the window !IsActive when that's pressed (BNC #257350).

	* src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea/NotificationAreaService.cs:
	Call SetVisible (false) explicitly from the CloseWindow method.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/BaseClientWindow.cs
   trunk/banshee/src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea/NotificationAreaService.cs

Modified: trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/BaseClientWindow.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/BaseClientWindow.cs	(original)
+++ trunk/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/BaseClientWindow.cs	Wed Sep 24 16:28:02 2008
@@ -74,7 +74,12 @@
         
         public void ToggleVisibility ()
         {
-            if (Visible && IsActive) {
+            SetVisible (!(Visible && IsActive));
+        }
+
+        public void SetVisible (bool visible)
+        {
+            if (!visible) {
                 window_controller.Save ();
                 Visible = false;
             } else {

Modified: trunk/banshee/src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea/NotificationAreaService.cs
==============================================================================
--- trunk/banshee/src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea/NotificationAreaService.cs	(original)
+++ trunk/banshee/src/Extensions/Banshee.NotificationArea/Banshee.NotificationArea/NotificationAreaService.cs	Wed Sep 24 16:28:02 2008
@@ -309,7 +309,7 @@
             } catch {
             }
 
-            elements_service.PrimaryWindow.ToggleVisibility ();
+            elements_service.PrimaryWindow.SetVisible (false);
         }
 
         private void ToggleNotifications (object o, EventArgs args)