gnumeric r16808 - in trunk: . src

[guelzow svn gnome org]

Author: guelzow
Date: Fri Sep 19 05:42:08 2008
New Revision: 16808
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16808&view=rev

Log:
2008-09-18  Andreas J. Guelzow <aguelzow pyrshep ca>

	Fix for #535015
	* src/hlink.c (gnm_hlink_external_activate): complete code




Modified:
   trunk/ChangeLog
   trunk/NEWS
   trunk/src/hlink.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Fri Sep 19 05:42:08 2008
@@ -12,6 +12,7 @@
 	* By default cells with hyperlinks should not be empty [#152617]
 	* Fix command names for hyperlink additions.
 	* Improve histogram tool [#385458][#552161]
+	* Make external hyperlinks work. [#535015]
 
 Jean:
 	* Fix printing of rotated text. [#539734]

Modified: trunk/src/hlink.c
==============================================================================
--- trunk/src/hlink.c	(original)
+++ trunk/src/hlink.c	Fri Sep 19 05:42:08 2008
@@ -266,11 +266,15 @@
 {
 	GError *err = NULL;
 	gboolean res = FALSE;
+	char *cmd;
 
 	if (lnk->target == NULL)
 		return FALSE;
 
-#warning TODO
+	cmd = go_shell_arg_to_uri (lnk->target);
+	err = go_url_show (cmd);
+	g_free (cmd);
+
 	if (err != NULL) {
 		char *msg = g_strdup_printf(_("Unable to open '%s'"), lnk->target);
 		go_cmd_context_error_invalid (GO_CMD_CONTEXT (wbc), msg, err->message);