evolution-data-server r9496 - trunk/camel/providers/pop3



Author: pohly
Date: Mon Sep  8 16:22:47 2008
New Revision: 9496
URL: http://svn.gnome.org/viewvc/evolution-data-server?rev=9496&view=rev

Log:
fixes memory leak created by patch for #514827


Modified:
   trunk/camel/providers/pop3/ChangeLog
   trunk/camel/providers/pop3/camel-pop3-folder.c

Modified: trunk/camel/providers/pop3/camel-pop3-folder.c
==============================================================================
--- trunk/camel/providers/pop3/camel-pop3-folder.c	(original)
+++ trunk/camel/providers/pop3/camel-pop3-folder.c	Mon Sep  8 16:22:47 2008
@@ -381,8 +381,6 @@
 	    && buffer[0] == '#') {
 		CamelMimeMessage *message;
 
-		camel_object_ref ((CamelObject *)stream);
-
 		message = camel_mime_message_new ();
 		if (camel_data_wrapper_construct_from_stream ((CamelDataWrapper *)message, stream) == -1) {
 			g_warning (_("Cannot get message %s: %s"), uid, g_strerror (errno));
@@ -396,10 +394,11 @@
 
 			camel_object_unref ((CamelObject *)message);
 		}
-
-		camel_object_unref ((CamelObject *)stream);
 	}
 
+	if (stream) {
+		camel_object_unref (stream);
+	}
 	return res;
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]