evolution-data-server r9718 - in branches/gnome-2-24: . addressbook addressbook/backends/ldap camel libebackend servers/groupwise

[mbarnes svn gnome org]

Author: mbarnes
Date: Fri Oct 31 21:20:27 2008
New Revision: 9718
URL: http://svn.gnome.org/viewvc/evolution-data-server?rev=9718&view=rev

Log:
2008-10-31  Matthew Barnes  <mbarnes redhat com>

        ** Fixes bug #558727 (patch by Frederic van Starbmann)

        * addressbook/backends/ldap/e-book-backend-ldap.c
        (get_ldap_library_info):
        * camel/camel-vtrash-folder.c (vtrash_append_message),
        (vtrash_transfer_messages_to):
        * libebackend/e-data-server-module (e_data_server_module_load):
        * servers/groupwise/create-account.c (add_account):
        Fix some potential string format crashes.



Modified:
   branches/gnome-2-24/ChangeLog
   branches/gnome-2-24/addressbook/ChangeLog
   branches/gnome-2-24/addressbook/backends/ldap/e-book-backend-ldap.c
   branches/gnome-2-24/camel/ChangeLog
   branches/gnome-2-24/camel/camel-vtrash-folder.c
   branches/gnome-2-24/libebackend/e-data-server-module.c
   branches/gnome-2-24/servers/groupwise/ChangeLog
   branches/gnome-2-24/servers/groupwise/create-account.c

Modified: branches/gnome-2-24/addressbook/backends/ldap/e-book-backend-ldap.c
==============================================================================
--- branches/gnome-2-24/addressbook/backends/ldap/e-book-backend-ldap.c	(original)
+++ branches/gnome-2-24/addressbook/backends/ldap/e-book-backend-ldap.c	Fri Oct 31 21:20:27 2008
@@ -664,7 +664,7 @@
 		/* yuck.  we have to free these? */
 		for (i = 0; info.ldapai_extensions[i]; i++) {
 			char *extension = info.ldapai_extensions[i];
-			g_message (extension);
+			g_message ("%s", extension);
 			ldap_memfree (extension);
 		}
 		ldap_memfree (info.ldapai_extensions);

Modified: branches/gnome-2-24/camel/camel-vtrash-folder.c
==============================================================================
--- branches/gnome-2-24/camel/camel-vtrash-folder.c	(original)
+++ branches/gnome-2-24/camel/camel-vtrash-folder.c	Fri Oct 31 21:20:27 2008
@@ -208,7 +208,7 @@
 		       const CamelMessageInfo *info, char **appended_uid,
 		       CamelException *ex)
 {
-	camel_exception_setv(ex, CAMEL_EXCEPTION_SYSTEM, 
+	camel_exception_setv(ex, CAMEL_EXCEPTION_SYSTEM, "%s",
 			     _(vdata[((CamelVTrashFolder *)folder)->type].error_copy));
 }
 
@@ -257,7 +257,7 @@
 	if (CAMEL_IS_VTRASH_FOLDER (dest)) {
 		/* Copy to trash is meaningless. */
 		if (!delete_originals) {
-			camel_exception_setv(ex, CAMEL_EXCEPTION_SYSTEM, 
+			camel_exception_setv(ex, CAMEL_EXCEPTION_SYSTEM, "%s",
 					     _(vdata[((CamelVTrashFolder *)dest)->type].error_copy));
 			return;
 		}

Modified: branches/gnome-2-24/libebackend/e-data-server-module.c
==============================================================================
--- branches/gnome-2-24/libebackend/e-data-server-module.c	(original)
+++ branches/gnome-2-24/libebackend/e-data-server-module.c	Fri Oct 31 21:20:27 2008
@@ -77,7 +77,7 @@
 	module->library = g_module_open (module->path, G_MODULE_BIND_LAZY);
 
 	if (!module->library) {
-		g_warning (g_module_error ());
+		g_warning ("%s", g_module_error ());
 		return FALSE;
 	}
 
@@ -91,7 +91,7 @@
 			      "eds_module_list_types",
 			      (gpointer *)&module->list_types)) {
 
-		g_warning (g_module_error ());
+		g_warning ("%s", g_module_error ());
 		g_module_close (module->library);
 
 		return FALSE;

Modified: branches/gnome-2-24/servers/groupwise/create-account.c
==============================================================================
--- branches/gnome-2-24/servers/groupwise/create-account.c	(original)
+++ branches/gnome-2-24/servers/groupwise/create-account.c	Fri Oct 31 21:20:27 2008
@@ -18,7 +18,7 @@
 
 	source_list = e_source_list_new_for_gconf (conf_client, conf_key);
 
-	group_name = g_strdup_printf (hostname);
+	group_name = g_strdup (hostname);
 	group = e_source_group_new (group_name, "groupwise://");
 	e_source_list_add_group (source_list, group, -1);