gtranslator r3872 - in trunk: . plugins/open-tran



Author: icq
Date: Tue Oct 28 11:36:59 2008
New Revision: 3872
URL: http://svn.gnome.org/viewvc/gtranslator?rev=3872&view=rev

Log:
2008-10-28  Ignacio Casal Quinteiro  <nacho resa gmail com>

        * plugins/open-tran/open-tran-panel.c:
        Fixed crash freeing memory.



Modified:
   trunk/ChangeLog
   trunk/plugins/open-tran/open-tran-panel.c

Modified: trunk/plugins/open-tran/open-tran-panel.c
==============================================================================
--- trunk/plugins/open-tran/open-tran-panel.c	(original)
+++ trunk/plugins/open-tran/open-tran-panel.c	Tue Oct 28 11:36:59 2008
@@ -189,15 +189,18 @@
 		array = g_value_get_boxed (value);
 
 		if (G_VALUE_HOLDS (array->values, G_TYPE_HASH_TABLE))
-		{
 			hash = g_value_get_boxed (array->values);
-			g_value_array_free (array);
-		}
-		else return;
+		else
+			return;
 			
-		values = g_hash_table_get_values(hash);
-		if((values = g_list_next(values)))
-			print_struct_to_tree_view(values->data, panel);
+		values = g_hash_table_get_values (hash);
+		if ((values = g_list_next (values)))
+			print_struct_to_tree_view (values->data, panel);
+		
+		/*
+		 * It's important freeing the array after the use of its contents
+		 */
+		g_value_array_free (array);
 	}
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]