NetworkManager r4210 - in trunk/vpn-daemons/pptp: . src

[dcbw svn gnome org]

Author: dcbw
Date: Fri Oct 24 15:03:29 2008
New Revision: 4210
URL: http://svn.gnome.org/viewvc/NetworkManager?rev=4210&view=rev

Log:
2008-10-24  Dan Williams  <dcbw redhat com>

	* src/nm-pptp-service.c
		- (construct_pppd_args): pppd always parses /etc/ppp/options, so always
			add really important stuff to the command line to ensure that NM
			overrides /etc/ppp/options (bgo #556781)



Modified:
   trunk/vpn-daemons/pptp/ChangeLog
   trunk/vpn-daemons/pptp/src/nm-pptp-service.c

Modified: trunk/vpn-daemons/pptp/src/nm-pptp-service.c
==============================================================================
--- trunk/vpn-daemons/pptp/src/nm-pptp-service.c	(original)
+++ trunk/vpn-daemons/pptp/src/nm-pptp-service.c	Fri Oct 24 15:03:29 2008
@@ -650,6 +650,7 @@
 	GPtrArray *args = NULL;
 	const char *value, *pptp_binary;
 	char *ipparam, *tmp;
+	gboolean set = FALSE;
 
 	pptp_binary = nm_find_pptp ();
 	if (!pptp_binary) {
@@ -689,6 +690,7 @@
 	g_ptr_array_add (args, (gpointer) g_strdup ("lock"));
 	g_ptr_array_add (args, (gpointer) g_strdup ("usepeerdns"));
 	g_ptr_array_add (args, (gpointer) g_strdup ("noipdefault"));
+	g_ptr_array_add (args, (gpointer) g_strdup ("nodefaultroute"));
 
 	value = g_hash_table_lookup (s_vpn->data, NM_PPTP_KEY_REFUSE_EAP);
 	if (value && !strcmp (value, "yes"))
@@ -750,7 +752,12 @@
 		if (errno == 0) {
 			g_ptr_array_add (args, (gpointer) g_strdup ("lcp-echo-failure"));
 			g_ptr_array_add (args, (gpointer) g_strdup_printf ("%ld", tmp_int));
+		} else {
+			nm_warning ("failed to convert lcp-echo-failure value '%s'", value);
 		}
+	} else {
+		g_ptr_array_add (args, (gpointer) g_strdup ("lcp-echo-failure"));
+		g_ptr_array_add (args, (gpointer) g_strdup ("0"));
 	}
 
 	value = g_hash_table_lookup (s_vpn->data, NM_PPTP_KEY_LCP_ECHO_INTERVAL);
@@ -765,7 +772,12 @@
 		if (errno == 0) {
 			g_ptr_array_add (args, (gpointer) g_strdup ("lcp-echo-interval"));
 			g_ptr_array_add (args, (gpointer) g_strdup_printf ("%ld", tmp_int));
+		} else {
+			nm_warning ("failed to convert lcp-echo-interval value '%s'", value);
 		}
+	} else {
+		g_ptr_array_add (args, (gpointer) g_strdup ("lcp-echo-interval"));
+		g_ptr_array_add (args, (gpointer) g_strdup ("0"));
 	}
 
 	g_ptr_array_add (args, (gpointer) g_strdup ("plugin"));