gegl r2659 - in trunk: . gegl/operation gegl/process

[martinn svn gnome org]

Author: martinn
Date: Tue Oct 21 20:50:21 2008
New Revision: 2659
URL: http://svn.gnome.org/viewvc/gegl?rev=2659&view=rev

Log:
* gegl/operation/gegl-operation.h: Clarified the documenation of
GeglOperationClass::process().

* gegl/process/gegl-processor.c (gegl_node_new_processor): Added a
FIXME about how to get rid of the GeglOperationSink dependency.


Modified:
   trunk/ChangeLog
   trunk/gegl/operation/gegl-operation.h
   trunk/gegl/process/gegl-processor.c

Modified: trunk/gegl/operation/gegl-operation.h
==============================================================================
--- trunk/gegl/operation/gegl-operation.h	(original)
+++ trunk/gegl/operation/gegl-operation.h	Tue Oct 21 20:50:21 2008
@@ -121,10 +121,12 @@
   GeglRectangle (*get_cached_region)         (GeglOperation       *operation,
                                               const GeglRectangle *roi);
 
-  /* Perform processing for the @output_pad. The @roi provides the
-   * region to process. For sink operations @output_pad can be ignored
-   * but the @roi is then indicating the data available for
-   * consumption.
+  /* Perform processing and provide @output_pad with data for the
+   * region of interest @roi.
+   *
+   * For a GeglOperation _without_ output pads, for example a PNG save
+   * operation, @output_pad shall be ignored and @roi then instead
+   * specifies the data available for consumption.
    */
   gboolean      (*process)                   (GeglOperation        *operation,
                                               GeglOperationContext *context,

Modified: trunk/gegl/process/gegl-processor.c
==============================================================================
--- trunk/gegl/process/gegl-processor.c	(original)
+++ trunk/gegl/process/gegl-processor.c	Tue Oct 21 20:50:21 2008
@@ -305,6 +305,9 @@
                             "rectangle", rectangle,
                             NULL);
 
+  /* FIXME: Look for what pads that are available rather than looking
+   * at what type of operation we are dealing with
+   */
   if (node->operation                          &&
       GEGL_IS_OPERATION_SINK (node->operation) &&
       gegl_operation_sink_needs_full (node->operation))