gnumeric r16912 - in trunk: . plugins/excel



Author: mortenw
Date: Tue Oct 21 14:50:14 2008
New Revision: 16912
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16912&view=rev

Log:
2008-10-21  Morten Welinder  <terra gnome org>

	* ms-chart.c (BC_R(end)): Don't look first series if there are no
	series.  Fixes #557077.



Modified:
   trunk/NEWS
   trunk/plugins/excel/ChangeLog
   trunk/plugins/excel/ms-chart.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Tue Oct 21 14:50:14 2008
@@ -8,6 +8,9 @@
 Jody:
 	* Display top-left when selecting a rel ref to a merged region.
 
+Morten:
+	* Fix XLS import crash.  [#557077]
+
 --------------------------------------------------------------------------
 Gnumeric 1.9.3
 

Modified: trunk/plugins/excel/ms-chart.c
==============================================================================
--- trunk/plugins/excel/ms-chart.c	(original)
+++ trunk/plugins/excel/ms-chart.c	Tue Oct 21 14:50:14 2008
@@ -2571,7 +2571,10 @@
 				l = l->next;
 			}
 			g_slist_free (axisZ);
+
 			/* examine the first series to retreive categories */
+			if (s->series->len == 0)
+				goto not_a_matrix;
 			eseries = g_ptr_array_index (s->series, 0);
 			style = eseries->style;
 			if (!IS_GO_DATA_VECTOR (eseries->data [GOG_MS_DIM_CATEGORIES].data))



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]