evince r3216 - in trunk: . shell



Author: carlosgc
Date: Mon Oct  6 08:11:16 2008
New Revision: 3216
URL: http://svn.gnome.org/viewvc/evince?rev=3216&view=rev

Log:
2008-10-06  Carlos Garcia Campos  <carlosgc gnome org>

	* shell/ev-view.c: (merge_selection_region), (clear_selection):

	Fix memory leak. Fixes bug #555134.

Modified:
   trunk/ChangeLog
   trunk/shell/ev-view.c

Modified: trunk/shell/ev-view.c
==============================================================================
--- trunk/shell/ev-view.c	(original)
+++ trunk/shell/ev-view.c	Mon Oct  6 08:11:16 2008
@@ -5390,6 +5390,7 @@
 	/* Update the selection */
 	old_list = ev_pixbuf_cache_get_selection_list (view->pixbuf_cache);
 	g_list_foreach (view->selection_info.selections, (GFunc)selection_free, NULL);
+	g_list_free (view->selection_info.selections);
 	view->selection_info.selections = new_list;
 	ev_pixbuf_cache_set_selection_list (view->pixbuf_cache, new_list);
 	g_object_notify (G_OBJECT (view), "has-selection");
@@ -5498,6 +5499,7 @@
 
 	/* Free the old list, now that we're done with it. */
 	g_list_foreach (old_list, (GFunc) selection_free, NULL);
+	g_list_free (old_list);
 }
 
 static void
@@ -5529,6 +5531,7 @@
 clear_selection (EvView *view)
 {
 	g_list_foreach (view->selection_info.selections, (GFunc)selection_free, NULL);
+	g_list_free (view->selection_info.selections);
 	view->selection_info.selections = NULL;
 	view->selection_info.in_selection = FALSE;
 	if (view->pixbuf_cache)



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]