empathy r1783 - in trunk: libempathy libempathy-gtk

[xclaesse svn gnome org]

Author: xclaesse
Date: Fri Nov 21 16:16:44 2008
New Revision: 1783
URL: http://svn.gnome.org/viewvc/empathy?rev=1783&view=rev

Log:
Replaced the Direction channel property a more-private GObject incoming property. (Jonny Lamb)

Signed-off-by: Jonny Lamb <jonny lamb collabora co uk>

Modified:
   trunk/libempathy-gtk/empathy-ft-manager.c
   trunk/libempathy/empathy-tp-file.c
   trunk/libempathy/empathy-tp-file.h

Modified: trunk/libempathy-gtk/empathy-ft-manager.c
==============================================================================
--- trunk/libempathy-gtk/empathy-ft-manager.c	(original)
+++ trunk/libempathy-gtk/empathy-ft-manager.c	Fri Nov 21 16:16:44 2008
@@ -276,8 +276,7 @@
 
       if (empathy_tp_file_get_state (tp_file) == EMP_FILE_TRANSFER_STATE_COMPLETED)
         {
-          if (empathy_tp_file_get_direction (tp_file) ==
-              EMP_FILE_TRANSFER_DIRECTION_INCOMING)
+          if (empathy_tp_file_get_incoming (tp_file))
             open_enabled = TRUE;
           else
             open_enabled = FALSE;
@@ -399,15 +398,16 @@
             g_free (total_size_str);
 
           }
+        else if (state == EMP_FILE_TRANSFER_STATE_NOT_OFFERED)
+          second_line = g_strdup (_("File not yet offered"));
         else
-          second_line = g_strdup (_("Wating the other participant's response"));
+          second_line = g_strdup (_("Waiting the other participant's response"));
 
       remaining = empathy_tp_file_get_remaining_time (tp_file);
       break;
 
     case EMP_FILE_TRANSFER_STATE_COMPLETED:
-      if (empathy_tp_file_get_direction (tp_file) ==
-          EMP_FILE_TRANSFER_DIRECTION_INCOMING)
+      if (empathy_tp_file_get_incoming (tp_file))
         /* translators: first %s is filename, second %s
          * is the contact name */
         first_line = g_strdup_printf (
@@ -425,8 +425,7 @@
       break;
 
     case EMP_FILE_TRANSFER_STATE_CANCELED:
-      if (empathy_tp_file_get_direction (tp_file) ==
-          EMP_FILE_TRANSFER_DIRECTION_INCOMING)
+      if (empathy_tp_file_get_incoming (tp_file))
         /* translators: first %s is filename, second %s
          * is the contact name */
         first_line = g_strdup_printf (
@@ -510,8 +509,7 @@
   switch (empathy_tp_file_get_state (tp_file))
     {
       case EMP_FILE_TRANSFER_STATE_COMPLETED:
-        if (empathy_tp_file_get_direction (tp_file) ==
-            EMP_FILE_TRANSFER_DIRECTION_INCOMING)
+        if (empathy_tp_file_get_incoming (tp_file))
           {
             GtkRecentManager *manager;
             const gchar *uri;

Modified: trunk/libempathy/empathy-tp-file.c
==============================================================================
--- trunk/libempathy/empathy-tp-file.c	(original)
+++ trunk/libempathy/empathy-tp-file.c	Fri Nov 21 16:16:44 2008
@@ -101,8 +101,8 @@
   EmpathyContact *contact;
   GInputStream *in_stream;
   GOutputStream *out_stream;
+  gboolean incoming;
   gchar *filename;
-  EmpFileTransferDirection direction;
   EmpFileTransferState state;
   EmpFileTransferStateChangeReason state_change_reason;
   guint64 size;
@@ -120,7 +120,7 @@
   PROP_ACCOUNT,
   PROP_CHANNEL,
   PROP_STATE,
-  PROP_DIRECTION,
+  PROP_INCOMING,
   PROP_FILENAME,
   PROP_SIZE,
   PROP_CONTENT_TYPE,
@@ -172,13 +172,11 @@
           G_PARAM_CONSTRUCT));
 
   g_object_class_install_property (object_class,
-      PROP_DIRECTION,
-      g_param_spec_uint ("direction",
-          "direction of the transfer",
-          "The file transfer direction",
-          0,
-          G_MAXUINT,
-          G_MAXUINT,
+      PROP_INCOMING,
+      g_param_spec_boolean ("incoming",
+          "incoming",
+          "Whether the transfer is incoming",
+          FALSE,
           G_PARAM_READWRITE |
           G_PARAM_CONSTRUCT));
 
@@ -443,8 +441,8 @@
       case PROP_STATE:
         priv->state = g_value_get_uint (value);
         break;
-      case PROP_DIRECTION:
-        priv->direction = g_value_get_uint (value);
+      case PROP_INCOMING:
+        priv->incoming = g_value_get_boolean (value);
         break;
       case PROP_FILENAME:
         g_free (priv->filename);
@@ -737,17 +735,15 @@
   if (state == EMP_FILE_TRANSFER_STATE_OPEN)
     priv->start_time = get_time_msec ();
 
-  DEBUG ("state = %u, direction = %u, in_stream = %s, out_stream = %s",
-      state, priv->direction,
+  DEBUG ("state = %u, incoming = %s, in_stream = %s, out_stream = %s",
+      state, priv->incoming ? "yes" : "no",
       priv->in_stream ? "present" : "not present",
       priv->out_stream ? "present" : "not present");
 
-  if (state == EMP_FILE_TRANSFER_STATE_OPEN &&
-      priv->direction == EMP_FILE_TRANSFER_DIRECTION_OUTGOING &&
+  if (state == EMP_FILE_TRANSFER_STATE_OPEN && !priv->incoming &&
       priv->in_stream)
     send_tp_file (tp_file);
-  else if (state == EMP_FILE_TRANSFER_STATE_OPEN &&
-      priv->direction == EMP_FILE_TRANSFER_DIRECTION_INCOMING &&
+  else if (state == EMP_FILE_TRANSFER_STATE_OPEN && priv->incoming &&
       priv->out_stream)
       receive_tp_file (tp_file);
 
@@ -815,14 +811,14 @@
   return priv->filename;
 }
 
-EmpFileTransferDirection
-empathy_tp_file_get_direction (EmpathyTpFile *tp_file)
+gboolean
+empathy_tp_file_get_incoming (EmpathyTpFile *tp_file)
 {
   EmpathyTpFilePriv *priv;
 
   priv = GET_PRIV (tp_file);
 
-  return priv->direction;
+  return priv->incoming;
 }
 
 EmpFileTransferState
@@ -915,7 +911,7 @@
   if (priv->in_stream == in_stream)
     return;
 
-  if (priv->direction == EMP_FILE_TRANSFER_DIRECTION_INCOMING)
+  if (priv->incoming)
     g_warning ("Setting an input stream for incoming file "
          "transfers is useless");
 
@@ -941,7 +937,7 @@
   if (priv->out_stream == out_stream)
     return;
 
-  if (priv->direction == EMP_FILE_TRANSFER_DIRECTION_OUTGOING)
+  if (!priv->incoming)
     g_warning ("Setting an output stream for outgoing file "
          "transfers is useless");
 

Modified: trunk/libempathy/empathy-tp-file.h
==============================================================================
--- trunk/libempathy/empathy-tp-file.h	(original)
+++ trunk/libempathy/empathy-tp-file.h	Fri Nov 21 16:16:44 2008
@@ -74,7 +74,7 @@
 GInputStream *empathy_tp_file_get_input_stream (EmpathyTpFile *tp_file);
 GOutputStream *empathy_tp_file_get_output_stream (EmpathyTpFile *tp_file);
 const gchar *empathy_tp_file_get_filename (EmpathyTpFile *tp_file);
-EmpFileTransferDirection empathy_tp_file_get_direction (EmpathyTpFile *tp_file);
+gboolean empathy_tp_file_get_incoming (EmpathyTpFile *tp_file);
 EmpFileTransferState empathy_tp_file_get_state (EmpathyTpFile *tp_file);
 EmpFileTransferStateChangeReason empathy_tp_file_get_state_change_reason (EmpathyTpFile *tp_file);
 guint64 empathy_tp_file_get_size (EmpathyTpFile *tp_file);