orca r4352 - in trunk: . src/orca

[wwalker svn gnome org]

Author: wwalker
Date: Wed Nov 19 16:34:28 2008
New Revision: 4352
URL: http://svn.gnome.org/viewvc/orca?rev=4352&view=rev

Log:
Fix for bug #554002 - Orca App-Preferences dialog page tabs are "off" by one in speech and braille.


Modified:
   trunk/ChangeLog
   trunk/src/orca/app_gui_prefs.py
   trunk/src/orca/default.py

Modified: trunk/src/orca/app_gui_prefs.py
==============================================================================
--- trunk/src/orca/app_gui_prefs.py	(original)
+++ trunk/src/orca/app_gui_prefs.py	Wed Nov 19 16:34:28 2008
@@ -86,7 +86,13 @@
         #
         self.appScript = thisAppScript
 
-        self.get_widget("notebook").remove_page(0)
+        # Don't remove the page because this tickles some strange bug
+        # in gail or gtk+ (see bug #554002).  Instead, we'll just hide it.
+        #
+        # self.get_widget("notebook").remove_page(0)
+        generalTab = self.get_widget("notebook").get_children()[0]
+        generalTab.hide()
+
         self.get_widget("speechSystemsLabel").set_sensitive(False)
         self.get_widget("speechSystems").set_sensitive(False)
         self.get_widget("speechServersLabel").set_sensitive(False)

Modified: trunk/src/orca/default.py
==============================================================================
--- trunk/src/orca/default.py	(original)
+++ trunk/src/orca/default.py	Wed Nov 19 16:34:28 2008
@@ -5942,15 +5942,6 @@
         if role == pyatspi.ROLE_COMBO_BOX:
             return self.__getDisplayedTextInComboBox(obj)
 
-        if role == pyatspi.ROLE_PAGE_TAB and obj.name:
-            # It seems that hiding a page tab can result in the accessible
-            # text being the text associated with the previous page tab.
-            # The accessible name, however, continues to be correct. For
-            # now, let's use the name -- until the Gtk+ bug is pinned down
-            # and fixed. See bug #554002.
-            #
-            return obj.name
-
         # The accessible text of an object is used to represent what is
         # drawn on the screen.
         #