online-desktop r7293 - trunk/weblogindriver



Author: marinaz
Date: Mon Nov 17 20:27:17 2008
New Revision: 7293
URL: http://svn.gnome.org/viewvc/online-desktop?rev=7293&view=rev

Log:
Remove more places where signon information was logged in the debug output.


Modified:
   trunk/weblogindriver/web-login-driver

Modified: trunk/weblogindriver/web-login-driver
==============================================================================
--- trunk/weblogindriver/web-login-driver	(original)
+++ trunk/weblogindriver/web-login-driver	Mon Nov 17 20:27:17 2008
@@ -192,12 +192,11 @@
       changed_signons = new_signons.itervalues()
       # todo signal on delete?
     for signons in changed_signons:
-      _logger.debug("evaluating %s", signons)
       for signon in signons:
         for hintname,handler in internal_matchers.iteritems():
           if signon.get('hint', '') == hintname:
             try:
-              _logger.debug("invoking handler %s for signon %s", handler, signon)
+              _logger.debug("invoking handler %s for a signon", handler)
               handler(signon)
             except:
               _logger.error("handler %s failed", handler, exc_info=True)
@@ -267,7 +266,8 @@
         l = new_signons[hostname]
         l.append(dict(signon))
         # Don't log the actual signon data to avoid logging the password
-        _logger.debug("processed signon for %s", hostname)
+        # No need to log the hostnames either, because we are not using any of them except for Google ones anyway
+        # _logger.debug("processed signon for %s", hostname)
         process_entry = False
 
     return new_signons
@@ -1013,7 +1013,7 @@
         if signon['hint'] == 'GMail':
             username = str(signon['username']) + "@gmail.com" 
         password = base64.b64decode(signon['password'])
-        _logger.debug("got signon information %s" % str(signon))                
+        _logger.debug("got signon information for %s" % username)                
         account = self.__find_weblogin_account(TYPE_GOOGLE, username)
         _logger.debug("found weblogin account %s" % str(account))
         if not account:
@@ -1042,7 +1042,6 @@
     # for an existing weblogin account if the updated signon information is passed in here.
     # Once we make this change, we'll need to make sure to associate the right hostnames with
     # weblogin accounts, in case they don't match what we store in the url.
-    _logger.debug("signons changed: %s", signons)
     self.__check_signons(signons)
 
   def __on_dbus_error(self, err):



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]