empathy r1696 - trunk/libempathy-gtk



Author: xclaesse
Date: Tue Nov 11 15:27:20 2008
New Revision: 1696
URL: http://svn.gnome.org/viewvc/empathy?rev=1696&view=rev

Log:
Flip iterating across format_mime_types and accepted_mime_types.

This better reflects the purpose of the conditional; "for each mime type
we can convert to, is it acceptable?" is clearer than "for each
acceptable mime type, can we convert to it?".

Modified:
   trunk/libempathy-gtk/empathy-avatar-chooser.c

Modified: trunk/libempathy-gtk/empathy-avatar-chooser.c
==============================================================================
--- trunk/libempathy-gtk/empathy-avatar-chooser.c	(original)
+++ trunk/libempathy-gtk/empathy-avatar-chooser.c	Tue Nov 11 15:27:20 2008
@@ -332,8 +332,8 @@
 		}
 
 		format_mime_types = gdk_pixbuf_format_get_mime_types (format);
-		for (strv = accepted_mime_types; *strv != NULL; strv++) {
-			if (str_in_strv (*strv, format_mime_types)) {
+		for (strv = format_mime_types; *strv != NULL; strv++) {
+			if (str_in_strv (*strv, accepted_mime_types)) {
 				*satisfactory_format_name = gdk_pixbuf_format_get_name (format);
 				*satisfactory_mime_type = g_strdup (*strv);
 				done = TRUE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]