empathy r1690 - trunk/libempathy-gtk

[xclaesse svn gnome org]

Author: xclaesse
Date: Tue Nov 11 15:26:54 2008
New Revision: 1690
URL: http://svn.gnome.org/viewvc/empathy?rev=1690&view=rev

Log:
AvatarChooser needs no ContactFactory property; it's a singleton.

Modified:
   trunk/libempathy-gtk/empathy-avatar-chooser.c
   trunk/libempathy-gtk/empathy-avatar-chooser.h
   trunk/libempathy-gtk/empathy-contact-widget.c

Modified: trunk/libempathy-gtk/empathy-avatar-chooser.c
==============================================================================
--- trunk/libempathy-gtk/empathy-avatar-chooser.c	(original)
+++ trunk/libempathy-gtk/empathy-avatar-chooser.c	Tue Nov 11 15:26:54 2008
@@ -93,7 +93,6 @@
 
 enum {
 	PROP_0,
-	PROP_CONTACT_FACTORY,
 	PROP_ACCOUNT
 };
 
@@ -123,10 +122,6 @@
 	EmpathyAvatarChooserPriv *priv = GET_PRIV (object);
 
 	switch (param_id) {
-	case PROP_CONTACT_FACTORY:
-		g_assert (priv->contact_factory != NULL);
-		g_value_set_object (value, priv->contact_factory);
-		break;
 	case PROP_ACCOUNT:
 		g_value_set_object (value, priv->account);
 		break;
@@ -143,16 +138,8 @@
 				     GParamSpec   *pspec)
 {
 	EmpathyAvatarChooser *self = EMPATHY_AVATAR_CHOOSER (object);
-	EmpathyAvatarChooserPriv *priv = GET_PRIV (self);
 
 	switch (param_id) {
-	case PROP_CONTACT_FACTORY:
-		priv->contact_factory = g_value_get_object (value);
-
-		g_assert (priv->contact_factory != NULL);
-		g_object_ref (priv->contact_factory);
-
-		break;
 	case PROP_ACCOUNT:
 		avatar_chooser_set_account (self, g_value_get_object (value));
 		break;
@@ -181,18 +168,6 @@
 			      g_cclosure_marshal_VOID__VOID,
 			      G_TYPE_NONE, 0);
 
-	param_spec = g_param_spec_object ("contact-factory",
-					  "EmpathyContactFactory instance",
-					  "EmpathyContactFactory instance "
-					  "(may not be NULL)",
-					  EMPATHY_TYPE_CONTACT_FACTORY,
-					  G_PARAM_CONSTRUCT_ONLY |
-					  G_PARAM_READWRITE |
-					  G_PARAM_STATIC_STRINGS);
-	g_object_class_install_property (object_class,
-					 PROP_CONTACT_FACTORY,
-					 param_spec);
-
 	param_spec = g_param_spec_object ("account",
 					  "McAccount",
 					  "McAccount whose avatar should be "
@@ -236,6 +211,8 @@
 			  G_CALLBACK (avatar_chooser_clicked_cb),
 			  chooser);
 
+	priv->contact_factory = empathy_contact_factory_new ();
+
 	empathy_avatar_chooser_set (chooser, NULL);
 }
 
@@ -888,11 +865,9 @@
 }
 
 GtkWidget *
-empathy_avatar_chooser_new (EmpathyContactFactory *contact_factory)
+empathy_avatar_chooser_new ()
 {
-	return g_object_new (EMPATHY_TYPE_AVATAR_CHOOSER,
-			     "contact-factory", contact_factory,
-			     NULL);
+	return g_object_new (EMPATHY_TYPE_AVATAR_CHOOSER, NULL);
 }
 
 /* FIXME: when the avatar passed to this function actually can be relied upon to

Modified: trunk/libempathy-gtk/empathy-avatar-chooser.h
==============================================================================
--- trunk/libempathy-gtk/empathy-avatar-chooser.h	(original)
+++ trunk/libempathy-gtk/empathy-avatar-chooser.h	Tue Nov 11 15:26:54 2008
@@ -50,7 +50,7 @@
 };
 
 GType      empathy_avatar_chooser_get_type       (void);
-GtkWidget *empathy_avatar_chooser_new            (EmpathyContactFactory *contact_factory);
+GtkWidget *empathy_avatar_chooser_new            (void);
 void       empathy_avatar_chooser_set            (EmpathyAvatarChooser *chooser,
 						  EmpathyAvatar        *avatar);
 void       empathy_avatar_chooser_get_image_data (EmpathyAvatarChooser *chooser,

Modified: trunk/libempathy-gtk/empathy-contact-widget.c
==============================================================================
--- trunk/libempathy-gtk/empathy-contact-widget.c	(original)
+++ trunk/libempathy-gtk/empathy-contact-widget.c	Tue Nov 11 15:26:54 2008
@@ -499,8 +499,7 @@
 {
   if (information->flags & EMPATHY_CONTACT_WIDGET_EDIT_AVATAR)
     {
-      information->widget_avatar = empathy_avatar_chooser_new (
-          information->factory);
+      information->widget_avatar = empathy_avatar_chooser_new ();
       g_signal_connect (information->widget_avatar, "changed",
             G_CALLBACK (contact_widget_avatar_changed_cb),
             information);