brasero r1479 - in trunk: . src src/plugins/cdrdao src/plugins/checksum src/plugins/dvdcss
- From: philippr svn gnome org
- To: svn-commits-list gnome org
- Subject: brasero r1479 - in trunk: . src src/plugins/cdrdao src/plugins/checksum src/plugins/dvdcss
- Date: Thu, 6 Nov 2008 12:28:55 +0000 (UTC)
Author: philippr
Date: Thu Nov 6 12:28:55 2008
New Revision: 1479
URL: http://svn.gnome.org/viewvc/brasero?rev=1479&view=rev
Log:
Fix for #559414 â format not a string literal and no format arguments
Patch by Christian Persch
* src/brasero-app.c (on_help_cb):
* src/brasero-burn-dialog.c (brasero_burn_dialog_insert_disc_cb),
(brasero_burn_dialog_loss_warnings_cb):
* src/brasero-sum-dialog.c (brasero_sum_dialog_message),
(brasero_sum_dialog_corruption_warning),
(brasero_sum_dialog_get_file_checksum):
* src/burn-job.c (brasero_job_check_output_volume_space),
(brasero_job_set_output_file), (brasero_job_set_nonblocking_fd):
* src/burn-mkisofs-base.c (_write_line),
(brasero_mkisofs_base_process_video_graft),
(brasero_mkisofs_base_write_to_files):
* src/burn-volume-source.c (brasero_volume_source_seek_fd),
(brasero_volume_source_read_fd),
(brasero_volume_source_readcd_device_handle),
(brasero_volume_source_read10_device_handle),
(brasero_volume_source_open_file), (brasero_volume_source_open_fd):
* src/plugins/cdrdao/burn-toc2cue.c (brasero_toc2cue_read_stderr):
* src/plugins/checksum/burn-checksum-files.c
(brasero_checksum_file_process_former_line),
(brasero_checksum_files_get_line_num),
(brasero_checksum_files_check_files):
* src/plugins/dvdcss/burn-dvdcss.c
(brasero_dvdcss_write_image_thread):
* src/scsi-error.c (brasero_scsi_set_error):
Modified:
trunk/ChangeLog
trunk/src/brasero-app.c
trunk/src/brasero-burn-dialog.c
trunk/src/brasero-sum-dialog.c
trunk/src/burn-job.c
trunk/src/burn-mkisofs-base.c
trunk/src/burn-volume-source.c
trunk/src/plugins/cdrdao/burn-toc2cue.c
trunk/src/plugins/checksum/burn-checksum-files.c
trunk/src/plugins/dvdcss/burn-dvdcss.c
trunk/src/scsi-error.c
Modified: trunk/src/brasero-app.c
==============================================================================
--- trunk/src/brasero-app.c (original)
+++ trunk/src/brasero-app.c Thu Nov 6 12:28:55 2008
@@ -479,7 +479,7 @@
d = gtk_message_dialog_new (GTK_WINDOW (app),
GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_ERROR, GTK_BUTTONS_OK,
- error->message);
+ "%s", error->message);
gtk_dialog_run (GTK_DIALOG(d));
gtk_widget_destroy (d);
g_error_free (error);
Modified: trunk/src/brasero-burn-dialog.c
==============================================================================
--- trunk/src/brasero-burn-dialog.c (original)
+++ trunk/src/brasero-burn-dialog.c Thu Nov 6 12:28:55 2008
@@ -572,11 +572,11 @@
GTK_DIALOG_MODAL,
GTK_MESSAGE_WARNING,
GTK_BUTTONS_CANCEL,
- main_message);
+ "%s", main_message);
if (secondary_message) {
gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (message),
- secondary_message);
+ "%s", secondary_message);
g_free (secondary_message);
}
}
@@ -586,7 +586,7 @@
GTK_DIALOG_MODAL,
GTK_MESSAGE_WARNING,
GTK_BUTTONS_CANCEL,
- main_message);
+ "%s", main_message);
g_free (main_message);
@@ -656,12 +656,12 @@
GTK_DIALOG_MODAL,
GTK_MESSAGE_WARNING,
GTK_BUTTONS_NONE,
- main_message);
+ "%s", main_message);
gtk_window_set_title (GTK_WINDOW (message), title);
gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (message),
- secondary_message);
+ "%s", secondary_message);
gtk_dialog_add_buttons (GTK_DIALOG (message),
GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
Modified: trunk/src/brasero-sum-dialog.c
==============================================================================
--- trunk/src/brasero-sum-dialog.c (original)
+++ trunk/src/brasero-sum-dialog.c Thu Nov 6 12:28:55 2008
@@ -113,12 +113,12 @@
GTK_DIALOG_DESTROY_WITH_PARENT,
type,
GTK_BUTTONS_NONE,
- primary_message);
+ "%s", primary_message);
gtk_window_set_title (GTK_WINDOW (message), title);
gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (message),
- secondary_message);
+ "%s", secondary_message);
button = brasero_utils_make_button (_("Check _Again"),
GTK_STOCK_FIND,
@@ -196,7 +196,7 @@
GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_ERROR,
GTK_BUTTONS_NONE,
- string);
+ "%s", string);
g_free (string);
gtk_window_set_title (GTK_WINDOW (message), _("File Integrity Check Error"));
@@ -403,10 +403,10 @@
g_free (src);
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
@@ -420,10 +420,10 @@
g_free (src);
if (ferror (file)) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
fclose (file);
return BRASERO_BURN_ERR;
Modified: trunk/src/burn-job.c
==============================================================================
--- trunk/src/burn-job.c (original)
+++ trunk/src/burn-job.c Thu Nov 6 12:28:55 2008
@@ -495,10 +495,10 @@
/* Last but not least, use getrlimit () to check that we are allowed to
* write a file of such length and that quotas won't get in our way */
if (getrlimit (RLIMIT_FSIZE, &limit)) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_DISK_SPACE,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_DISK_SPACE,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
@@ -518,10 +518,10 @@
error:
if (error && *error == NULL)
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- _("the size of the volume can't be checked (Unknown error)"));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ _("the size of the volume can't be checked (Unknown error)"));
g_object_unref (file);
return BRASERO_BURN_ERR;
}
@@ -558,10 +558,10 @@
/* check paths are set */
if (!image
|| (priv->type.subtype.img_format != BRASERO_IMAGE_FORMAT_BIN && !toc)) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- _("no path"));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ _("no path"));
return BRASERO_BURN_ERR;
}
@@ -1176,18 +1176,18 @@
* automatically but still offer that possibility. */
flags |= O_NONBLOCK;
if (fcntl (fd, F_SETFL, flags) == -1) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- _("couldn't set non blocking mode"));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ _("couldn't set non blocking mode"));
return BRASERO_BURN_ERR;
}
}
else {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- _("couldn't get pipe flags"));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ _("couldn't get pipe flags"));
return BRASERO_BURN_ERR;
}
Modified: trunk/src/burn-mkisofs-base.c
==============================================================================
--- trunk/src/burn-mkisofs-base.c (original)
+++ trunk/src/burn-mkisofs-base.c Thu Nov 6 12:28:55 2008
@@ -91,10 +91,10 @@
if (lseek (fd, 0, SEEK_CUR)
&& write (fd, "\n", 1) != 1) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
@@ -102,10 +102,10 @@
w_len = write (fd, filepath, len);
if (w_len != len) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
@@ -397,10 +397,10 @@
g_free (link_path);
if (res) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
@@ -493,20 +493,20 @@
base.grafts_fd = open (grafts_path, O_WRONLY|O_TRUNC|O_EXCL);
if (base.grafts_fd == -1) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
base.excluded_fd = open (excluded_path, O_WRONLY|O_TRUNC|O_EXCL);
if (base.excluded_fd == -1) {
close (base.excluded_fd);
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
Modified: trunk/src/burn-volume-source.c
==============================================================================
--- trunk/src/burn-volume-source.c (original)
+++ trunk/src/burn-volume-source.c Thu Nov 6 12:28:55 2008
@@ -70,10 +70,10 @@
block,
(guint64) (block * ISO9660_BLOCK_SIZE),
strerror (errno));
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return -1;
}
@@ -93,10 +93,10 @@
bytes_read = fread (buffer, 1, ISO9660_BLOCK_SIZE * blocks, src->data);
if (bytes_read != ISO9660_BLOCK_SIZE * blocks) {
BRASERO_BURN_LOG ("fread () failed (%s)", strerror (errno));
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return FALSE;
}
@@ -161,10 +161,10 @@
}
}
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- brasero_scsi_strerror (code));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ brasero_scsi_strerror (code));
return FALSE;
}
@@ -193,10 +193,10 @@
BRASERO_BURN_LOG ("READ10 failed %s at %i",
brasero_scsi_strerror (code),
src->position);
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- brasero_scsi_strerror (code));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ brasero_scsi_strerror (code));
return FALSE;
}
@@ -224,10 +224,10 @@
file = fopen (path, "r");
if (!file) {
BRASERO_BURN_LOG ("open () failed (%s)", strerror (errno));
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return FALSE;
}
@@ -250,10 +250,10 @@
dup_fd = dup (fd);
if (dup_fd == -1) {
BRASERO_BURN_LOG ("dup () failed (%s)", strerror (errno));
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return FALSE;
}
@@ -262,10 +262,10 @@
close (dup_fd);
BRASERO_BURN_LOG ("fdopen () failed (%s)", strerror (errno));
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return FALSE;
}
Modified: trunk/src/plugins/cdrdao/burn-toc2cue.c
==============================================================================
--- trunk/src/plugins/cdrdao/burn-toc2cue.c (original)
+++ trunk/src/plugins/cdrdao/burn-toc2cue.c Thu Nov 6 12:28:55 2008
@@ -110,9 +110,9 @@
g_free (toc_path);
brasero_job_error (BRASERO_JOB (process),
- g_error_new (BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno)));
+ g_error_new_literal (BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno)));
return BRASERO_BURN_OK;
}
@@ -150,9 +150,9 @@
g_free (toc_path);
brasero_job_error (BRASERO_JOB (process),
- g_error_new (BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno)));
+ g_error_new_literal (BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno)));
return BRASERO_BURN_OK;
}
@@ -175,17 +175,17 @@
* image path of the new track just created */
if (g_rename (tmp_img_path, img_path)) {
brasero_job_error (BRASERO_JOB (self),
- g_error_new (BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno)));
+ g_error_new_literal (BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno)));
return BRASERO_BURN_OK;
}
if (link (img_path, tmp_img_path)) {
brasero_job_error (BRASERO_JOB (self),
- g_error_new (BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno)));
+ g_error_new_literal (BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno)));
return BRASERO_BURN_OK;
} /* symlink () could also be used */
Modified: trunk/src/plugins/checksum/burn-checksum-files.c
==============================================================================
--- trunk/src/plugins/checksum/burn-checksum-files.c (original)
+++ trunk/src/plugins/checksum/burn-checksum-files.c Thu Nov 6 12:28:55 2008
@@ -331,18 +331,18 @@
/* write the whole line in the new file */
written_bytes = fwrite (line, 1, strlen (line), priv->file);
if (written_bytes != strlen (line)) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
if (!fwrite ("\n", 1, 1, priv->file)) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
@@ -659,10 +659,10 @@
}
if (!feof (file)) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return -1;
}
@@ -711,20 +711,20 @@
g_free (root);
g_free (path);
if (!file) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
return BRASERO_BURN_ERR;
}
/* we need to get the number of files at this time and rewind */
file_nb = brasero_checksum_files_get_line_num (self, file, error);
if (file_nb < 1) {
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
fclose (file);
return BRASERO_BURN_ERR;
}
@@ -765,10 +765,10 @@
/* first read the checksum string */
if (fread (checksum_file, 1, checksum_len, file) != checksum_len) {
if (!feof (file))
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
break;
}
checksum_file [checksum_len] = '\0';
@@ -787,10 +787,10 @@
if (errno == EAGAIN || errno == EINTR)
continue;
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
goto end;
}
@@ -811,10 +811,10 @@
if (errno == EAGAIN || errno == EINTR)
continue;
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
goto end;
}
@@ -888,10 +888,10 @@
BRASERO_TRACK_MEDIUM_WRONG_CHECKSUM_TAG,
value);
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_BAD_CHECKSUM,
- _("some files may be corrupted on the disc"));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_BAD_CHECKSUM,
+ _("some files may be corrupted on the disc"));
return BRASERO_BURN_ERR;
}
Modified: trunk/src/plugins/dvdcss/burn-dvdcss.c
==============================================================================
--- trunk/src/plugins/dvdcss/burn-dvdcss.c (original)
+++ trunk/src/plugins/dvdcss/burn-dvdcss.c Thu Nov 6 12:28:55 2008
@@ -391,9 +391,9 @@
g_free (output);
if (!output_fd) {
- priv->error = g_error_new (BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- strerror (errno));
+ priv->error = g_error_new_literal (BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ g_strerror (errno));
goto end;
}
}
Modified: trunk/src/scsi-error.c
==============================================================================
--- trunk/src/scsi-error.c (original)
+++ trunk/src/scsi-error.c Thu Nov 6 12:28:55 2008
@@ -62,8 +62,8 @@
if (!error)
return;
- g_set_error (error,
- BRASERO_BURN_ERROR,
- BRASERO_BURN_ERROR_GENERAL,
- brasero_scsi_strerror (code));
+ g_set_error_literal (error,
+ BRASERO_BURN_ERROR,
+ BRASERO_BURN_ERROR_GENERAL,
+ brasero_scsi_strerror (code));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
