eog r4588 - in trunk: . src

[friemann svn gnome org]

Author: friemann
Date: Fri May 30 21:22:01 2008
New Revision: 4588
URL: http://svn.gnome.org/viewvc/eog?rev=4588&view=rev

Log:
2008-05-30  Felix Riemann  <friemann svn gnome org>

	* src/eog-window.c: (eog_window_update_openwith_menu):
	Keep the GFileInfo alive while we depend on pointers to its 
data.
	Fixes lots of invalid read errors with Valgrind.


Modified:
   trunk/ChangeLog
   trunk/src/eog-window.c

Modified: trunk/src/eog-window.c
==============================================================================
--- trunk/src/eog-window.c	(original)
+++ trunk/src/eog-window.c	Fri May 30 21:22:01 2008
@@ -1085,7 +1085,6 @@
 		return;
 	else {
 		mime_type = g_file_info_get_content_type (file_info);
-		g_object_unref (file_info);
 	}
 	
         if (priv->open_with_menu_id != 0) {
@@ -1103,6 +1102,8 @@
 
         apps = g_app_info_get_all_for_type (mime_type);
 
+	g_object_unref (file_info);
+
         if (!apps)
                 return;