gnome-terminal r2843 - trunk/src

[chpe svn gnome org]

Author: chpe
Date: Thu May 29 19:59:28 2008
New Revision: 2843
URL: http://svn.gnome.org/viewvc/gnome-terminal?rev=2843&view=rev

Log:
Convert the remaining FIXMEs, they still make sense.


Modified:
   trunk/src/encoding.c
   trunk/src/skey-popup.c
   trunk/src/terminal-app.c
   trunk/src/terminal-profile.c
   trunk/src/terminal-window.c
   trunk/src/terminal.c

Modified: trunk/src/encoding.c
==============================================================================
--- trunk/src/encoding.c	(original)
+++ trunk/src/encoding.c	Thu May 29 19:59:28 2008
@@ -117,7 +117,7 @@
   { "WINDOWS-1258",	N_("Vietnamese") },
 #if 0
   /* These encodings do NOT pass-through ASCII, so are always rejected.
-   * FIXMEchpe: why are they in this table; or rather why do we need
+   * FIXME: why are they in this table; or rather why do we need
    * the ASCII pass-through requirement?
    */
   { "UTF-7",  N_("Unicode") },

Modified: trunk/src/skey-popup.c
==============================================================================
--- trunk/src/skey-popup.c	(original)
+++ trunk/src/skey-popup.c	Thu May 29 19:59:28 2008
@@ -205,7 +205,7 @@
   gtk_window_set_modal (GTK_WINDOW (dialog), TRUE);
   gtk_window_set_destroy_with_parent (GTK_WINDOW (dialog), TRUE);
 
-  /* FIXMEchpe: make this dialogue close if the screen closes! */
+  /* FIXME: make this dialogue close if the screen closes! */
 
   data = g_new (SkeyData, 1);
   data->hash = hash;

Modified: trunk/src/terminal-app.c
==============================================================================
--- trunk/src/terminal-app.c	(original)
+++ trunk/src/terminal-app.c	Thu May 29 19:59:28 2008
@@ -1686,7 +1686,6 @@
 TerminalWindow *
 terminal_app_get_current_window (TerminalApp *app)
 {
-  /* FIXMEchpe take focus into account! */
   return g_list_last (app->windows)->data;
 }
 

Modified: trunk/src/terminal-profile.c
==============================================================================
--- trunk/src/terminal-profile.c	(original)
+++ trunk/src/terminal-profile.c	Thu May 29 19:59:28 2008
@@ -559,7 +559,7 @@
   if (G_IS_PARAM_SPEC_BOOLEAN (pspec))
     {
       if (gconf_value->type != GCONF_VALUE_BOOL)
-        goto out; /* FIXMEchpe maybe reset? */
+        goto out;
 
       g_value_set_boolean (&value, gconf_value_get_bool (gconf_value));
     }
@@ -691,7 +691,7 @@
     }
 
 out:
-  /* FIXMEchpe: if we arrive here through goto in the error cases,
+  /* FIXME: if we arrive here through goto in the error cases,
    * should we maybe reset the property to its default value?
    */
 
@@ -708,7 +708,7 @@
   char *key;
   const GValue *value;
 
-  /* FIXMEchpe: do this? */
+  /* FIXME: do this? */
 #if 0
   if (priv->locked[pspec->param_id])
     return;

Modified: trunk/src/terminal-window.c
==============================================================================
--- trunk/src/terminal-window.c	(original)
+++ trunk/src/terminal-window.c	Thu May 29 19:59:28 2008
@@ -2192,7 +2192,7 @@
   /* ZvtTerm is a broken POS and requires this realize to get
    * the size request right.
    */
-  /* FIXMEchpe: does this apply to VTE? */
+  /* FIXME: does this apply to VTE? */
   gtk_widget_realize (GTK_WIDGET (screen));
 
   /* If we have an active screen, match its size and zoom */
@@ -2209,7 +2209,7 @@
     }
   
   /* Make the first-added screen the active one */
-  /* FIXMEchpe: this shouldn't be necessary since we'll immediately get
+  /* FIXME: this shouldn't be necessary since we'll immediately get
    * page-selected callback.
    */
   if (priv->active_screen == NULL)

Modified: trunk/src/terminal.c
==============================================================================
--- trunk/src/terminal.c	(original)
+++ trunk/src/terminal.c	Thu May 29 19:59:28 2008
@@ -1206,7 +1206,7 @@
           option_parsing_results_free (parsing_results);
           return 0;
         }
-      /* FIXMEchpe: else return 1; ? */
+      /* FIXME: else return 1; ? */
     }
 
   g_strfreev (argv_copy);