banshee r4006 - in trunk/banshee: . src/Libraries/Hyena/Hyena.Query



Author: gburt
Date: Wed May 28 17:56:54 2008
New Revision: 4006
URL: http://svn.gnome.org/viewvc/banshee?rev=4006&view=rev

Log:
2008-05-28  Gabriel Burt  <gabriel burt gmail com>

	* src/Libraries/Hyena/Hyena.Query/QueryField.cs: Fix bug with querying and
	smart playlists with "genre!:rock" would still match Rock.
	Fixes BGO #533143.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Libraries/Hyena/Hyena.Query/QueryField.cs

Modified: trunk/banshee/src/Libraries/Hyena/Hyena.Query/QueryField.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena/Hyena.Query/QueryField.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena/Hyena.Query/QueryField.cs	Wed May 28 17:56:54 2008
@@ -145,9 +145,10 @@
                         // Match string values literally and against a lower'd version.  Mostly a workaround
                         // the fact that Sqlite's lower() method only works for ASCII (meaning even with this,
                         // we're not getting 100% case-insensitive matching).
-                        sb.AppendFormat ("({0} {1} OR LOWER({0}) {2})", Column,
+                        sb.AppendFormat ("({0} {1} {3} LOWER({0}) {2})", Column,
                             String.Format (op.SqlFormat, value),
-                            String.Format (op.SqlFormat, value.ToLower ())
+                            String.Format (op.SqlFormat, value.ToLower ()),
+                            op.IsNot ? "AND" : "OR"
                         );
                     }
                 } else {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]