gnumeric r16586 - in branches/gnumeric-1-8: . plugins/fn-math

[mortenw svn gnome org]

Author: mortenw
Date: Tue May 20 00:41:22 2008
New Revision: 16586
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16586&view=rev

Log:
2008-05-19  Morten Welinder  <terra gnome org>

	* functions.c (gnumeric_sumproduct): Band-aid #533507.




Modified:
   branches/gnumeric-1-8/NEWS
   branches/gnumeric-1-8/plugins/fn-math/ChangeLog
   branches/gnumeric-1-8/plugins/fn-math/functions.c

Modified: branches/gnumeric-1-8/NEWS
==============================================================================
--- branches/gnumeric-1-8/NEWS	(original)
+++ branches/gnumeric-1-8/NEWS	Tue May 20 00:41:22 2008
@@ -5,6 +5,7 @@
 	* Fix INDEX related crash. [#533247]
 	* Fix LINEST and LOGREG crashes.  [#533263]
 	* Handle empty array.  [#533516]
+	* Fix SUMPRODUCT criticals.  [#533507]
 
 Jon KÃre:
         * Receive clipboard from broken apps. [#524756]

Modified: branches/gnumeric-1-8/plugins/fn-math/functions.c
==============================================================================
--- branches/gnumeric-1-8/plugins/fn-math/functions.c	(original)
+++ branches/gnumeric-1-8/plugins/fn-math/functions.c	Tue May 20 00:41:22 2008
@@ -3218,6 +3218,11 @@
 					   GNM_EXPR_EVAL_PERMIT_NON_SCALAR |
 					   GNM_EXPR_EVAL_PERMIT_EMPTY);
 
+		if (!val) {
+			size_error = TRUE;
+			break;
+		}
+
 		thissizex = value_area_get_width (val, ei->pos);
 		thissizey = value_area_get_height (val, ei->pos);