gnumeric r16566 - in trunk: . plugins/fn-stat

[mortenw svn gnome org]

Author: mortenw
Date: Fri May 16 20:16:11 2008
New Revision: 16566
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16566&view=rev

Log:
2008-05-16  Jean Brefort  <jean brefort normalesup org>

	* functions.c (gnumeric_linest, gnumeric_logreg): Fix code to
	order range.  Fixes #533263.



Modified:
   trunk/NEWS
   trunk/plugins/fn-stat/ChangeLog
   trunk/plugins/fn-stat/functions.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Fri May 16 20:16:11 2008
@@ -1,5 +1,8 @@
 Gnumeric 1.9.1
 
+Jean:
+	* Fix LINEST and LOGREG crashes.  [#533263]
+
 Morten:
 	* Fix Excel export problem for strings that need quoting.  [#530704]
 	* Internal cleanup for analysis tools.  [#532210]

Modified: trunk/plugins/fn-stat/functions.c
==============================================================================
--- trunk/plugins/fn-stat/functions.c	(original)
+++ trunk/plugins/fn-stat/functions.c	Fri May 16 20:16:11 2008
@@ -4049,7 +4049,7 @@
 		GnmValue *copy = value_dup (argv[1]);
 		int firstrow = argv[1]->v_range.cell.a.row;
 		int lastrow  = argv[1]->v_range.cell.b.row;
-		if (firstrow < lastrow) {
+		if (firstrow > lastrow) {
 			int tmp = firstrow;
 			firstrow = lastrow;
 			lastrow = tmp;
@@ -4286,7 +4286,7 @@
 		int firstcol   = argv[1]->v_range.cell.a.col;
 		int lastcol    = argv[1]->v_range.cell.b.col;
 
-		if (firstcol < lastcol) {
+		if (firstcol > lastcol) {
 			int tmp = firstcol;
 			firstcol = lastcol;
 			lastcol = tmp;
@@ -4319,7 +4319,7 @@
 		int firstrow   = argv[1]->v_range.cell.a.row;
 		int lastrow    = argv[1]->v_range.cell.b.row;
 
-		if (firstrow < lastrow) {
+		if (firstrow > lastrow) {
 			int tmp = firstrow;
 			firstrow = lastrow;
 			lastrow = tmp;