gimp r25320 - in trunk: . app/widgets

[martinn svn gnome org]

Author: martinn
Date: Sun Mar 30 19:26:44 2008
New Revision: 25320
URL: http://svn.gnome.org/viewvc/gimp?rev=25320&view=rev

Log:
2008-03-30  Martin Nordholts  <martinn svn gnome org>

	* app/widgets/gimpcontainertreeview-dnd.c
	(gimp_container_tree_view_drag_drop): Make all code paths result
	in a call to gtk_drag_finish() if we return TRUE. Fixes bug
	#317992.


Modified:
   trunk/ChangeLog
   trunk/app/widgets/gimpcontainertreeview-dnd.c

Modified: trunk/app/widgets/gimpcontainertreeview-dnd.c
==============================================================================
--- trunk/app/widgets/gimpcontainertreeview-dnd.c	(original)
+++ trunk/app/widgets/gimpcontainertreeview-dnd.c	Sun Mar 30 19:26:44 2008
@@ -314,10 +314,21 @@
       tree_view_class = GIMP_CONTAINER_TREE_VIEW_GET_CLASS (tree_view);
 
       if (src_viewable)
-        tree_view_class->drop_viewable (tree_view, src_viewable,
-                                        dest_viewable, drop_pos);
+        {
+          gboolean success = TRUE;
+
+          /* XXX: Make GimpContainerTreeViewClass::drop_viewable()
+           * return success?
+           */
+          tree_view_class->drop_viewable (tree_view, src_viewable,
+                                          dest_viewable, drop_pos);
+
+          gtk_drag_finish (context, success, FALSE, time);
+        }
       else
-        gtk_drag_get_data (widget, context, target, time);
+        {
+          gtk_drag_get_data (widget, context, target, time);
+        }
 
       return TRUE;
     }