banshee r3598 - in trunk/banshee: . src/Libraries/Lastfm/Lastfm
- From: ahixon svn gnome org
- To: svn-commits-list gnome org
- Subject: banshee r3598 - in trunk/banshee: . src/Libraries/Lastfm/Lastfm
- Date: Sun, 30 Mar 2008 05:09:00 +0100 (BST)
Author: ahixon
Date: Sun Mar 30 05:09:00 2008
New Revision: 3598
URL: http://svn.gnome.org/viewvc/banshee?rev=3598&view=rev
Log:
2008-03-30 Alexander Hixon <hixon alexander mediati org>
* src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs: Changed a few
multiline comments to single line comments. Fixed some logging bits that
would accidentally be displayed to the user instead of silently being
sent to the console. Closes BGO #524954.
Modified:
trunk/banshee/ChangeLog
trunk/banshee/src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs
Modified: trunk/banshee/src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs
==============================================================================
--- trunk/banshee/src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs (original)
+++ trunk/banshee/src/Libraries/Lastfm/Lastfm/AudioscrobblerConnection.cs Sun Mar 30 05:09:00 2008
@@ -314,7 +314,7 @@
resp = current_web_req.EndGetResponse (ar);
}
catch (Exception e) {
- Hyena.Log.Warning (String.Format("Failed to get the response: {0}", e));
+ Hyena.Log.Warning (String.Format("Failed to get the response: {0}", e), false);
state = State.Idle;
next_interval = DateTime.Now + new TimeSpan (0, 0, RETRY_SECONDS);
@@ -337,7 +337,7 @@
last_upload_failed_logged = now;
}
- /* retransmit the queue on the next interval */
+ // retransmit the queue on the next interval
hard_failures++;
state = State.NeedTransmit;
}
@@ -347,7 +347,7 @@
last_upload_failed_logged = now;
}
- /* attempt to re-handshake (and retransmit) on the next interval */
+ // attempt to re-handshake (and retransmit) on the next interval
session_id = null;
next_interval = DateTime.Now + new TimeSpan (0, 0, RETRY_SECONDS);
state = State.NeedHandshake;
@@ -361,14 +361,14 @@
hard_failures = 0;
- /* we succeeded, pop the elements off our queue */
+ // we succeeded, pop the elements off our queue
queue.RemoveRange (0, ts.Count);
queue.Save ();
state = State.Idle;
} else {
if (now - last_upload_failed_logged > TimeSpan.FromMinutes(FAILURE_LOG_MINUTES)) {
- Hyena.Log.Warning ("Audioscrobbler upload failed", String.Format ("Unrecognized response: {0}", line));
+ Hyena.Log.Warning ("Audioscrobbler upload failed", String.Format ("Unrecognized response: {0}", line), false);
last_upload_failed_logged = now;
}
@@ -424,7 +424,7 @@
catch (Exception e) {
Hyena.Log.Warning ("Failed to handshake: {0}", e.ToString (), false);
- /* back off for a time before trying again */
+ // back off for a time before trying again
state = State.Idle;
next_interval = DateTime.Now + new TimeSpan (0, 0, RETRY_SECONDS);
return;
@@ -578,7 +578,7 @@
if (line.StartsWith ("BADSESSION")) {
Hyena.Log.Warning ("Audioscrobbler NowPlaying failed", "Session ID sent was invalid", false);
- /* attempt to re-handshake on the next interval */
+ // attempt to re-handshake on the next interval
session_id = null;
next_interval = DateTime.Now + new TimeSpan (0, 0, RETRY_SECONDS);
state = State.NeedHandshake;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]