ooo-build r11946 - in trunk: . patches/src680



Author: kyoshida
Date: Wed Mar 19 14:34:54 2008
New Revision: 11946
URL: http://svn.gnome.org/viewvc/ooo-build?rev=11946&view=rev

Log:
2008-03-19  Kohei Yoshida  <kyoshida novell com>

	* patches/src680/sc-fix-value-iterator.diff: avoid initializing the 
	value to 0 when iterating through values.  This causes certain iterative
	functions (such as MIN) to return wrong results (n#372255).

	* patches/src680/apply: apply the above patch.


Added:
   trunk/patches/src680/sc-fix-value-iterator.diff
Modified:
   trunk/ChangeLog
   trunk/patches/src680/apply

Modified: trunk/patches/src680/apply
==============================================================================
--- trunk/patches/src680/apply	(original)
+++ trunk/patches/src680/apply	Wed Mar 19 14:34:54 2008
@@ -703,6 +703,10 @@
 # contributed from Lv Yue) (ODFF).
 sc-openformula-minmax.diff, i#38759, kohei
 
+# don't initialize the value to 0 which screws up certain iterative functions
+# (such as MIN, MAX).
+sc-fix-value-iterator.diff, n#372255, kohei
+
 # Support print & page preview for files containing only lines
 sc-print-lines.diff, n#351468, i#85076, jonp
 

Added: trunk/patches/src680/sc-fix-value-iterator.diff
==============================================================================
--- (empty file)
+++ trunk/patches/src680/sc-fix-value-iterator.diff	Wed Mar 19 14:34:54 2008
@@ -0,0 +1,38 @@
+Index: sc/source/core/data/dociter.cxx
+===================================================================
+RCS file: /cvs/sc/sc/source/core/data/dociter.cxx,v
+retrieving revision 1.19
+retrieving revision 1.19.158.1
+diff -u -r1.19 -r1.19.158.1
+--- sc/source/core/data/dociter.cxx	27 Feb 2007 12:01:01 -0000	1.19
++++ sc/source/core/data/dociter.cxx	8 Jan 2008 22:19:49 -0000	1.19.158.1
+@@ -4,9 +4,9 @@
+  *
+  *  $RCSfile: dociter.cxx,v $
+  *
+- *  $Revision: 1.19 $
++ *  $Revision: 1.19.158.1 $
+  *
+- *  last change: $Author: vg $ $Date: 2007/02/27 12:01:01 $
++ *  last change: $Author: er $ $Date: 2008/01/08 22:19:49 $
+  *
+  *  The Contents of this file are made available subject to
+  *  the terms of GNU Lesser General Public License Version 2.1.
+@@ -323,7 +323,7 @@
+ 					nTab++;
+ 					if ( nTab > nEndTab )
+ 					{
+-						rValue = 0.0;
++						// rValue = 0.0;    //! do not change caller's value!
+ 						rErr = 0;
+ 						return FALSE;				// Ende und Aus
+ 					}
+@@ -524,7 +524,7 @@
+ 				nCol++;
+ 				if ( nCol > aParam.nCol2 )
+ 				{
+-					rValue = 0.0;
++					// rValue = 0.0;    // do not change caller's value!
+ 					rErr = 0;
+ 					return FALSE;				// Ende und Aus
+ 				}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]