libgda r3086 - in branches/release-3-0-branch: . libgda



Author: murrayc
Date: Tue Mar 18 12:29:10 2008
New Revision: 3086
URL: http://svn.gnome.org/viewvc/libgda?rev=3086&view=rev

Log:
2008-03-18  Murray Cumming:  <murrayc murrayc com>

* libgda/gda-config.c: (gda_config_get_provider_by_name): 
Revert the previous change because it leaked the info and freed the 
list though it did not have ownership, causing a crash.

Modified:
   branches/release-3-0-branch/ChangeLog
   branches/release-3-0-branch/libgda/gda-config.c

Modified: branches/release-3-0-branch/libgda/gda-config.c
==============================================================================
--- branches/release-3-0-branch/libgda/gda-config.c	(original)
+++ branches/release-3-0-branch/libgda/gda-config.c	Tue Mar 18 12:29:10 2008
@@ -1616,8 +1616,6 @@
 	GList *l;
 	const gchar *tmpname;
 
-	GdaProviderInfo * info = NULL;
-
 	if (name)
 		tmpname = name;
 	else
@@ -1629,14 +1627,10 @@
 		GdaProviderInfo *provider_info = (GdaProviderInfo *) l->data;
 
 		if (provider_info && !strcmp (provider_info->id, tmpname))
-		{
-			info = gda_provider_info_copy(provider_info);
-		}
+			return provider_info;
 	}
 
-	gda_config_free_provider_list(prov_list);
-
-	return info;
+	return NULL;
 }
 
 /**



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]