banshee r3452 - in trunk/banshee: . src/Core/Banshee.ThickClient/Banshee.SmartPlaylist.Gui

[gburt svn gnome org]

Author: gburt
Date: Thu Mar 13 22:41:10 2008
New Revision: 3452
URL: http://svn.gnome.org/viewvc/banshee?rev=3452&view=rev

Log:
2008-03-13  Gabriel Burt  <gabriel burt gmail com>

	* src/Core/Banshee.ThickClient/Banshee.SmartPlaylist.Gui/Editor.cs:
	Disable one broken pre-defined smart playlist, and ensure the others are
	refreshed/reloaded when 'selected for use'.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Core/Banshee.ThickClient/Banshee.SmartPlaylist.Gui/Editor.cs

Modified: trunk/banshee/src/Core/Banshee.ThickClient/Banshee.SmartPlaylist.Gui/Editor.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.ThickClient/Banshee.SmartPlaylist.Gui/Editor.cs	(original)
+++ trunk/banshee/src/Core/Banshee.ThickClient/Banshee.SmartPlaylist.Gui/Editor.cs	Thu Mar 13 22:41:10 2008
@@ -77,10 +77,11 @@
             // Model is Name, Condition, OrderBy, LimitNumber, LimitCriterion
             ListStore list_model = new ListStore (typeof(string), typeof(string), typeof(string), typeof(string), typeof(string));
 
-            list_model.AppendValues (
+            // FIXME this is broken
+            /*list_model.AppendValues (
                 Catalog.GetString ("Neglected Favorites"),
-                " (Rating > 3) AND ((strftime(\"%s\", current_timestamp) - LastPlayedStamp + 3600) > 2592000) ",
-                null, "0", null);
+                "Rating>3 played<=\"2 weeks ago\"",
+                null, "0", null);*/
 
             // TODO this one is broken, not supported by the condition GUI
             /*list_model.AppendValues (
@@ -233,10 +234,8 @@
                         playlist.LimitValue = limit_value;
 
                         playlist.Save ();
-                        playlist.Refresh ();
-                        ThreadAssist.ProxyToMain (delegate {
-                            ServiceManager.SourceManager.DefaultSource.AddChildSource (playlist);
-                        });
+                        ServiceManager.SourceManager.DefaultSource.AddChildSource (playlist);
+                        playlist.RefreshAndReload ();
                         //SmartPlaylistCore.Instance.StartTimer (playlist);
                     } else {
                         playlist.ConditionTree = condition_tree;
@@ -294,6 +293,7 @@
                     pl.Save ();
                     //Banshee.Sources.LibrarySource.Instance.AddChildSource (pl);
                     ServiceManager.SourceManager.DefaultSource.AddChildSource (pl);
+                    pl.RefreshAndReload ();
                     //SmartPlaylistCore.Instance.StartTimer (pl);
                 }
             }