empathy r774 - trunk/libempathy



Author: xclaesse
Date: Tue Mar 11 12:23:10 2008
New Revision: 774
URL: http://svn.gnome.org/viewvc/empathy?rev=774&view=rev

Log:
Check if property is writable before setting it. Fix leaks


Modified:
   trunk/libempathy/empathy-tp-chat.c

Modified: trunk/libempathy/empathy-tp-chat.c
==============================================================================
--- trunk/libempathy/empathy-tp-chat.c	(original)
+++ trunk/libempathy/empathy-tp-chat.c	Tue Mar 11 12:23:10 2008
@@ -512,6 +512,10 @@
 			GValue       id = {0, };
 			GValue       dest_value = {0, };
 
+			if (!(property->flags & TP_PROPERTY_FLAG_WRITE)) {
+				break;
+			}
+
 			g_value_init (&id, G_TYPE_UINT);
 			g_value_init (&dest_value, G_TYPE_VALUE);
 			g_value_set_uint (&id, property->id);
@@ -532,6 +536,9 @@
 									 "Seting property", NULL,
 									 G_OBJECT (chat));
 
+			g_ptr_array_free (properties, TRUE);
+			g_value_array_free (prop);
+
 			break;
 		}
 	}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]