gvfs r1550 - in trunk: . common

[alexl svn gnome org]

Author: alexl
Date: Wed Mar  5 12:37:34 2008
New Revision: 1550
URL: http://svn.gnome.org/viewvc/gvfs?rev=1550&view=rev

Log:
2008-03-05  Alexander Larsson  <alexl redhat com>

        * common/gmountsource.c:
        (ask_password_reply):
	Always set password to non-NULL, but keep
	user/domain as NULL if not specified by user.
	Fixes #520317 (smb auth crash)



Modified:
   trunk/ChangeLog
   trunk/common/gmountsource.c

Modified: trunk/common/gmountsource.c
==============================================================================
--- trunk/common/gmountsource.c	(original)
+++ trunk/common/gmountsource.c	Wed Mar  5 12:37:34 2008
@@ -221,7 +221,7 @@
 
 	  if (!anonymous)
 	    {
-	      data->password = *password == 0 ? NULL : g_strdup (password);
+	      data->password = g_strdup (password);
 	      data->username = *username == 0 ? NULL : g_strdup (username);
 	      data->domain = *domain == 0 ? NULL : g_strdup (domain);
 	    }
@@ -311,8 +311,9 @@
  *
  * Requests the reply parameters from a g_mount_source_ask_password_async() 
  * request. All out parameters can be set to %NULL to ignore them.
- * <note><para>Please be aware that all string parameters can be set to %NULL,
- * so make sure to check them.</para></note>
+ * <note><para>Please be aware that out parameters other than the password
+ * are set to %NULL if the user don't specify them so make sure to
+ * check them.</para></note>
  *
  * Returns: %FALSE if the async reply contained an error.
  **/