gnumeric r16658 - in trunk: . plugins/fn-stat

[mortenw svn gnome org]

Author: mortenw
Date: Mon Jun 23 23:33:55 2008
New Revision: 16658
URL: http://svn.gnome.org/viewvc/gnumeric?rev=16658&view=rev

Log:
2008-06-23  Morten Welinder  <terra gnome org>

	* functions.c (gnumeric_growth): Plug leaks.  Fixes #539827.



Modified:
   trunk/NEWS
   trunk/plugins/fn-stat/ChangeLog
   trunk/plugins/fn-stat/functions.c

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Mon Jun 23 23:33:55 2008
@@ -48,6 +48,7 @@
 	* Fix SLOPE/INTERCEPT critical.  [#539648]
 	* Fix PERCENTRANK.  [#539672]
 	* Fix UMR in WORKDAY.  [#539808]
+	* Plug leaks in GROWTH.  [#539827]
 
 SeÃn de BÃrca:
 	* Move to tango based icons. [#450444]

Modified: trunk/plugins/fn-stat/functions.c
==============================================================================
--- trunk/plugins/fn-stat/functions.c	(original)
+++ trunk/plugins/fn-stat/functions.c	Mon Jun 23 23:33:55 2008
@@ -4966,11 +4966,16 @@
 					   COLLECT_IGNORE_STRINGS |
 					   COLLECT_IGNORE_BOOLS,
 					   &nx, &result);
+		if (result)
+			goto out;
 
 		nxs = collect_floats_value (argv[2], ei->pos,
 					    COLLECT_IGNORE_STRINGS |
 					    COLLECT_IGNORE_BOOLS,
 					    &nnx, &result);
+		if (result)
+			goto out;
+
 		if (argv[3] != NULL) {
 			affine = value_get_as_bool (argv[3], &err);
 			if (err) {
@@ -4985,10 +4990,15 @@
 						   COLLECT_IGNORE_STRINGS |
 						   COLLECT_IGNORE_BOOLS,
 						   &nx, &result);
+			if (result)
+				goto out;
+
 			nxs = collect_floats_value (argv[1], ei->pos,
 						    COLLECT_IGNORE_STRINGS |
 						    COLLECT_IGNORE_BOOLS,
 						    &nnx, &result);
+			if (result)
+				goto out;
 		} else {
 			xs = g_new (gnm_float, ny);
 			for (nx = 0; nx < ny; nx++)
@@ -4999,9 +5009,6 @@
 		}
 	}
 
-	if (result)
-		goto out;
-
 	if (nx != ny) {
 		result = value_new_error_NUM (ei->pos);
 		goto out;