evolution-exchange r1679 - in trunk: . mail

[abharath svn gnome org]

Author: abharath
Date: Sat Jun  7 14:06:00 2008
New Revision: 1679
URL: http://svn.gnome.org/viewvc/evolution-exchange?rev=1679&view=rev

Log:
Committing on behalf of  Paul Smith  <psmith gnu org>

2008-06-07  Paul Smith  <psmith gnu org>

        ** Fix for bug #532844

        * mail/mail-stub-exchange.c (get_message): If it's a bad case we
        can just goto the error handling code instead of trying to process
        the response.


Modified:
   trunk/ChangeLog
   trunk/mail/mail-stub-exchange.c

Modified: trunk/mail/mail-stub-exchange.c
==============================================================================
--- trunk/mail/mail-stub-exchange.c	(original)
+++ trunk/mail/mail-stub-exchange.c	Sat Jun  7 14:06:00 2008
@@ -2438,18 +2438,20 @@
 	if (mfld->type == MAIL_STUB_EXCHANGE_FOLDER_NOTES) {
 		status = get_stickynote (mse->ctx, NULL, mmsg->href,
 					 &body, &len);
+		if (!E2K_HTTP_STATUS_IS_SUCCESSFUL (status))
+			goto error;
 		content_type = g_strdup ("message/rfc822");
 	} else {
 		SoupBuffer *response;
 
 		status = e2k_context_get (mse->ctx, NULL, mmsg->href,
 					  &content_type, &response);
+		if (!E2K_HTTP_STATUS_IS_SUCCESSFUL (status))
+			goto error;
 		len = response->length;
 		body = g_strndup (response->data, response->length);
 		soup_buffer_free (response);
 	}
-	if (!E2K_HTTP_STATUS_IS_SUCCESSFUL (status))
-		goto error;
 
 	/* Public folders especially can contain non-email objects.
 	 * In that case, we fake the headers (which in this case