bug-buddy r2576 - in trunk: . src

[cosimoc svn gnome org]

Author: cosimoc
Date: Thu Jul 31 12:50:25 2008
New Revision: 2576
URL: http://svn.gnome.org/viewvc/bug-buddy?rev=2576&view=rev

Log:
2008-07-31  Cosimo Cecchi  <cosimoc gnome org>

	* src/bug-buddy.c: (main):
	Fix a incorrect check which would lead to a leak or to undefined
	behaviour
	Thanks to Christian Persch (#508631).


Modified:
   trunk/ChangeLog
   trunk/src/bug-buddy.c

Modified: trunk/src/bug-buddy.c
==============================================================================
--- trunk/src/bug-buddy.c	(original)
+++ trunk/src/bug-buddy.c	Thu Jul 31 12:50:25 2008
@@ -1693,14 +1693,18 @@
 		gtk_builder_set_translation_domain (ui, GETTEXT_PACKAGE);
 	}
 
-	if (!ui) {
-		buddy_error (NULL, 
+	g_free (s);
+
+	if (!ui || err) {
+		buddy_error (NULL,
 			     _("Bug Buddy could not load its user interface file.\n"
 			       "Please make sure Bug Buddy was installed correctly."));
+		if (err) {
+			g_error_free (err);
+		}
 		g_object_unref (program);
 		return 0;
 	}
-	g_free (s);	
 
 	main_window = GTK_WIDGET (gtk_builder_get_object (ui, "main-window"));
 	g_signal_connect (main_window, "delete-event", G_CALLBACK (delete_callback), ui);