evolution r35849 - trunk/filter
- From: mcrha svn gnome org
- To: svn-commits-list gnome org
- Subject: evolution r35849 - trunk/filter
- Date: Mon, 28 Jul 2008 07:25:28 +0000 (UTC)
Author: mcrha
Date: Mon Jul 28 07:25:28 2008
New Revision: 35849
URL: http://svn.gnome.org/viewvc/evolution?rev=35849&view=rev
Log:
2008-07-28 Milan Crha <mcrha redhat com>
** Fix for bug #530388
* filter-label.c: (filter_label_init), (filter_label_finalise),
(fill_options), (filter_label_count), (filter_label_label),
(filter_label_index): Make 'cache_lock' a rec mutex.
* filter-label.c: (regen_label_options): Guard also regeneration
of each tracked item with the rec lock, thus noone will touch
'tracked_filters' GSList until we are fully done with it.
Modified:
trunk/filter/ChangeLog
trunk/filter/filter-label.c
Modified: trunk/filter/filter-label.c
==============================================================================
--- trunk/filter/filter-label.c (original)
+++ trunk/filter/filter-label.c Mon Jul 28 07:25:28 2008
@@ -74,7 +74,7 @@
return type;
}
-static GStaticMutex cache_lock = G_STATIC_MUTEX_INIT;
+static GStaticRecMutex cache_lock = G_STATIC_REC_MUTEX_INIT;
static guint cache_notifier_id = 0;
static GSList *tracked_filters = NULL;
static GSList *labels_cache = NULL;
@@ -103,7 +103,7 @@
{
((FilterOption *) fl)->type = "label";
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
if (!tracked_filters) {
fill_cache ();
@@ -115,7 +115,7 @@
tracked_filters = g_slist_prepend (tracked_filters, fl);
- g_static_mutex_unlock (&cache_lock);
+ g_static_rec_mutex_unlock (&cache_lock);
}
static void
@@ -123,7 +123,7 @@
{
G_OBJECT_CLASS (parent_class)->finalize (obj);
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
tracked_filters = g_slist_remove (tracked_filters, obj);
@@ -138,7 +138,7 @@
gconf_client = NULL;
}
- g_static_mutex_unlock (&cache_lock);
+ g_static_rec_mutex_unlock (&cache_lock);
}
/**
@@ -176,7 +176,7 @@
{
GSList *l;
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
for (l = labels_cache; l; l = l->next) {
EUtilLabel *label = l->data;
@@ -197,7 +197,7 @@
g_free (title);
}
- g_static_mutex_unlock (&cache_lock);
+ g_static_rec_mutex_unlock (&cache_lock);
}
static void
@@ -222,12 +222,13 @@
static void
gconf_labels_changed (GConfClient *client, guint cnxn_id, GConfEntry *entry, gpointer user_data)
{
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
+
clear_cache ();
fill_cache ();
- g_static_mutex_unlock (&cache_lock);
-
g_slist_foreach (tracked_filters, (GFunc)regen_label_options, NULL);
+
+ g_static_rec_mutex_unlock (&cache_lock);
}
/* ************************************************************************* */
@@ -237,11 +238,11 @@
{
int res;
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
res = g_slist_length (labels_cache);
- g_static_mutex_unlock (&cache_lock);
+ g_static_rec_mutex_unlock (&cache_lock);
return res;
}
@@ -253,7 +254,7 @@
GSList *l;
EUtilLabel *label;
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
l = g_slist_nth (labels_cache, i);
@@ -269,7 +270,7 @@
res = label->tag;
}
- g_static_mutex_unlock (&cache_lock);
+ g_static_rec_mutex_unlock (&cache_lock);
return res;
}
@@ -280,7 +281,7 @@
int i;
GSList *l;
- g_static_mutex_lock (&cache_lock);
+ g_static_rec_mutex_lock (&cache_lock);
for (i = 0, l = labels_cache; l; i++, l = l->next) {
EUtilLabel *lbl = l->data;
@@ -293,7 +294,7 @@
break;
}
- g_static_mutex_unlock (&cache_lock);
+ g_static_rec_mutex_unlock (&cache_lock);
if (l)
return i;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]