gimp r26278 - in trunk: . plug-ins/help-browser

[neo svn gnome org]

Author: neo
Date: Tue Jul 22 14:53:14 2008
New Revision: 26278
URL: http://svn.gnome.org/viewvc/gimp?rev=26278&view=rev

Log:
2008-07-22  Sven Neumann  <sven gimp org>

	* plug-ins/help-browser/dialog.c (build_menu): check the return
	value of webkit_web_history_item_get_title() to guard us against
	a (reported) bug in WebKit.



Modified:
   trunk/ChangeLog
   trunk/plug-ins/help-browser/dialog.c

Modified: trunk/plug-ins/help-browser/dialog.c
==============================================================================
--- trunk/plug-ins/help-browser/dialog.c	(original)
+++ trunk/plug-ins/help-browser/dialog.c	Tue Jul 22 14:53:14 2008
@@ -876,20 +876,23 @@
   for (list = items; list; list = g_list_next (list))
     {
       WebKitWebHistoryItem *item = list->data;
-      GtkWidget            *menu_item;
       const gchar          *title;
 
       title = webkit_web_history_item_get_title (item);
-      menu_item = gtk_menu_item_new_with_label (title);
 
-      gtk_menu_shell_append (GTK_MENU_SHELL (menu), menu_item);
-      gtk_widget_show (menu_item);
+      if (title)
+        {
+          GtkWidget *menu_item = gtk_menu_item_new_with_label (title);
+
+          gtk_menu_shell_append (GTK_MENU_SHELL (menu), menu_item);
+          gtk_widget_show (menu_item);
+
+          g_signal_connect_object (menu_item, "activate",
+                                   G_CALLBACK (menu_callback),
+                                   item, 0);
 
-      g_signal_connect_object (menu_item, "activate",
-                               G_CALLBACK (menu_callback),
-                               item, 0);
-
-      g_object_unref (item);
+          g_object_unref (item);
+        }
     }
 
   g_list_free (items);