banshee r4236 - in trunk/banshee: . src/Libraries/Lastfm/Lastfm.Data

[ahixon svn gnome org]

Author: ahixon
Date: Mon Jul 21 07:02:40 2008
New Revision: 4236
URL: http://svn.gnome.org/viewvc/banshee?rev=4236&view=rev

Log:
2008-07-21  Alexander Hixon  <ahixon gnome org>

	* src/Libraries/Lastfm/Lastfm.Data/DataCore.cs: Make sure that we check
	the hash string length before performing a substring operation to avoid
	out-of-range exceptions.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Libraries/Lastfm/Lastfm.Data/DataCore.cs

Modified: trunk/banshee/src/Libraries/Lastfm/Lastfm.Data/DataCore.cs
==============================================================================
--- trunk/banshee/src/Libraries/Lastfm/Lastfm.Data/DataCore.cs	(original)
+++ trunk/banshee/src/Libraries/Lastfm/Lastfm.Data/DataCore.cs	Mon Jul 21 07:02:40 2008
@@ -118,7 +118,11 @@
         public static string GetCachedPathFromUrl (string url)
         {
             string hash = FixLastfmUrl (url).GetHashCode ().ToString ("X").ToLower ();
-            return Path.Combine (Path.Combine (DataCore.CachePath, hash.Substring (0, 2)), hash);
+            if (hash.Length > 2) {
+                return Path.Combine (Path.Combine (DataCore.CachePath, hash.Substring (0, 2)), hash);
+            } else {
+                return String.Empty;
+            }
         }
         
         private static Stream GetResponseStream (HttpWebResponse response)