gnome-subtitles r1029 - trunk/src/GnomeSubtitles/Dialog

[pcastro svn gnome org]

Author: pcastro
Date: Sun Jul 13 17:41:44 2008
New Revision: 1029
URL: http://svn.gnome.org/viewvc/gnome-subtitles?rev=1029&view=rev

Log:
Do not set arguments as null.

Modified:
   trunk/src/GnomeSubtitles/Dialog/MessageDialog.cs

Modified: trunk/src/GnomeSubtitles/Dialog/MessageDialog.cs
==============================================================================
--- trunk/src/GnomeSubtitles/Dialog/MessageDialog.cs	(original)
+++ trunk/src/GnomeSubtitles/Dialog/MessageDialog.cs	Sun Jul 13 17:41:44 2008
@@ -26,27 +26,22 @@
 	public abstract class MessageDialog : BaseDialog {
 		protected new Gtk.MessageDialog dialog = null;
 
-		public MessageDialog (MessageType messageType) : this(messageType, null, null, null) {
+		public MessageDialog (MessageType messageType) : base() {
+			Init(messageType, null, null);
 		}
 
-		public MessageDialog (MessageType messageType, string primaryText, params object[]primaryTextArgs) : this(messageType, primaryText, null, primaryTextArgs) {
+		public MessageDialog (MessageType messageType, string primaryText, params object[]primaryTextArgs) : base() {
+			Init(messageType, primaryText, null, primaryTextArgs) ;
 		}
 
-		public MessageDialog (MessageType messageType, string primaryText, string secondaryText) : this(messageType, primaryText, secondaryText, null) {
+		public MessageDialog (MessageType messageType, string primaryText, string secondaryText) : base() {
+			Init(messageType, primaryText, secondaryText);
 		}
 		
 		public MessageDialog (MessageType messageType, string primaryText, string secondaryText, params object[]primaryTextArgs) : base() {
-			dialog = new Gtk.MessageDialog(Base.Ui.Window, DialogFlags.Modal, messageType, ButtonsType.None, primaryText, primaryTextArgs);
-			base.dialog = dialog;
-			
-			dialog.Response += OnResponse;
-
-			SetSecondaryText(secondaryText);
-
-			Util.SetBaseWindowToUi(dialog);
-			AddButtons();
+			Init(messageType, primaryText, secondaryText, primaryTextArgs);
 		}
-		
+
 		
 		#region Protected methods
 	
@@ -80,6 +75,21 @@
 
 		#endregion
 		
+		#region Private members
+		
+		private void Init (MessageType messageType, string primaryText, string secondaryText, params object[]primaryTextArgs) {
+			dialog = new Gtk.MessageDialog(Base.Ui.Window, DialogFlags.Modal, messageType, ButtonsType.None, primaryText, primaryTextArgs);
+			base.dialog = dialog;
+			
+			dialog.Response += OnResponse;
+
+			SetSecondaryText(secondaryText);
+
+			Util.SetBaseWindowToUi(dialog);
+			AddButtons();
+		}
+		
+		#endregion
 		
 		#region Abstract methods