gdm r6297 - in trunk: . common daemon gui/simple-chooser gui/simple-greeter

[mccann svn gnome org]

Author: mccann
Date: Sat Jul 12 17:09:25 2008
New Revision: 6297
URL: http://svn.gnome.org/viewvc/gdm?rev=6297&view=rev

Log:
2008-07-12  William Jon McCann  <jmccann redhat com>

	* common/gdm-common.c (_read_bytes):
	* daemon/gdm-display-access-file.c (_create_xauth_file_for_user):
	* daemon/gdm-welcome-session.c (parse_dbus_launch_output):
	* gui/simple-chooser/gdm-chooser-client.c
	(gdm_chooser_client_start):
	* gui/simple-greeter/gdm-greeter-client.c
	(gdm_greeter_client_start):
	* gui/simple-greeter/gdm-languages.c (gdm_parse_language_name):
	* gui/simple-greeter/gdm-layout-chooser-widget.c:
	* gui/simple-greeter/gdm-user-manager.c (parse_ck_history_line):
	Fix some build warnings GCC 4.3.0
	Patch from Cosimo Cecchi <cosimoc gnome org>



Modified:
   trunk/ChangeLog
   trunk/common/gdm-common.c
   trunk/daemon/gdm-display-access-file.c
   trunk/daemon/gdm-welcome-session.c
   trunk/gui/simple-chooser/gdm-chooser-client.c
   trunk/gui/simple-greeter/gdm-greeter-client.c
   trunk/gui/simple-greeter/gdm-languages.c
   trunk/gui/simple-greeter/gdm-layout-chooser-widget.c
   trunk/gui/simple-greeter/gdm-user-manager.c

Modified: trunk/common/gdm-common.c
==============================================================================
--- trunk/common/gdm-common.c	(original)
+++ trunk/common/gdm-common.c	Sat Jul 12 17:09:25 2008
@@ -373,14 +373,14 @@
                 g_set_error (error,
                              G_FILE_ERROR,
                              g_file_error_from_errno (ENODATA),
-                             g_strerror (ENODATA));
+                             "%s", g_strerror (ENODATA));
 
                 return FALSE;
         } else if (bytes_left_to_read > 0) {
                 g_set_error (error,
                              G_FILE_ERROR,
                              g_file_error_from_errno (errno),
-                             g_strerror (errno));
+                             "%s", g_strerror (errno));
                 return FALSE;
         }
 

Modified: trunk/daemon/gdm-display-access-file.c
==============================================================================
--- trunk/daemon/gdm-display-access-file.c	(original)
+++ trunk/daemon/gdm-display-access-file.c	Sat Jul 12 17:09:25 2008
@@ -235,7 +235,7 @@
                                      G_FILE_ERROR,
                                      g_file_error_from_errno (errno),
                                      "%s", g_strerror (errno));
-                        fp = -1;
+                        fd = -1;
                         goto out;
                 }
 

Modified: trunk/daemon/gdm-welcome-session.c
==============================================================================
--- trunk/daemon/gdm-welcome-session.c	(original)
+++ trunk/daemon/gdm-welcome-session.c	Sat Jul 12 17:09:25 2008
@@ -610,7 +610,7 @@
         error = NULL;
         re = g_regex_new ("DBUS_SESSION_BUS_ADDRESS=(.+)\nDBUS_SESSION_BUS_PID=([0-9]+)", 0, 0, &error);
         if (re == NULL) {
-                g_critical (error->message);
+                g_critical ("%s", error->message);
         }
 
         g_regex_match (re, output, 0, &match_info);

Modified: trunk/gui/simple-chooser/gdm-chooser-client.c
==============================================================================
--- trunk/gui/simple-chooser/gdm-chooser-client.c	(original)
+++ trunk/gui/simple-chooser/gdm-chooser-client.c	Sat Jul 12 17:09:25 2008
@@ -271,7 +271,7 @@
                         g_set_error (error,
                                      GDM_CHOOSER_CLIENT_ERROR,
                                      GDM_CHOOSER_CLIENT_ERROR_GENERIC,
-                                     local_error.message);
+                                     "%s", local_error.message);
                         dbus_error_free (&local_error);
                 } else {
                         g_warning ("Unable to open connection");

Modified: trunk/gui/simple-greeter/gdm-greeter-client.c
==============================================================================
--- trunk/gui/simple-greeter/gdm-greeter-client.c	(original)
+++ trunk/gui/simple-greeter/gdm-greeter-client.c	Sat Jul 12 17:09:25 2008
@@ -730,7 +730,7 @@
                         g_set_error (error,
                                      GDM_GREETER_CLIENT_ERROR,
                                      GDM_GREETER_CLIENT_ERROR_GENERIC,
-                                     local_error.message);
+                                     "%s", local_error.message);
                         dbus_error_free (&local_error);
                 } else {
                         g_warning ("Unable to open connection");

Modified: trunk/gui/simple-greeter/gdm-languages.c
==============================================================================
--- trunk/gui/simple-greeter/gdm-languages.c	(original)
+++ trunk/gui/simple-greeter/gdm-languages.c	Sat Jul 12 17:09:25 2008
@@ -127,7 +127,7 @@
                           "(@(?P<modifier>[[:ascii:]]+))?$",
                           0, 0, &error);
         if (re == NULL) {
-                g_critical (error->message);
+                g_critical ("%s", error->message);
                 return;
         }
 

Modified: trunk/gui/simple-greeter/gdm-layout-chooser-widget.c
==============================================================================
--- trunk/gui/simple-greeter/gdm-layout-chooser-widget.c	(original)
+++ trunk/gui/simple-greeter/gdm-layout-chooser-widget.c	Sat Jul 12 17:09:25 2008
@@ -114,7 +114,7 @@
         }
 }
 
-void
+static void
 add_available_layouts (GdmLayoutChooserWidget *widget)
 {
         char **layout_names;

Modified: trunk/gui/simple-greeter/gdm-user-manager.c
==============================================================================
--- trunk/gui/simple-greeter/gdm-user-manager.c	(original)
+++ trunk/gui/simple-greeter/gdm-user-manager.c	Sat Jul 12 17:09:25 2008
@@ -1084,7 +1084,7 @@
         error = NULL;
         re = g_regex_new ("(?P<username>[0-9a-zA-Z]+)[ ]+(?P<frequency>[0-9]+)", 0, 0, &error);
         if (re == NULL) {
-                g_critical (error->message);
+                g_critical ("%s", error->message);
                 goto out;
         }