network-manager-applet r774 - in trunk: . src src/connection-editor src/gconf-helpers

[tambeti svn gnome org]

Author: tambeti
Date: Wed Jul  2 08:56:14 2008
New Revision: 774
URL: http://svn.gnome.org/viewvc/network-manager-applet?rev=774&view=rev

Log:
2008-07-02  Tambet Ingo  <tambet gmail com>

	Patch from Andrà Lemos <alemos criticalsoftware com>

	* src/gconf-helpers/nma-gconf-settings.c
	(nma_gconf_settings_add_connection):
	* src/connection-editor/nm-connection-list.c (show_error_dialog):
	* src/applet.c (applet_settings_new_secrets_requested_cb):
	* src/applet-device-wired.c (get_pppoe_secrets_cb)
	(get_8021x_secrets_cb):
	* src/applet-device-wifi.c (get_secrets_dialog_response_cb):
	* src/applet-device-gsm.c (get_gsm_secrets_cb): Always send a format
	string to vararg message functions.


Modified:
   trunk/ChangeLog
   trunk/src/applet-device-gsm.c
   trunk/src/applet-device-wifi.c
   trunk/src/applet-device-wired.c
   trunk/src/applet.c
   trunk/src/connection-editor/nm-connection-list.c
   trunk/src/gconf-helpers/nma-gconf-settings.c

Modified: trunk/src/applet-device-gsm.c
==============================================================================
--- trunk/src/applet-device-gsm.c	(original)
+++ trunk/src/applet-device-gsm.c	Wed Jul  2 08:56:14 2008
@@ -407,7 +407,7 @@
 
  done:
 	if (err) {
-		g_warning (err->message);
+		g_warning ("%s", err->message);
 		dbus_g_method_return_error (info->context, err);
 		g_error_free (err);
 	}

Modified: trunk/src/applet-device-wifi.c
==============================================================================
--- trunk/src/applet-device-wifi.c	(original)
+++ trunk/src/applet-device-wifi.c	Wed Jul  2 08:56:14 2008
@@ -1529,7 +1529,7 @@
 		g_hash_table_destroy (settings);
 
 	if (error) {
-		g_warning (error->message);
+		g_warning ("%s", error->message);
 		dbus_g_method_return_error (context, error);
 		g_error_free (error);
 	}

Modified: trunk/src/applet-device-wired.c
==============================================================================
--- trunk/src/applet-device-wired.c	(original)
+++ trunk/src/applet-device-wired.c	Wed Jul  2 08:56:14 2008
@@ -426,7 +426,7 @@
 
 done:
 	if (err) {
-		g_warning (err->message);
+		g_warning ("%s", err->message);
 		dbus_g_method_return_error (info->context, err);
 		g_error_free (err);
 	}
@@ -568,7 +568,7 @@
 
 done:
 	if (err) {
-		g_warning (err->message);
+		g_warning ("%s", err->message);
 
 		if (context)
 			dbus_g_method_return_error (context, err);

Modified: trunk/src/applet.c
==============================================================================
--- trunk/src/applet.c	(original)
+++ trunk/src/applet.c	Wed Jul  2 08:56:14 2008
@@ -1885,7 +1885,7 @@
 	return;
 
 error:
-	g_warning (error->message);
+	g_warning ("%s", error->message);
 	dbus_g_method_return_error (context, error);
 	g_error_free (error);
 }

Modified: trunk/src/connection-editor/nm-connection-list.c
==============================================================================
--- trunk/src/connection-editor/nm-connection-list.c	(original)
+++ trunk/src/connection-editor/nm-connection-list.c	Wed Jul  2 08:56:14 2008
@@ -99,7 +99,7 @@
 							   GTK_DIALOG_DESTROY_WITH_PARENT,
 							   GTK_MESSAGE_ERROR,
 							   GTK_BUTTONS_CLOSE,
-							   msg);
+							   "%s", msg);
 	g_free (msg);
 
 	gtk_dialog_run (GTK_DIALOG (dialog));

Modified: trunk/src/gconf-helpers/nma-gconf-settings.c
==============================================================================
--- trunk/src/gconf-helpers/nma-gconf-settings.c	(original)
+++ trunk/src/gconf-helpers/nma-gconf-settings.c	Wed Jul  2 08:56:14 2008
@@ -94,7 +94,7 @@
 
 		snprintf (&buf[0], 255, GCONF_PATH_CONNECTIONS"/%d", i);
 		if (!gconf_client_dir_exists (priv->client, buf, NULL)) {
-			path = g_strdup_printf (buf);
+			path = g_strdup (buf);
 			break;
 		}
 	}