gegl r1905 - in trunk: . bin gegl operations/blur operations/color operations/workshop



Author: kcozens
Date: Wed Jan 23 23:39:09 2008
New Revision: 1905
URL: http://svn.gnome.org/viewvc/gegl?rev=1905&view=rev

Log:
	* bin/gegl-node-editor.c (type_editor_generic): Use the "changed"
	signal instead of "activate". Makes GEGL GUI more responsive to
	changes in property values.

	* gegl/gegl-chant.h: Deleted GEGL_CHANT_O #define in favour of
	GEGL_CHANT_PROPERTIES to avoid hiding what is being accessed.

	* operations/blur/box-blur.c:
	* operations/blur/gaussian-blur.c:
	* operations/color/mono-mixer.c:
	* operations/workshop/box-max.c:
	* operations/workshop/box-min.c: Updated due to change in gegl-chant.h


Modified:
   trunk/ChangeLog
   trunk/bin/gegl-node-editor.c
   trunk/gegl/gegl-chant.h
   trunk/operations/blur/box-blur.c
   trunk/operations/blur/gaussian-blur.c
   trunk/operations/color/mono-mixer.c
   trunk/operations/workshop/box-max.c
   trunk/operations/workshop/box-min.c

Modified: trunk/bin/gegl-node-editor.c
==============================================================================
--- trunk/bin/gegl-node-editor.c	(original)
+++ trunk/bin/gegl-node-editor.c	Wed Jan 23 23:39:09 2008
@@ -725,9 +725,10 @@
 
   g_object_set_data (G_OBJECT (entry), "node", node);
 
-  g_signal_connect (G_OBJECT (entry), "activate",
-                    G_CALLBACK (type_editor_generic_changed),
-                    (gpointer) param_spec);
+  if (param_spec->value_type != G_TYPE_BOOLEAN)
+    g_signal_connect (G_OBJECT (entry), "changed",
+                      G_CALLBACK (type_editor_generic_changed),
+                      (gpointer) param_spec);
 
   if (param_spec->value_type == G_TYPE_BOOLEAN)
     {

Modified: trunk/gegl/gegl-chant.h
==============================================================================
--- trunk/gegl/gegl-chant.h	(original)
+++ trunk/gegl/gegl-chant.h	Wed Jan 23 23:39:09 2008
@@ -89,7 +89,6 @@
 #define GEGL_CHANT_PROPERTIES(op) \
     ((GeglChantO*)(((GeglChant*)(op))->properties))
 
-#define GEGL_CHANT_O(op) GEGL_CHANT_PROPERTIES(op)
 /****************************************************************************/
 
 

Modified: trunk/operations/blur/box-blur.c
==============================================================================
--- trunk/operations/blur/box-blur.c	(original)
+++ trunk/operations/blur/box-blur.c	Wed Jan 23 23:39:09 2008
@@ -41,7 +41,7 @@
          GeglBuffer          *output,
          const GeglRectangle *result)
 {
-  GeglChantO *o = GEGL_CHANT_O (operation);
+  GeglChantO *o = GEGL_CHANT_PROPERTIES (operation);
   GeglBuffer *temp;
 
   temp  = gegl_buffer_new (gegl_buffer_get_extent (input),
@@ -230,7 +230,7 @@
   GeglOperationAreaFilter *op_area;
 
   op_area = GEGL_OPERATION_AREA_FILTER (operation);
-  o       = GEGL_CHANT_O (operation);
+  o       = GEGL_CHANT_PROPERTIES (operation);
 
   op_area->left   =
   op_area->right  =

Modified: trunk/operations/blur/gaussian-blur.c
==============================================================================
--- trunk/operations/blur/gaussian-blur.c	(original)
+++ trunk/operations/blur/gaussian-blur.c	Wed Jan 23 23:39:09 2008
@@ -83,7 +83,7 @@
          GeglBuffer          *output,
          const GeglRectangle *result)
 {
-  GeglChantO *o= GEGL_CHANT_O (operation);
+  GeglChantO *o= GEGL_CHANT_PROPERTIES (operation);
   GeglBuffer *temp;
   gdouble     B, b[4];
   gdouble    *cmatrix;
@@ -447,7 +447,7 @@
 static void tickle (GeglOperation *operation)
 {
   GeglOperationAreaFilter *area = GEGL_OPERATION_AREA_FILTER (operation);
-  GeglChantO              *o    = GEGL_CHANT_O (operation);
+  GeglChantO              *o    = GEGL_CHANT_PROPERTIES (operation);
   area->left = area->right = ceil (o->std_dev_x * RADIUS_SCALE);
   area->top = area->bottom = ceil (o->std_dev_y * RADIUS_SCALE);
 }

Modified: trunk/operations/color/mono-mixer.c
==============================================================================
--- trunk/operations/color/mono-mixer.c	(original)
+++ trunk/operations/color/mono-mixer.c	Wed Jan 23 23:39:09 2008
@@ -32,7 +32,7 @@
          GeglBuffer          *output,
          const GeglRectangle *result)
 {
-  GeglChantO *o     = GEGL_CHANT_O (operation);
+  GeglChantO *o     = GEGL_CHANT_PROPERTIES (operation);
 
   gfloat      red   = o->red;
   gfloat      green = o->green;

Modified: trunk/operations/workshop/box-max.c
==============================================================================
--- trunk/operations/workshop/box-max.c	(original)
+++ trunk/operations/workshop/box-max.c	Wed Jan 23 23:39:09 2008
@@ -43,7 +43,7 @@
          GeglBuffer          *output,
          const GeglRectangle *result)
 {
-  GeglChantO *o = GEGL_CHANT_O (operation);
+  GeglChantO *o = GEGL_CHANT_PROPERTIES (operation);
   GeglBuffer *temp;
 
   temp = gegl_buffer_new (gegl_buffer_get_extent (input),
@@ -176,7 +176,7 @@
   GeglOperationAreaFilter *area = GEGL_OPERATION_AREA_FILTER (operation);
 
   area->left = area->right = area->top = area->bottom =
-      ceil (GEGL_CHANT_O (operation)->radius);
+      ceil (GEGL_CHANT_PROPERTIES (operation)->radius);
 }
 
 

Modified: trunk/operations/workshop/box-min.c
==============================================================================
--- trunk/operations/workshop/box-min.c	(original)
+++ trunk/operations/workshop/box-min.c	Wed Jan 23 23:39:09 2008
@@ -44,7 +44,7 @@
          GeglBuffer          *output,
          const GeglRectangle *result)
 {
-  GeglChantO *o = GEGL_CHANT_O (operation);
+  GeglChantO *o = GEGL_CHANT_PROPERTIES (operation);
   GeglBuffer *temp;
 
   temp = gegl_buffer_new (gegl_buffer_get_extent (input),
@@ -179,7 +179,7 @@
   area->left  =
   area->right =
   area->top   =
-  area->bottom = GEGL_CHANT_O (operation)->radius;
+  area->bottom = GEGL_CHANT_PROPERTIES (operation)->radius;
 }
 
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]