glibmm r520 - in trunk: . gio/src

[murrayc svn gnome org]

Author: murrayc
Date: Thu Jan 17 23:23:04 2008
New Revision: 520
URL: http://svn.gnome.org/viewvc/glibmm?rev=520&view=rev

Log:
2008-01-18  Murray Cumming  <murrayc murrayc com>

* gio/src/appinfo.hg:
* gio/src/icon.hg: Removed operator= and operator!= for these RefPtr<> 
specializations, because they are unobvious and conflict with the generic 
ones.

Modified:
   trunk/ChangeLog
   trunk/gio/src/appinfo.hg
   trunk/gio/src/fileinfo.hg
   trunk/gio/src/fileinputstream.hg
   trunk/gio/src/icon.hg

Modified: trunk/gio/src/appinfo.hg
==============================================================================
--- trunk/gio/src/appinfo.hg	(original)
+++ trunk/gio/src/appinfo.hg	Thu Jan 17 23:23:04 2008
@@ -140,15 +140,5 @@
   //TODO: vfuncs?
 };
 
-//TODO: Probably remove these (and others elsewhere) because they will lead to confusion with the regular RefPtr operator==. murrayc.
-
-/** @relates Gio::AppInfo */
-inline bool operator==(const Glib::RefPtr<AppInfo>& lhs, const Glib::RefPtr<AppInfo>& rhs)
-{ return lhs->equal(rhs); }
-
-/** @relates Gio::AppInfo */
-inline bool operator!=(const Glib::RefPtr<AppInfo>& lhs, const Glib::RefPtr<AppInfo>& rhs)
-{ return ! lhs->equal(rhs); }
-
 } // namespace Gio
 

Modified: trunk/gio/src/fileinfo.hg
==============================================================================
--- trunk/gio/src/fileinfo.hg	(original)
+++ trunk/gio/src/fileinfo.hg	Thu Jan 17 23:23:04 2008
@@ -151,10 +151,6 @@
   _WRAP_METHOD(void set_edit_name(const std::string& edit_name), g_file_info_set_edit_name)
   _WRAP_METHOD(void set_icon(const Glib::RefPtr<Icon>& icon), g_file_info_set_icon)
   _WRAP_METHOD(void set_content_type(const std::string& content_type), g_file_info_set_content_type)
-
-  // TODO: how can you set size of a file?!
-  // In implementation this is just setting a struct field...
-  // See bug #508378. murrayc.
   _WRAP_METHOD(void set_size(goffset size), g_file_info_set_size)
 
   _WRAP_METHOD(void set_modification_time(const Glib::TimeVal& mtime), g_file_info_set_modification_time)

Modified: trunk/gio/src/fileinputstream.hg
==============================================================================
--- trunk/gio/src/fileinputstream.hg	(original)
+++ trunk/gio/src/fileinputstream.hg	Thu Jan 17 23:23:04 2008
@@ -31,8 +31,6 @@
 namespace Gio
 {
 
-//TODO: This implements Seekable.
-
 /** FileInputStream provides input streams that take their content from a file.
  *
  * FileInputStream implements Seekable, which allows the input stream to jump to arbitrary positions in the file, 

Modified: trunk/gio/src/icon.hg
==============================================================================
--- trunk/gio/src/icon.hg	(original)
+++ trunk/gio/src/icon.hg	Thu Jan 17 23:23:04 2008
@@ -56,20 +56,5 @@
   // to have it generally...
 };
 
-//TODO: I'm not very happy about these operator==. 
-//RefPtr already has operator== that just checks the pointers for equality, 
-//and this would be adding an implicit change of behaviour to those.
-//murrayc.
-
-/** @relates Gio::Icon */
-inline bool operator==(const Glib::RefPtr<Icon>& lhs,
-                       const Glib::RefPtr<Icon>& rhs)
-{ return lhs->equal(rhs); }
-
-/** @relates Gio::Icon */
-inline bool operator!=(const Glib::RefPtr<Icon>& lhs,
-                       const Glib::RefPtr<Icon>& rhs)
-{ return ! lhs->equal(rhs); }
-
 } // namespace Gio