evolution-data-server r8342 - trunk/camel/providers/smtp

[mcrha svn gnome org]

Author: mcrha
Date: Mon Jan  7 10:56:03 2008
New Revision: 8342
URL: http://svn.gnome.org/viewvc/evolution-data-server?rev=8342&view=rev

Log:
2008-01-07  Milan Crha  <mcrha redhat com>

	** Fix for bug #504837

	* camel-smtp-transport.c: (connect_to_server):
	Do not ignore HELO failed message.



Modified:
   trunk/camel/providers/smtp/ChangeLog
   trunk/camel/providers/smtp/camel-smtp-transport.c

Modified: trunk/camel/providers/smtp/ChangeLog
==============================================================================
--- trunk/camel/providers/smtp/ChangeLog	(original)
+++ trunk/camel/providers/smtp/ChangeLog	Mon Jan  7 10:56:03 2008
@@ -1,3 +1,10 @@
+2008-01-07  Milan Crha  <mcrha redhat com>
+
+	** Fix for bug #504837
+
+	* camel-smtp-transport.c: (connect_to_server):
+	Do not ignore HELO failed message.
+
 2007-12-23  Jeffrey Stedfast  <fejj novell com>
 
 	* camel-smtp-transport.c (smtp_helo): Get rid of some unneccessary

Modified: trunk/camel/providers/smtp/camel-smtp-transport.c
==============================================================================
--- trunk/camel/providers/smtp/camel-smtp-transport.c	(original)
+++ trunk/camel/providers/smtp/camel-smtp-transport.c	Mon Jan  7 10:56:03 2008
@@ -308,8 +308,12 @@
 		/* Fall back to HELO */
 		camel_exception_clear (ex);
 		transport->flags &= ~CAMEL_SMTP_TRANSPORT_IS_ESMTP;
-		if (!smtp_helo (transport, ex) && !transport->connected)
+
+		if (!smtp_helo (transport, ex)) {
+			camel_service_disconnect ((CamelService *) transport, TRUE, NULL);
+
 			return FALSE;
+		}
 	}
 
 	/* clear any EHLO/HELO exception and assume that any SMTP errors encountered were non-fatal */
@@ -369,8 +373,11 @@
 
 	/* We are supposed to re-EHLO after a successful STARTTLS to
            re-fetch any supported extensions. */
-	if (!smtp_helo (transport, ex) && !transport->connected)
+	if (!smtp_helo (transport, ex)) {
+		camel_service_disconnect ((CamelService *) transport, TRUE, NULL);
+
 		return FALSE;
+	}
 
 	return TRUE;