banshee r3354 - in trunk/banshee: . src/Core/Banshee.Services/Banshee.Base src/Core/Banshee.Services/Banshee.Database src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue src/Libraries/Hyena.Gui/Hyena.Query.Gui src/Libraries/Hyena/Hyena.Data.Sqlite src/Libraries/Lastfm.Gui/Lastfm.Gui

[gburt svn gnome org]

Author: gburt
Date: Fri Feb 29 00:57:36 2008
New Revision: 3354
URL: http://svn.gnome.org/viewvc/banshee?rev=3354&view=rev

Log:
2008-02-28  Gabriel Burt  <gabriel burt gmail com>

	* src/Core/Banshee.Services/Banshee.Base/RateLimiter.cs:
	* src/Core/Banshee.Services/Banshee.Database/BansheeDbFormatMigrator.cs:
	* src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs:
	* src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryBox.cs:
	* src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryLimitBox.cs:
	* src/Libraries/Hyena/Hyena.Data.Sqlite/HyenaSqliteConnection.cs:
	* src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginDialog.cs:
	* src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginForm.cs: Fix warnings.


Modified:
   trunk/banshee/ChangeLog
   trunk/banshee/src/Core/Banshee.Services/Banshee.Base/RateLimiter.cs
   trunk/banshee/src/Core/Banshee.Services/Banshee.Database/BansheeDbFormatMigrator.cs
   trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryBox.cs
   trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryLimitBox.cs
   trunk/banshee/src/Libraries/Hyena/Hyena.Data.Sqlite/HyenaSqliteConnection.cs
   trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginDialog.cs
   trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginForm.cs

Modified: trunk/banshee/src/Core/Banshee.Services/Banshee.Base/RateLimiter.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.Services/Banshee.Base/RateLimiter.cs	(original)
+++ trunk/banshee/src/Core/Banshee.Services/Banshee.Base/RateLimiter.cs	Fri Feb 29 00:57:36 2008
@@ -45,8 +45,6 @@
         private double requested_interval;
         private bool executing = false;
 
-        private string name;
-
         public RateLimiter (double min_interval_ms, RateLimitedMethod method) : this (0.0, min_interval_ms, method)
         {
         }

Modified: trunk/banshee/src/Core/Banshee.Services/Banshee.Database/BansheeDbFormatMigrator.cs
==============================================================================
--- trunk/banshee/src/Core/Banshee.Services/Banshee.Database/BansheeDbFormatMigrator.cs	(original)
+++ trunk/banshee/src/Core/Banshee.Services/Banshee.Database/BansheeDbFormatMigrator.cs	Fri Feb 29 00:57:36 2008
@@ -513,9 +513,7 @@
 
         private void RefreshMetadataThread (object state)
         {
-            Banshee.Library.LibrarySource library = ServiceManager.SourceManager.Library;
             int total = ServiceManager.DbConnection.Query<int> ("SELECT count(*) FROM CoreTracks WHERE SourceID = 1");
-            long now = DateTimeUtil.FromDateTime (DateTime.Now);
 
             if (total <= 0) {
                 return;

Modified: trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs
==============================================================================
--- trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs	(original)
+++ trunk/banshee/src/Extensions/Banshee.PlayQueue/Banshee.PlayQueue/PlayQueueSource.cs	Fri Feb 29 00:57:36 2008
@@ -43,7 +43,6 @@
 using Banshee.PlaybackController;
 using Banshee.MediaEngine;
 using Banshee.Configuration;
-using Banshee.Library;
 using Banshee.Gui;
 
 namespace Banshee.PlayQueue

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryBox.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryBox.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryBox.cs	Fri Feb 29 00:57:36 2008
@@ -161,7 +161,7 @@
                             nodes.Add (value);
                             terms_box.QueryNodes = nodes;
                         }
-                    } catch (ArgumentException e) {
+                    } catch (ArgumentException) {
                         complex_query = true;
                         matchesFrame.HideAll ();
                         terms_entry.Text = value.ToUserQuery ();

Modified: trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryLimitBox.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryLimitBox.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena.Gui/Hyena.Query.Gui/QueryLimitBox.cs	Fri Feb 29 00:57:36 2008
@@ -93,7 +93,7 @@
 
         private bool IsRowSeparator (TreeModel model, TreeIter iter)
         {
-            return model.GetValue (iter, 0) == String.Empty;
+            return String.IsNullOrEmpty (model.GetValue (iter, 0) as string);
         }
 
         public QueryLimit Limit {

Modified: trunk/banshee/src/Libraries/Hyena/Hyena.Data.Sqlite/HyenaSqliteConnection.cs
==============================================================================
--- trunk/banshee/src/Libraries/Hyena/Hyena.Data.Sqlite/HyenaSqliteConnection.cs	(original)
+++ trunk/banshee/src/Libraries/Hyena/Hyena.Data.Sqlite/HyenaSqliteConnection.cs	Fri Feb 29 00:57:36 2008
@@ -52,7 +52,6 @@
 
         private Queue<HyenaSqliteCommand> command_queue = new Queue<HyenaSqliteCommand>();
         private Thread queue_thread;
-        private bool processing_queue = false;
         private volatile bool dispose_requested = false;
         private volatile int results_ready = 0;
         private AutoResetEvent queue_signal = new AutoResetEvent (false);
@@ -266,7 +265,6 @@
 
         private void QueueCommand(HyenaSqliteCommand command)
         {
-            bool queued = false;
             while (true) {
                 lock (command_queue) {
                     if (transaction_thread == null || Thread.CurrentThread == transaction_thread) {

Modified: trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginDialog.cs
==============================================================================
--- trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginDialog.cs	(original)
+++ trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginDialog.cs	Fri Feb 29 00:57:36 2008
@@ -39,7 +39,6 @@
         private AccelGroup accel_group;
         private AccountLoginForm login_form;
         private Label message;
-        private Account account;
     
         public AccountLoginDialog (Account account) : this (account, false)
         {
@@ -47,8 +46,6 @@
     
         public AccountLoginDialog (Account account, bool addCloseButton) : base ()
         {
-            this.account = account;
-
             Title = Catalog.GetString ("Last.fm Account Login");
             HasSeparator = false;
             BorderWidth = 5;

Modified: trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginForm.cs
==============================================================================
--- trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginForm.cs	(original)
+++ trunk/banshee/src/Libraries/Lastfm.Gui/Lastfm.Gui/AccountLoginForm.cs	Fri Feb 29 00:57:36 2008
@@ -41,7 +41,6 @@
         private Entry password_entry;
         private LinkButton signup_button;
         
-        private bool is_destroyed = false;
         private bool save_on_edit = false;
 
         public AccountLoginForm (Account account) : base (2, 2, false)
@@ -93,7 +92,6 @@
             }
             
             base.OnDestroyed ();
-            is_destroyed = true;
         }
         
         public void AddSignUpButton ()