gvfs r1302 - in trunk: . client common daemon gconf hal programs test



Author: alexl
Date: Tue Feb 19 09:41:06 2008
New Revision: 1302
URL: http://svn.gnome.org/viewvc/gvfs?rev=1302&view=rev

Log:
2008-02-19  Alexander Larsson  <alexl redhat com>

	* lots of *.c files:
	Code cleanup from Kjartan:
	Removes unused code/variables.
	Uses right printf types
	Uses non-deprecated dbus calls.
	Removes spurious ; and ,
	deleted extra checks for NULL for g_free



Modified:
   trunk/ChangeLog
   trunk/client/gdaemonfile.c
   trunk/client/gdaemonfileenumerator.c
   trunk/client/gdaemonfileinputstream.c
   trunk/client/gdaemonfileoutputstream.c
   trunk/client/gdaemonvfs.c
   trunk/client/gdaemonvolumemonitor.c
   trunk/client/gvfsfusedaemon.c
   trunk/client/gvfsurimapper.c
   trunk/client/httpuri.c
   trunk/client/sftpuri.c
   trunk/client/smburi.c
   trunk/common/gdbusutils.c
   trunk/common/gmountsource.c
   trunk/common/gmounttracker.c
   trunk/common/gvfsdaemonprotocol.c
   trunk/daemon/dbus-gmain.c
   trunk/daemon/gvfsbackendburn.c
   trunk/daemon/gvfsbackendcdda.c
   trunk/daemon/gvfsbackendcomputer.c
   trunk/daemon/gvfsbackenddav.c
   trunk/daemon/gvfsbackendftp.c
   trunk/daemon/gvfsbackendhttp.c
   trunk/daemon/gvfsbackendlocaltest.c
   trunk/daemon/gvfsbackendsftp.c
   trunk/daemon/gvfsbackendsmb.c
   trunk/daemon/gvfsbackendsmbbrowse.c
   trunk/daemon/gvfsbackendtest.c
   trunk/daemon/gvfsbackendtrash.c
   trunk/daemon/gvfschannel.c
   trunk/daemon/gvfsdaemon.c
   trunk/daemon/gvfsjob.c
   trunk/daemon/gvfsjobcloseread.c
   trunk/daemon/gvfsjobclosewrite.c
   trunk/daemon/gvfsjobcopy.c
   trunk/daemon/gvfsjobcreatemonitor.c
   trunk/daemon/gvfsjobdbus.c
   trunk/daemon/gvfsjobdelete.c
   trunk/daemon/gvfsjobenumerate.c
   trunk/daemon/gvfsjobmakedirectory.c
   trunk/daemon/gvfsjobmakesymlink.c
   trunk/daemon/gvfsjobmount.c
   trunk/daemon/gvfsjobmountmountable.c
   trunk/daemon/gvfsjobmove.c
   trunk/daemon/gvfsjobopenforread.c
   trunk/daemon/gvfsjobopenforwrite.c
   trunk/daemon/gvfsjobqueryattributes.c
   trunk/daemon/gvfsjobqueryfsinfo.c
   trunk/daemon/gvfsjobqueryinfo.c
   trunk/daemon/gvfsjobread.c
   trunk/daemon/gvfsjobseekread.c
   trunk/daemon/gvfsjobseekwrite.c
   trunk/daemon/gvfsjobsetattribute.c
   trunk/daemon/gvfsjobsetdisplayname.c
   trunk/daemon/gvfsjobtrash.c
   trunk/daemon/gvfsjobunmount.c
   trunk/daemon/gvfsjobunmountmountable.c
   trunk/daemon/gvfsjobupload.c
   trunk/daemon/gvfsjobwrite.c
   trunk/daemon/gvfsmonitor.c
   trunk/daemon/gvfsreadchannel.c
   trunk/daemon/gvfswritechannel.c
   trunk/daemon/main.c
   trunk/daemon/soup-input-stream.c
   trunk/daemon/soup-output-stream.c
   trunk/gconf/gapplookupgconf.c
   trunk/hal/ghalmount.c
   trunk/hal/ghalvolume.c
   trunk/hal/ghalvolumemonitor.c
   trunk/hal/hal-device.c
   trunk/hal/hal-pool.c
   trunk/programs/gvfs-copy.c
   trunk/programs/gvfs-mount.c
   trunk/programs/gvfs-move.c
   trunk/test/benchmark-posix-big-files.c

Modified: trunk/client/gdaemonfile.c
==============================================================================
--- trunk/client/gdaemonfile.c	(original)
+++ trunk/client/gdaemonfile.c	Tue Feb 19 09:41:06 2008
@@ -629,7 +629,6 @@
 {
   GDaemonFile *daemon_file = G_DAEMON_FILE (file);
   va_list var_args;
-  GError *error;
   AsyncPathCall *data;
 
   data = g_new0 (AsyncPathCall, 1);
@@ -646,8 +645,6 @@
   data->callback_data = callback_data;
   data->notify = notify;
   
-  error = NULL;
-
   if (first_arg_type != 0)
     {
       data->args = dbus_message_new (DBUS_MESSAGE_TYPE_METHOD_CALL);
@@ -743,7 +740,7 @@
 			     NULL, NULL,
 			     cancellable, error,
 			     DBUS_TYPE_STRING, &attributes,
-			     DBUS_TYPE_UINT32, &flags,
+			     DBUS_TYPE_UINT32, &flags_dbus,
 			     DBUS_TYPE_STRING, &uri,
 			     0);
 
@@ -1633,11 +1630,8 @@
 		      GCancellable *cancellable,
 		      GError **error)
 {
-  GDaemonFile *daemon_file;
   DBusMessage *reply;
 
-  daemon_file = G_DAEMON_FILE (file);
-  
   reply = do_sync_path_call (file, 
 			     G_VFS_DBUS_MOUNT_OP_DELETE,
 			     NULL, NULL,
@@ -1655,11 +1649,8 @@
 		     GCancellable *cancellable,
 		     GError **error)
 {
-  GDaemonFile *daemon_file;
   DBusMessage *reply;
 
-  daemon_file = G_DAEMON_FILE (file);
-  
   reply = do_sync_path_call (file, 
 			     G_VFS_DBUS_MOUNT_OP_TRASH,
 			     NULL, NULL,
@@ -1677,11 +1668,8 @@
 			      GCancellable *cancellable,
 			      GError **error)
 {
-  GDaemonFile *daemon_file;
   DBusMessage *reply;
 
-  daemon_file = G_DAEMON_FILE (file);
-
   reply = do_sync_path_call (file, 
 			     G_VFS_DBUS_MOUNT_OP_MAKE_DIRECTORY,
 			     NULL, NULL,
@@ -1775,13 +1763,10 @@
 			     GCancellable *cancellable,
 			     GError **error)
 {
-  GDaemonFile *daemon_file;
   DBusMessage *message, *reply;
   DBusMessageIter iter;
   dbus_uint32_t flags_dbus;
 
-  daemon_file = G_DAEMON_FILE (file);
-
   message = create_empty_message (file, G_VFS_DBUS_MOUNT_OP_SET_ATTRIBUTE, NULL, error);
   if (!message)
     return FALSE;
@@ -1846,7 +1831,7 @@
 		    gpointer                progress_callback_data,
 		    GError                **error)
 {
-  GDaemonFile *daemon_source, *daemon_dest;
+  GDaemonFile *daemon_source;
   DBusMessage *reply;
   char *local_path;
   char *obj_path, *dbus_obj_path;
@@ -1859,7 +1844,6 @@
       g_set_error (error, G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED, "%s", "Move not supported");
       return FALSE;
     }
-  daemon_dest = G_DAEMON_FILE (destination);
 
   if (G_IS_DAEMON_FILE (source))
     {
@@ -1938,7 +1922,6 @@
 		    gpointer                progress_callback_data,
 		    GError                **error)
 {
-  GDaemonFile *daemon_source, *daemon_dest;
   DBusMessage *reply;
   char *obj_path, *dbus_obj_path;
   dbus_uint32_t flags_dbus;
@@ -1952,9 +1935,6 @@
       return FALSE;
     }
   
-  daemon_source = G_DAEMON_FILE (source);
-  daemon_dest = G_DAEMON_FILE (destination);
-
   if (progress_callback)
     {
       obj_path = g_strdup_printf ("/org/gtk/vfs/callback/%p", &obj_path);

Modified: trunk/client/gdaemonfileenumerator.c
==============================================================================
--- trunk/client/gdaemonfileenumerator.c	(original)
+++ trunk/client/gdaemonfileenumerator.c	Tue Feb 19 09:41:06 2008
@@ -51,7 +51,7 @@
   
 };
 
-G_DEFINE_TYPE (GDaemonFileEnumerator, g_daemon_file_enumerator, G_TYPE_FILE_ENUMERATOR);
+G_DEFINE_TYPE (GDaemonFileEnumerator, g_daemon_file_enumerator, G_TYPE_FILE_ENUMERATOR)
 
 static GFileInfo *       g_daemon_file_enumerator_next_file   (GFileEnumerator  *enumerator,
 							       GCancellable     *cancellable,

Modified: trunk/client/gdaemonfileinputstream.c
==============================================================================
--- trunk/client/gdaemonfileinputstream.c	(original)
+++ trunk/client/gdaemonfileinputstream.c	Tue Feb 19 09:41:06 2008
@@ -743,10 +743,11 @@
 				 GCancellable *cancellable,
 				 GError      **error)
 {
+#if 0
   GDaemonFileInputStream *file;
 
   file = G_DAEMON_FILE_INPUT_STREAM (stream);
-  
+#endif  
   /* TODO: implement skip */
   g_assert_not_reached ();
   
@@ -1237,10 +1238,6 @@
 				       GCancellable         *cancellable,
 				       GError              **error)
 {
-  GDaemonFileInputStream *file;
-
-  file = G_DAEMON_FILE_INPUT_STREAM (stream);
-
   g_set_error (error, G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED, "%s", _("The query info operation is not supported"));
   
   return NULL;
@@ -1502,7 +1499,6 @@
 					gpointer            user_data)
 {
   GDaemonFileInputStream *file;
-  AsyncIterator *iterator;
   ReadOperation *op;
 
   file = G_DAEMON_FILE_INPUT_STREAM (stream);
@@ -1516,8 +1512,6 @@
   op->buffer = buffer;
   op->buffer_size = count;
 
-  iterator = g_new0 (AsyncIterator, 1);
-  
   run_async_state_machine (file,
 			   (state_machine_iterator)iterate_read_state_machine,
 			   op,
@@ -1628,7 +1622,6 @@
 					gpointer            data)
 {
   GDaemonFileInputStream *file;
-  AsyncIterator *iterator;
   CloseOperation *op;
 
   file = G_DAEMON_FILE_INPUT_STREAM (stream);
@@ -1636,8 +1629,6 @@
   op = g_new0 (CloseOperation, 1);
   op->state = CLOSE_STATE_INIT;
 
-  iterator = g_new0 (AsyncIterator, 1);
-  
   run_async_state_machine (file,
 			   (state_machine_iterator)iterate_close_state_machine,
 			   op, io_priority,

Modified: trunk/client/gdaemonfileoutputstream.c
==============================================================================
--- trunk/client/gdaemonfileoutputstream.c	(original)
+++ trunk/client/gdaemonfileoutputstream.c	Tue Feb 19 09:41:06 2008
@@ -983,10 +983,11 @@
 					GCancellable         *cancellable,
 					GError              **error)
 {
+#if 0
   GDaemonFileOutputStream *file;
 
   file = G_DAEMON_FILE_OUTPUT_STREAM (stream);
-
+#endif
   return NULL;
 }
 
@@ -1246,7 +1247,6 @@
 					  gpointer            data)
 {
   GDaemonFileOutputStream *file;
-  AsyncIterator *iterator;
   WriteOperation *op;
 
   file = G_DAEMON_FILE_OUTPUT_STREAM (stream);
@@ -1260,8 +1260,6 @@
   op->buffer = buffer;
   op->buffer_size = count;
 
-  iterator = g_new0 (AsyncIterator, 1);
-  
   run_async_state_machine (file,
 			   (state_machine_iterator)iterate_write_state_machine,
 			   op,
@@ -1349,7 +1347,6 @@
 					gpointer            data)
 {
   GDaemonFileOutputStream *file;
-  AsyncIterator *iterator;
   CloseOperation *op;
 
   file = G_DAEMON_FILE_OUTPUT_STREAM (stream);
@@ -1357,14 +1354,12 @@
   op = g_new0 (CloseOperation, 1);
   op->state = CLOSE_STATE_INIT;
 
-  iterator = g_new0 (AsyncIterator, 1);
-  
   run_async_state_machine (file,
 			   (state_machine_iterator)iterate_close_state_machine,
 			   op, io_priority,
-			   (gpointer)callback, data,
+			   (GAsyncReadyCallback)callback, data,
 			   cancellable,
-			   (gpointer)async_close_done);
+			   (AsyncIteratorDone)async_close_done);
 }
 
 static gboolean

Modified: trunk/client/gdaemonvfs.c
==============================================================================
--- trunk/client/gdaemonvfs.c	(original)
+++ trunk/client/gdaemonvfs.c	Tue Feb 19 09:41:06 2008
@@ -59,7 +59,7 @@
   GVfsClass parent_class;
 };
 
-G_DEFINE_DYNAMIC_TYPE (GDaemonVfs, g_daemon_vfs, G_TYPE_VFS);
+G_DEFINE_DYNAMIC_TYPE (GDaemonVfs, g_daemon_vfs, G_TYPE_VFS)
 
 static GDaemonVfs *the_vfs = NULL;
 
@@ -558,11 +558,9 @@
 void
 _g_daemon_vfs_invalidate_dbus_id (const char *dbus_id)
 {
-  GMountInfo *info;
   GList *l, *next;
 
   G_LOCK (mount_cache);
-  info = NULL;
   for (l = the_vfs->mount_cache; l != NULL; l = next)
     {
       GMountInfo *mount_info = l->data;

Modified: trunk/client/gdaemonvolumemonitor.c
==============================================================================
--- trunk/client/gdaemonvolumemonitor.c	(original)
+++ trunk/client/gdaemonvolumemonitor.c	Tue Feb 19 09:41:06 2008
@@ -38,7 +38,7 @@
   GList *mounts;
 };
 
-G_DEFINE_DYNAMIC_TYPE (GDaemonVolumeMonitor, g_daemon_volume_monitor, G_TYPE_VOLUME_MONITOR);
+G_DEFINE_DYNAMIC_TYPE (GDaemonVolumeMonitor, g_daemon_volume_monitor, G_TYPE_VOLUME_MONITOR)
 
 static GList *
 get_mounts (GVolumeMonitor *volume_monitor)

Modified: trunk/client/gvfsfusedaemon.c
==============================================================================
--- trunk/client/gvfsfusedaemon.c	(original)
+++ trunk/client/gvfsfusedaemon.c	Tue Feb 19 09:41:06 2008
@@ -1315,7 +1315,7 @@
   debug_print ("vfs_flush: %s\n", path);
 
   return 0;
-};
+}
 
 static gint
 vfs_opendir (const gchar *path, struct fuse_file_info *fi)

Modified: trunk/client/gvfsurimapper.c
==============================================================================
--- trunk/client/gvfsurimapper.c	(original)
+++ trunk/client/gvfsurimapper.c	Tue Feb 19 09:41:06 2008
@@ -25,7 +25,7 @@
 #include <gmodule.h>
 #include "gvfsurimapper.h"
 
-G_DEFINE_DYNAMIC_TYPE (GVfsUriMapper, g_vfs_uri_mapper, G_TYPE_OBJECT);
+G_DEFINE_DYNAMIC_TYPE (GVfsUriMapper, g_vfs_uri_mapper, G_TYPE_OBJECT)
 
 void
 g_vfs_uri_mapper_register (GIOModule *module)

Modified: trunk/client/httpuri.c
==============================================================================
--- trunk/client/httpuri.c	(original)
+++ trunk/client/httpuri.c	Tue Feb 19 09:41:06 2008
@@ -214,10 +214,10 @@
     }
   else
     {
-      GDecodedUri *uri;
+      GDecodedUri *decoded_uri;
       int          port_num;
 
-      uri = g_new0 (GDecodedUri, 1);
+      decoded_uri = g_new0 (GDecodedUri, 1);
 
       ssl  = g_vfs_uri_mount_info_get (info, "ssl");
       host = g_vfs_uri_mount_info_get (info, "host");
@@ -225,20 +225,20 @@
       port = g_vfs_uri_mount_info_get (info, "port");
 
       if (ssl && strcmp (ssl, "true") == 0)
-          uri->scheme = g_strdup ("davs");
+          decoded_uri->scheme = g_strdup ("davs");
       else
-          uri->scheme = g_strdup ("dav");
+          decoded_uri->scheme = g_strdup ("dav");
 
-      uri->host = g_strdup (host);
-      uri->userinfo = g_strdup (user);
+      decoded_uri->host = g_strdup (host);
+      decoded_uri->userinfo = g_strdup (user);
       
       if (port && (port_num = atoi (port)))
-          uri->port = port_num;
+          decoded_uri->port = port_num;
 
-      uri->path = g_strdup (info->path);
+      decoded_uri->path = g_strdup (info->path);
 
-      res = g_vfs_encode_uri (uri, allow_utf8);
-      g_vfs_decoded_uri_free (uri);
+      res = g_vfs_encode_uri (decoded_uri, allow_utf8);
+      g_vfs_decoded_uri_free (decoded_uri);
     }
 
   return res;
@@ -285,11 +285,8 @@
 static void
 g_vfs_uri_mapper_http_class_init (GVfsUriMapperHttpClass *class)
 {
-  GObjectClass       *object_class;
   GVfsUriMapperClass *mapper_class;
   
-  object_class = (GObjectClass *) class;
-
   mapper_class = G_VFS_URI_MAPPER_CLASS (class);
   mapper_class->get_handled_schemes     = http_get_handled_schemes;
   mapper_class->from_uri                = http_from_uri;

Modified: trunk/client/sftpuri.c
==============================================================================
--- trunk/client/sftpuri.c	(original)
+++ trunk/client/sftpuri.c	Tue Feb 19 09:41:06 2008
@@ -147,10 +147,8 @@
 static void
 g_vfs_uri_mapper_sftp_class_init (GVfsUriMapperSftpClass *class)
 {
-  GObjectClass *object_class;
   GVfsUriMapperClass *mapper_class;
   
-  object_class = (GObjectClass *) class;
   mapper_class = G_VFS_URI_MAPPER_CLASS (class);
   mapper_class->get_handled_schemes = sftp_get_handled_schemes;
   mapper_class->from_uri = sftp_from_uri;

Modified: trunk/client/smburi.c
==============================================================================
--- trunk/client/smburi.c	(original)
+++ trunk/client/smburi.c	Tue Feb 19 09:41:06 2008
@@ -269,10 +269,8 @@
 static void
 g_vfs_uri_mapper_smb_class_init (GVfsUriMapperSmbClass *class)
 {
-  GObjectClass *object_class;
   GVfsUriMapperClass *mapper_class;
   
-  object_class = (GObjectClass *) class;
   mapper_class = G_VFS_URI_MAPPER_CLASS (class);
   mapper_class->get_handled_schemes = smb_get_handled_schemes;
   mapper_class->from_uri = smb_from_uri;

Modified: trunk/common/gdbusutils.c
==============================================================================
--- trunk/common/gdbusutils.c	(original)
+++ trunk/common/gdbusutils.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,6 @@
 _g_dbus_oom (void)
 {
   g_error ("DBus failed with out of memory error");
-  exit(1);
 }
 
 /* We use _ for escaping, so its not valid */
@@ -915,7 +914,7 @@
   handler->dbus_source = dbus_source;
   handler->watch = watch;
 
-  handler->source = __g_fd_source_new (dbus_watch_get_fd (watch),
+  handler->source = __g_fd_source_new (dbus_watch_get_unix_fd (watch),
 				       condition, NULL);
   g_source_set_callback (handler->source,
 			 (GSourceFunc) io_handler_dispatch, handler,

Modified: trunk/common/gmountsource.c
==============================================================================
--- trunk/common/gmountsource.c	(original)
+++ trunk/common/gmountsource.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
   char *obj_path;
 };
 
-G_DEFINE_TYPE (GMountSource, g_mount_source, G_TYPE_OBJECT);
+G_DEFINE_TYPE (GMountSource, g_mount_source, G_TYPE_OBJECT)
 
 static void
 g_mount_source_finalize (GObject *object)
@@ -316,11 +316,8 @@
                           GAsyncResult *res,
                           gpointer user_data)
 {
-  GMountSource *source;
   AskPasswordSyncData *data;
 
-  source = G_MOUNT_SOURCE (source_object);
-
   data = (AskPasswordSyncData *) user_data;
 
   data->result = g_object_ref (res);

Modified: trunk/common/gmounttracker.c
==============================================================================
--- trunk/common/gmounttracker.c	(original)
+++ trunk/common/gmounttracker.c	Tue Feb 19 09:41:06 2008
@@ -54,7 +54,7 @@
   DBusConnection *connection;
 };
 
-G_DEFINE_TYPE (GMountTracker, g_mount_tracker, G_TYPE_OBJECT);
+G_DEFINE_TYPE (GMountTracker, g_mount_tracker, G_TYPE_OBJECT)
 
 static DBusHandlerResult g_mount_tracker_filter_func  (DBusConnection        *conn,
 						       DBusMessage           *message,

Modified: trunk/common/gvfsdaemonprotocol.c
==============================================================================
--- trunk/common/gvfsdaemonprotocol.c	(original)
+++ trunk/common/gvfsdaemonprotocol.c	Tue Feb 19 09:41:06 2008
@@ -226,7 +226,7 @@
       break;
     default:
       dbus_type = NULL;
-      g_warning ("Invalid attribute type %d, ignoring\n", type);
+      g_warning ("Invalid attribute type %u, ignoring\n", type);
       break;
     }
 

Modified: trunk/daemon/dbus-gmain.c
==============================================================================
--- trunk/daemon/dbus-gmain.c	(original)
+++ trunk/daemon/dbus-gmain.c	Tue Feb 19 09:41:06 2008
@@ -291,7 +291,7 @@
   handler->cs = cs;
   handler->watch = watch;
   
-  channel = g_io_channel_unix_new (dbus_watch_get_fd (watch));
+  channel = g_io_channel_unix_new (dbus_watch_get_unix_fd (watch));
   
   handler->source = g_io_create_watch (channel, condition);
   g_source_set_callback (handler->source, (GSourceFunc) io_handler_dispatch, handler,

Modified: trunk/daemon/gvfsbackendburn.c
==============================================================================
--- trunk/daemon/gvfsbackendburn.c	(original)
+++ trunk/daemon/gvfsbackendburn.c	Tue Feb 19 09:41:06 2008
@@ -94,7 +94,7 @@
   GMountSpec *mount_spec;
 };
 
-G_DEFINE_TYPE (GVfsBackendBurn, g_vfs_backend_burn, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendBurn, g_vfs_backend_burn, G_VFS_TYPE_BACKEND)
 
 
 static void virtual_node_unref (VirtualNode *node);
@@ -886,7 +886,7 @@
       return TRUE;
     }
 
-  g_print ("file: %p, overwrite: %d\n", file, flags & G_FILE_COPY_OVERWRITE);
+  g_print ("file: %p, overwrite: %u\n", file, flags & G_FILE_COPY_OVERWRITE);
   if (file != NULL)
     {
       if (flags & G_FILE_COPY_OVERWRITE)

Modified: trunk/daemon/gvfsbackendcdda.c
==============================================================================
--- trunk/daemon/gvfsbackendcdda.c	(original)
+++ trunk/daemon/gvfsbackendcdda.c	Tue Feb 19 09:41:06 2008
@@ -91,7 +91,7 @@
   int num_open_files;
 };
 
-G_DEFINE_TYPE (GVfsBackendCdda, g_vfs_backend_cdda, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendCdda, g_vfs_backend_cdda, G_VFS_TYPE_BACKEND)
 
 static void
 g_vfs_backend_cdda_finalize (GObject *object)

Modified: trunk/daemon/gvfsbackendcomputer.c
==============================================================================
--- trunk/daemon/gvfsbackendcomputer.c	(original)
+++ trunk/daemon/gvfsbackendcomputer.c	Tue Feb 19 09:41:06 2008
@@ -89,7 +89,7 @@
   GMountSpec *mount_spec;
 };
 
-G_DEFINE_TYPE (GVfsBackendComputer, g_vfs_backend_computer, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendComputer, g_vfs_backend_computer, G_VFS_TYPE_BACKEND)
 
 static void
 computer_file_free (ComputerFile *file)

Modified: trunk/daemon/gvfsbackenddav.c
==============================================================================
--- trunk/daemon/gvfsbackenddav.c	(original)
+++ trunk/daemon/gvfsbackenddav.c	Tue Feb 19 09:41:06 2008
@@ -66,15 +66,11 @@
 
 };
 
-G_DEFINE_TYPE (GVfsBackendDav, g_vfs_backend_dav, G_VFS_TYPE_BACKEND_HTTP);
+G_DEFINE_TYPE (GVfsBackendDav, g_vfs_backend_dav, G_VFS_TYPE_BACKEND_HTTP)
 
 static void
 g_vfs_backend_dav_finalize (GObject *object)
 {
-  GVfsBackendDav *backend;
-
-  backend = G_VFS_BACKEND_DAV (object);
-
   if (G_OBJECT_CLASS (g_vfs_backend_dav_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_vfs_backend_dav_parent_class)->finalize) (object);
 }
@@ -192,7 +188,6 @@
         default:
           return NULL;
       }
-    return NULL;
 }
 
 typedef struct _xmlNodeIter {
@@ -863,9 +858,9 @@
 
       if (mount_base->path)
         {
-          SoupMessage *msg;
-          msg = message_new_from_uri (SOUP_METHOD_OPTIONS, mount_base);
-          soup_session_queue_message (session, msg, 
+          SoupMessage *message;
+          message = message_new_from_uri (SOUP_METHOD_OPTIONS, mount_base);
+          soup_session_queue_message (session, message, 
                                       discover_mount_root_ready, job);
           return;
         } 
@@ -923,7 +918,6 @@
            GMountSource *mount_source,
            gboolean      is_automount)
 {
-  GVfsBackendDav *op_backend;
   MountOpData    *data;
   SoupSession    *session;
   SoupMessage    *msg;
@@ -936,8 +930,6 @@
 
   g_print ("+ mount\n");
 
-  op_backend = G_VFS_BACKEND_DAV (backend);
-
   host = g_mount_spec_get (mount_spec, "host");
   user = g_mount_spec_get (mount_spec, "user");
   port = g_mount_spec_get (mount_spec, "port");
@@ -1389,10 +1381,8 @@
            char *buffer,
            gsize buffer_size)
 {
-  GVfsBackendHttp *op_backend;
   GOutputStream   *stream;
 
-  op_backend = G_VFS_BACKEND_HTTP (backend);
   stream = G_OUTPUT_STREAM (handle);
 
   g_output_stream_write_async (stream,
@@ -1441,10 +1431,8 @@
                  GVfsJobCloseWrite *job,
                  GVfsBackendHandle handle)
 {
-  GVfsBackendHttp *op_backend;
   GOutputStream   *stream;
 
-  op_backend = G_VFS_BACKEND_HTTP (backend);
   stream = G_OUTPUT_STREAM (handle);
 
   g_output_stream_close_async (stream,

Modified: trunk/daemon/gvfsbackendftp.c
==============================================================================
--- trunk/daemon/gvfsbackendftp.c	(original)
+++ trunk/daemon/gvfsbackendftp.c	Tue Feb 19 09:41:06 2008
@@ -58,15 +58,11 @@
   gboolean mount_try_again;
 };
 
-G_DEFINE_TYPE (GVfsBackendFtp, g_vfs_backend_ftp, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendFtp, g_vfs_backend_ftp, G_VFS_TYPE_BACKEND)
 
 static void
 g_vfs_backend_ftp_finalize (GObject *object)
 {
-  GVfsBackendFtp *backend;
-
-  backend = G_VFS_BACKEND_FTP (object);
-
   if (G_OBJECT_CLASS (g_vfs_backend_ftp_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_vfs_backend_ftp_parent_class)->finalize) (object);
 }
@@ -101,7 +97,7 @@
 #if 0
   GVfsBackendFtp *op_backend = G_VFS_BACKEND_FTP (backend);
 #endif
-  const char *server, *share, *user, *domain;
+  const char *server, *share; /* *domain, *user; */
 
   server = g_mount_spec_get (mount_spec, "server");
   share = g_mount_spec_get (mount_spec, "share");
@@ -113,9 +109,10 @@
 			_("No hostname specified"));
       return TRUE;
     }
-
+#if 0
   user = g_mount_spec_get (mount_spec, "user");
   domain = g_mount_spec_get (mount_spec, "domain");
+#endif
 
   /* TODO */
 

Modified: trunk/daemon/gvfsbackendhttp.c
==============================================================================
--- trunk/daemon/gvfsbackendhttp.c	(original)
+++ trunk/daemon/gvfsbackendhttp.c	Tue Feb 19 09:41:06 2008
@@ -52,7 +52,7 @@
 #include "soup-input-stream.h"
 
 
-G_DEFINE_TYPE (GVfsBackendHttp, g_vfs_backend_http, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendHttp, g_vfs_backend_http, G_VFS_TYPE_BACKEND)
 
 static void
 g_vfs_backend_http_finalize (GObject *object)
@@ -195,12 +195,9 @@
                            const char  *method,
                            const char  *filename)
 {
-  GVfsBackendHttp *op_backend;
   SoupMessage     *msg;
   SoupURI         *uri;
 
-  op_backend = G_VFS_BACKEND_HTTP (backend);
-
   uri = g_vfs_backend_uri_for_filename (backend, filename);
   msg = message_new_from_uri (method, uri);
 
@@ -361,10 +358,8 @@
           char               *buffer,
           gsize               bytes_requested)
 {
-  GVfsBackendHttp *op_backend;
   GInputStream    *stream;
 
-  op_backend = G_VFS_BACKEND_HTTP (backend);
   stream = G_INPUT_STREAM (handle);
 
   g_input_stream_read_async (stream,
@@ -384,11 +379,9 @@
                   goffset    offset,
                   GSeekType  type)
 {
-  GVfsBackendHttp *op_backend;
   GInputStream    *stream;
   GError          *error = NULL;
 
-  op_backend = G_VFS_BACKEND_HTTP (backend);
   stream = G_INPUT_STREAM (handle);
 
   if (!g_seekable_seek (G_SEEKABLE (stream), offset, type,
@@ -446,10 +439,8 @@
                 GVfsJobCloseRead  *job,
                 GVfsBackendHandle  handle)
 {
-  GVfsBackendHttp *op_backend;
   GInputStream    *stream;
 
-  op_backend = G_VFS_BACKEND_HTTP (backend);
   stream = G_INPUT_STREAM (handle);
 
   g_input_stream_close_async (stream,
@@ -457,7 +448,6 @@
                               G_VFS_JOB (job)->cancellable,
                               close_read_ready,
                               job);
-
   return TRUE;
 }
 

Modified: trunk/daemon/gvfsbackendlocaltest.c
==============================================================================
--- trunk/daemon/gvfsbackendlocaltest.c	(original)
+++ trunk/daemon/gvfsbackendlocaltest.c	Tue Feb 19 09:41:06 2008
@@ -174,7 +174,7 @@
  * 
  */
 
-G_DEFINE_TYPE (GVfsBackendLocalTest, g_vfs_backend_localtest, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendLocalTest, g_vfs_backend_localtest, G_VFS_TYPE_BACKEND)
 
 static void
 g_vfs_backend_localtest_init (GVfsBackendLocalTest *backend)
@@ -599,7 +599,7 @@
   }
 }
 
-
+#if 0
 static void
 do_copy (GVfsBackend *backend,
  		 GVfsJobCopy *job,
@@ -636,7 +636,7 @@
 	  g_print ("  (EE) try_copy: file == NULL \n");
   }
 }
-
+#endif
 
 static void
 do_move (GVfsBackend *backend,

Modified: trunk/daemon/gvfsbackendsftp.c
==============================================================================
--- trunk/daemon/gvfsbackendsftp.c	(original)
+++ trunk/daemon/gvfsbackendsftp.c	Tue Feb 19 09:41:06 2008
@@ -144,7 +144,7 @@
                               GFileAttributeMatcher *attribute_matcher);
 
 
-G_DEFINE_TYPE (GVfsBackendSftp, g_vfs_backend_sftp, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendSftp, g_vfs_backend_sftp, G_VFS_TYPE_BACKEND)
 
 static void
 data_buffer_free (DataBuffer *buffer)
@@ -814,7 +814,7 @@
       g_hash_table_remove (backend->expected_replies, GINT_TO_POINTER (id));
     }
   else
-    g_warning ("Got unhandled reply of size %d for id %d\n", backend->reply_size, id);
+    g_warning ("Got unhandled reply of size %"G_GUINT32_FORMAT" for id %"G_GUINT32_FORMAT"\n", backend->reply_size, id);
 
   g_object_unref (reply);
 
@@ -1626,16 +1626,16 @@
       if (reply_type == SSH_FXP_HANDLE)
         {
           GDataOutputStream *command;
-          DataBuffer *handle;
+          DataBuffer *bhandle;
           guint32 id;
 
-          handle = read_data_buffer (reply);
+          bhandle = read_data_buffer (reply);
           
           command = new_command_stream (backend, SSH_FXP_CLOSE, &id);
-          put_data_buffer (command, handle);
+          put_data_buffer (command, bhandle);
           queue_command_stream_and_free (backend, command, id, NULL, G_VFS_JOB (job), NULL);
 
-          data_buffer_free (handle);
+          data_buffer_free (bhandle);
         }
       
       return;
@@ -2817,7 +2817,6 @@
   GVfsJobEnumerate *enum_job;
   guint32 count;
   int i;
-  GList *infos;
   guint32 id;
   GDataOutputStream *command;
   ReadDirData *data;
@@ -2844,7 +2843,6 @@
       return;
     }
 
-  infos = NULL;
   count = g_data_input_stream_read_uint32 (reply, NULL, NULL);
   for (i = 0; i < count; i++)
     {

Modified: trunk/daemon/gvfsbackendsmb.c
==============================================================================
--- trunk/daemon/gvfsbackendsmb.c	(original)
+++ trunk/daemon/gvfsbackendsmb.c	Tue Feb 19 09:41:06 2008
@@ -77,7 +77,7 @@
   SMBCSRV *cached_server;
 };
 
-G_DEFINE_TYPE (GVfsBackendSmb, g_vfs_backend_smb, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendSmb, g_vfs_backend_smb, G_VFS_TYPE_BACKEND)
 
 static void
 g_vfs_backend_smb_finalize (GObject *object)

Modified: trunk/daemon/gvfsbackendsmbbrowse.c
==============================================================================
--- trunk/daemon/gvfsbackendsmbbrowse.c	(original)
+++ trunk/daemon/gvfsbackendsmbbrowse.c	Tue Feb 19 09:41:06 2008
@@ -77,7 +77,7 @@
   char *username;
 } CachedServer;
 
-G_DEFINE_TYPE (GVfsBackendSmbBrowse, g_vfs_backend_smb_browse, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendSmbBrowse, g_vfs_backend_smb_browse, G_VFS_TYPE_BACKEND)
 
 static char *
 normalize_smb_name_helper (const char *name, gssize len, gboolean valid_utf8)
@@ -447,7 +447,7 @@
 	{
 	  unsigned int dirlen;
 
-	  g_print ("type: %d, name: %s\n", dirp->smbc_type, dirp->name);
+	  g_print ("type: %u, name: %s\n", dirp->smbc_type, dirp->name);
 	  
 	  if (dirp->smbc_type != SMBC_IPC_SHARE &&
 	      dirp->smbc_type != SMBC_COMMS_SHARE &&
@@ -756,12 +756,10 @@
 		     const char *filename,
 		     GMountSource *mount_source)
 {
-  GFileInfo *info;
   BrowseEntry *entry;
   GError *error = NULL;
   GMountSpec *mount_spec;
 
-  info = NULL;
   g_mutex_lock (backend->entries_lock);
   
   entry = find_entry_unlocked (backend, filename);

Modified: trunk/daemon/gvfsbackendtest.c
==============================================================================
--- trunk/daemon/gvfsbackendtest.c	(original)
+++ trunk/daemon/gvfsbackendtest.c	Tue Feb 19 09:41:06 2008
@@ -40,15 +40,11 @@
 #include "gvfsjobqueryinfo.h"
 #include "gvfsjobenumerate.h"
 
-G_DEFINE_TYPE (GVfsBackendTest, g_vfs_backend_test, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendTest, g_vfs_backend_test, G_VFS_TYPE_BACKEND)
 
 static void
 g_vfs_backend_test_finalize (GObject *object)
 {
-  GVfsBackendTest *backend;
-
-  backend = G_VFS_BACKEND_TEST (object);
-  
   if (G_OBJECT_CLASS (g_vfs_backend_test_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_vfs_backend_test_parent_class)->finalize) (object);
 }
@@ -196,7 +192,7 @@
 {
   guint tag;
 
-  g_print ("read (%"G_GSSIZE_FORMAT")\n", bytes_requested);
+  g_print ("read (%"G_GSIZE_FORMAT")\n", bytes_requested);
 
   tag = g_timeout_add (0, read_idle_cb, job);
   G_VFS_JOB (job)->backend_data = GINT_TO_POINTER (tag);
@@ -216,7 +212,7 @@
   int fd;
   off_t final_offset;
 
-  g_print ("seek_on_read (%d, %d)\n", (int)offset, type);
+  g_print ("seek_on_read (%d, %u)\n", (int)offset, type);
 
   switch (type)
     {

Modified: trunk/daemon/gvfsbackendtrash.c
==============================================================================
--- trunk/daemon/gvfsbackendtrash.c	(original)
+++ trunk/daemon/gvfsbackendtrash.c	Tue Feb 19 09:41:06 2008
@@ -113,7 +113,7 @@
 
 G_LOCK_DEFINE_STATIC(root_monitor);
 
-G_DEFINE_TYPE (GVfsBackendTrash, g_vfs_backend_trash, G_VFS_TYPE_BACKEND);
+G_DEFINE_TYPE (GVfsBackendTrash, g_vfs_backend_trash, G_VFS_TYPE_BACKEND)
 
 static void   schedule_update_trash_files (GVfsBackendTrash *backend,
                                            gboolean          update_trash_dirs);
@@ -253,7 +253,7 @@
       return g_path_get_dirname (trash_dir);
     }
   
-  user_trash_basename =  g_strdup_printf (".Trash-%d", getuid());
+  user_trash_basename =  g_strdup_printf (".Trash-%u", getuid());
   if (strcmp (basename, user_trash_basename) == 0)
     {
       g_free (user_trash_basename);
@@ -262,7 +262,7 @@
     }
   g_free (user_trash_basename);
 
-  user_sys_dir = g_strdup_printf ("%d", getuid());
+  user_sys_dir = g_strdup_printf ("%u", getuid());
   if (strcmp (basename, user_sys_dir) == 0)
     {
       g_free (user_sys_dir);
@@ -347,7 +347,7 @@
       statbuf.st_mode & S_ISVTX)
     {
       /* We have a valid sysadmin .Trash dir, look for uid subdir */
-      sysadmin_dir_uid = g_strdup_printf ("%s/%d", sysadmin_dir, getuid());
+      sysadmin_dir_uid = g_strdup_printf ("%s/%u", sysadmin_dir, getuid());
       
       if (lstat (sysadmin_dir_uid, &statbuf) == 0 &&
           S_ISDIR (statbuf.st_mode) &&
@@ -363,7 +363,7 @@
     }
   g_free (sysadmin_dir);
 
-  user_trash_basename =  g_strdup_printf (".Trash-%d", getuid());
+  user_trash_basename =  g_strdup_printf (".Trash-%u", getuid());
   user_trash = g_build_filename (topdir, user_trash_basename, NULL);
   g_free (user_trash_basename);
   
@@ -1118,7 +1118,6 @@
       GFile *file;
       GFileEnumerator *enumerator;
       GFileInfo *info;
-      const char *name;
       char *dir;
       GError *error;
 
@@ -1142,8 +1141,6 @@
                                                       G_VFS_JOB (job)->cancellable,
                                                       NULL)) != NULL)
             {
-              name = g_file_info_get_name (info);
-              
               g_vfs_job_enumerate_add_info   (job, info);
               g_object_unref (info);
             }

Modified: trunk/daemon/gvfschannel.c
==============================================================================
--- trunk/daemon/gvfschannel.c	(original)
+++ trunk/daemon/gvfschannel.c	Tue Feb 19 09:41:06 2008
@@ -28,7 +28,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/un.h>
-#include <unistd.h>
 #include <fcntl.h>
 
 #include <glib.h>

Modified: trunk/daemon/gvfsdaemon.c
==============================================================================
--- trunk/daemon/gvfsdaemon.c	(original)
+++ trunk/daemon/gvfsdaemon.c	Tue Feb 19 09:41:06 2008
@@ -98,7 +98,7 @@
 						    gpointer        data);
 
 
-G_DEFINE_TYPE (GVfsDaemon, g_vfs_daemon, G_TYPE_OBJECT);
+G_DEFINE_TYPE (GVfsDaemon, g_vfs_daemon, G_TYPE_OBJECT)
 
 static void
 registered_path_free (RegisteredPath *data)
@@ -189,10 +189,11 @@
 			   const GValue    *value,
 			   GParamSpec      *pspec)
 {
+#if 0
   GVfsDaemon *daemon;
   
   daemon = G_VFS_DAEMON (object);
-  
+#endif
   switch (prop_id)
     {
     default:
@@ -207,10 +208,11 @@
 			   GValue     *value,
 			   GParamSpec *pspec)
 {
+#if 0
   GVfsDaemon *daemon;
   
   daemon = G_VFS_DAEMON (object);
-
+#endif
   switch (prop_id)
     {
     default:

Modified: trunk/daemon/gvfsjob.c
==============================================================================
--- trunk/daemon/gvfsjob.c	(original)
+++ trunk/daemon/gvfsjob.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gvfsjob.h"
 #include "gvfsjobsource.h"
 
-G_DEFINE_TYPE (GVfsJob, g_vfs_job, G_TYPE_OBJECT);
+G_DEFINE_TYPE (GVfsJob, g_vfs_job, G_TYPE_OBJECT)
 
 /* TODO: Real P_() */
 #define P_(_x) (_x)

Modified: trunk/daemon/gvfsjobcloseread.c
==============================================================================
--- trunk/daemon/gvfsjobcloseread.c	(original)
+++ trunk/daemon/gvfsjobcloseread.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobcloseread.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobCloseRead, g_vfs_job_close_read, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobCloseRead, g_vfs_job_close_read, G_VFS_TYPE_JOB)
 
 static void run (GVfsJob *job);
 static gboolean try (GVfsJob *job);

Modified: trunk/daemon/gvfsjobclosewrite.c
==============================================================================
--- trunk/daemon/gvfsjobclosewrite.c	(original)
+++ trunk/daemon/gvfsjobclosewrite.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobclosewrite.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobCloseWrite, g_vfs_job_close_write, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobCloseWrite, g_vfs_job_close_write, G_VFS_TYPE_JOB)
 
 static void run (GVfsJob *job);
 static gboolean try (GVfsJob *job);

Modified: trunk/daemon/gvfsjobcopy.c
==============================================================================
--- trunk/daemon/gvfsjobcopy.c	(original)
+++ trunk/daemon/gvfsjobcopy.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobCopy, g_vfs_job_copy, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobCopy, g_vfs_job_copy, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobcreatemonitor.c
==============================================================================
--- trunk/daemon/gvfsjobcreatemonitor.c	(original)
+++ trunk/daemon/gvfsjobcreatemonitor.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobCreateMonitor, g_vfs_job_create_monitor, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobCreateMonitor, g_vfs_job_create_monitor, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobdbus.c
==============================================================================
--- trunk/daemon/gvfsjobdbus.c	(original)
+++ trunk/daemon/gvfsjobdbus.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobdbus.h"
 #include "gdbusutils.h"
 
-G_DEFINE_TYPE (GVfsJobDBus, g_vfs_job_dbus, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobDBus, g_vfs_job_dbus, G_VFS_TYPE_JOB)
 
 /* TODO: Real P_() */
 #define P_(_x) (_x)

Modified: trunk/daemon/gvfsjobdelete.c
==============================================================================
--- trunk/daemon/gvfsjobdelete.c	(original)
+++ trunk/daemon/gvfsjobdelete.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobDelete, g_vfs_job_delete, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobDelete, g_vfs_job_delete, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobenumerate.c
==============================================================================
--- trunk/daemon/gvfsjobenumerate.c	(original)
+++ trunk/daemon/gvfsjobenumerate.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobEnumerate, g_vfs_job_enumerate, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobEnumerate, g_vfs_job_enumerate, G_VFS_TYPE_JOB_DBUS)
 
 static void         run        (GVfsJob        *job);
 static gboolean     try        (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobmakedirectory.c
==============================================================================
--- trunk/daemon/gvfsjobmakedirectory.c	(original)
+++ trunk/daemon/gvfsjobmakedirectory.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobMakeDirectory, g_vfs_job_make_directory, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobMakeDirectory, g_vfs_job_make_directory, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobmakesymlink.c
==============================================================================
--- trunk/daemon/gvfsjobmakesymlink.c	(original)
+++ trunk/daemon/gvfsjobmakesymlink.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobMakeSymlink, g_vfs_job_make_symlink, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobMakeSymlink, g_vfs_job_make_symlink, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobmount.c
==============================================================================
--- trunk/daemon/gvfsjobmount.c	(original)
+++ trunk/daemon/gvfsjobmount.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobMount, g_vfs_job_mount, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobMount, g_vfs_job_mount, G_VFS_TYPE_JOB)
 
 static void     run        (GVfsJob *job);
 static gboolean try        (GVfsJob *job);

Modified: trunk/daemon/gvfsjobmountmountable.c
==============================================================================
--- trunk/daemon/gvfsjobmountmountable.c	(original)
+++ trunk/daemon/gvfsjobmountmountable.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobMountMountable, g_vfs_job_mount_mountable, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobMountMountable, g_vfs_job_mount_mountable, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobmove.c
==============================================================================
--- trunk/daemon/gvfsjobmove.c	(original)
+++ trunk/daemon/gvfsjobmove.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobMove, g_vfs_job_move, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobMove, g_vfs_job_move, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobopenforread.c
==============================================================================
--- trunk/daemon/gvfsjobopenforread.c	(original)
+++ trunk/daemon/gvfsjobopenforread.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobOpenForRead, g_vfs_job_open_for_read, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobOpenForRead, g_vfs_job_open_for_read, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);
@@ -177,7 +177,6 @@
   GError *error;
   int remote_fd;
   int fd_id;
-  gboolean res;
   dbus_bool_t can_seek;
 
   g_assert (open_job->backend_handle != NULL);
@@ -200,10 +199,10 @@
 
   reply = dbus_message_new_method_return (message);
   can_seek = open_job->can_seek;
-  res = dbus_message_append_args (reply,
-				  DBUS_TYPE_UINT32, &fd_id,
-				  DBUS_TYPE_BOOLEAN, &can_seek,
-				  DBUS_TYPE_INVALID);
+  dbus_message_append_args (reply,
+			    DBUS_TYPE_UINT32, &fd_id,
+			    DBUS_TYPE_BOOLEAN, &can_seek,
+			    DBUS_TYPE_INVALID);
 
   g_vfs_channel_set_backend_handle (G_VFS_CHANNEL (channel), open_job->backend_handle);
   open_job->backend_handle = NULL;

Modified: trunk/daemon/gvfsjobopenforwrite.c
==============================================================================
--- trunk/daemon/gvfsjobopenforwrite.c	(original)
+++ trunk/daemon/gvfsjobopenforwrite.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobOpenForWrite, g_vfs_job_open_for_write, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobOpenForWrite, g_vfs_job_open_for_write, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);
@@ -267,7 +267,6 @@
   GError *error;
   int remote_fd;
   int fd_id;
-  gboolean res;
   dbus_bool_t can_seek;
   guint64 initial_offset;
   
@@ -292,11 +291,11 @@
   reply = dbus_message_new_method_return (message);
   can_seek = open_job->can_seek;
   initial_offset = open_job->initial_offset;
-  res = dbus_message_append_args (reply,
-				  DBUS_TYPE_UINT32, &fd_id,
-				  DBUS_TYPE_BOOLEAN, &can_seek,
-				  DBUS_TYPE_UINT64, &initial_offset,
-				  DBUS_TYPE_INVALID);
+  dbus_message_append_args (reply,
+			    DBUS_TYPE_UINT32, &fd_id,
+			    DBUS_TYPE_BOOLEAN, &can_seek,
+			    DBUS_TYPE_UINT64, &initial_offset,
+			    DBUS_TYPE_INVALID);
 
   g_vfs_channel_set_backend_handle (G_VFS_CHANNEL (channel), open_job->backend_handle);
   open_job->backend_handle = NULL;

Modified: trunk/daemon/gvfsjobqueryattributes.c
==============================================================================
--- trunk/daemon/gvfsjobqueryattributes.c	(original)
+++ trunk/daemon/gvfsjobqueryattributes.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gvfsdaemonprotocol.h"
 #include "gvfsjobqueryattributes.h"
 
-G_DEFINE_TYPE (GVfsJobQueryAttributes, g_vfs_job_query_attributes, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobQueryAttributes, g_vfs_job_query_attributes, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobqueryfsinfo.c
==============================================================================
--- trunk/daemon/gvfsjobqueryfsinfo.c	(original)
+++ trunk/daemon/gvfsjobqueryfsinfo.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobQueryFsInfo, g_vfs_job_query_fs_info, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobQueryFsInfo, g_vfs_job_query_fs_info, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobqueryinfo.c
==============================================================================
--- trunk/daemon/gvfsjobqueryinfo.c	(original)
+++ trunk/daemon/gvfsjobqueryinfo.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobQueryInfo, g_vfs_job_query_info, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobQueryInfo, g_vfs_job_query_info, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobread.c
==============================================================================
--- trunk/daemon/gvfsjobread.c	(original)
+++ trunk/daemon/gvfsjobread.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobread.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobRead, g_vfs_job_read, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobRead, g_vfs_job_read, G_VFS_TYPE_JOB)
 
 static void     run        (GVfsJob *job);
 static gboolean try        (GVfsJob *job);
@@ -96,7 +96,7 @@
 send_reply (GVfsJob *job)
 {
   GVfsJobRead *op_job = G_VFS_JOB_READ (job);
-  g_print ("job_read send reply, %"G_GSSIZE_FORMAT" bytes\n", op_job->data_count);
+  g_print ("job_read send reply, %"G_GSIZE_FORMAT" bytes\n", op_job->data_count);
 
   if (job->failed)
     g_vfs_channel_send_error (G_VFS_CHANNEL (op_job->channel), job->error);

Modified: trunk/daemon/gvfsjobseekread.c
==============================================================================
--- trunk/daemon/gvfsjobseekread.c	(original)
+++ trunk/daemon/gvfsjobseekread.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobseekread.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobSeekRead, g_vfs_job_seek_read, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobSeekRead, g_vfs_job_seek_read, G_VFS_TYPE_JOB)
 
 static void     run        (GVfsJob *job);
 static gboolean try        (GVfsJob *job);

Modified: trunk/daemon/gvfsjobseekwrite.c
==============================================================================
--- trunk/daemon/gvfsjobseekwrite.c	(original)
+++ trunk/daemon/gvfsjobseekwrite.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobseekwrite.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobSeekWrite, g_vfs_job_seek_write, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobSeekWrite, g_vfs_job_seek_write, G_VFS_TYPE_JOB)
 
 static void     run        (GVfsJob *job);
 static gboolean try        (GVfsJob *job);

Modified: trunk/daemon/gvfsjobsetattribute.c
==============================================================================
--- trunk/daemon/gvfsjobsetattribute.c	(original)
+++ trunk/daemon/gvfsjobsetattribute.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gvfsdaemonprotocol.h"
 #include "gvfsjobsetattribute.h"
 
-G_DEFINE_TYPE (GVfsJobSetAttribute, g_vfs_job_set_attribute, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobSetAttribute, g_vfs_job_set_attribute, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobsetdisplayname.c
==============================================================================
--- trunk/daemon/gvfsjobsetdisplayname.c	(original)
+++ trunk/daemon/gvfsjobsetdisplayname.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobSetDisplayName, g_vfs_job_set_display_name, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobSetDisplayName, g_vfs_job_set_display_name, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobtrash.c
==============================================================================
--- trunk/daemon/gvfsjobtrash.c	(original)
+++ trunk/daemon/gvfsjobtrash.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobTrash, g_vfs_job_trash, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobTrash, g_vfs_job_trash, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobunmount.c
==============================================================================
--- trunk/daemon/gvfsjobunmount.c	(original)
+++ trunk/daemon/gvfsjobunmount.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobUnmount, g_vfs_job_unmount, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobUnmount, g_vfs_job_unmount, G_VFS_TYPE_JOB_DBUS)
 
 static void     run        (GVfsJob *job);
 static gboolean try        (GVfsJob *job);
@@ -46,10 +46,6 @@
 static void
 g_vfs_job_unmount_finalize (GObject *object)
 {
-  GVfsJobUnmount *job;
-
-  job = G_VFS_JOB_UNMOUNT (object);
-
   if (G_OBJECT_CLASS (g_vfs_job_unmount_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_vfs_job_unmount_parent_class)->finalize) (object);
 }

Modified: trunk/daemon/gvfsjobunmountmountable.c
==============================================================================
--- trunk/daemon/gvfsjobunmountmountable.c	(original)
+++ trunk/daemon/gvfsjobunmountmountable.c	Tue Feb 19 09:41:06 2008
@@ -34,7 +34,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobUnmountMountable, g_vfs_job_unmount_mountable, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobUnmountMountable, g_vfs_job_unmount_mountable, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobupload.c
==============================================================================
--- trunk/daemon/gvfsjobupload.c	(original)
+++ trunk/daemon/gvfsjobupload.c	Tue Feb 19 09:41:06 2008
@@ -35,7 +35,7 @@
 #include "gdbusutils.h"
 #include "gvfsdaemonprotocol.h"
 
-G_DEFINE_TYPE (GVfsJobUpload, g_vfs_job_upload, G_VFS_TYPE_JOB_DBUS);
+G_DEFINE_TYPE (GVfsJobUpload, g_vfs_job_upload, G_VFS_TYPE_JOB_DBUS)
 
 static void         run          (GVfsJob        *job);
 static gboolean     try          (GVfsJob        *job);

Modified: trunk/daemon/gvfsjobwrite.c
==============================================================================
--- trunk/daemon/gvfsjobwrite.c	(original)
+++ trunk/daemon/gvfsjobwrite.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 #include "gvfsjobwrite.h"
 #include "gvfsdaemonutils.h"
 
-G_DEFINE_TYPE (GVfsJobWrite, g_vfs_job_write, G_VFS_TYPE_JOB);
+G_DEFINE_TYPE (GVfsJobWrite, g_vfs_job_write, G_VFS_TYPE_JOB)
 
 static void     run        (GVfsJob *job);
 static gboolean try        (GVfsJob *job);

Modified: trunk/daemon/gvfsmonitor.c
==============================================================================
--- trunk/daemon/gvfsmonitor.c	(original)
+++ trunk/daemon/gvfsmonitor.c	Tue Feb 19 09:41:06 2008
@@ -28,7 +28,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/un.h>
-#include <unistd.h>
 #include <fcntl.h>
 
 #include <glib.h>

Modified: trunk/daemon/gvfsreadchannel.c
==============================================================================
--- trunk/daemon/gvfsreadchannel.c	(original)
+++ trunk/daemon/gvfsreadchannel.c	Tue Feb 19 09:41:06 2008
@@ -27,7 +27,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/un.h>
-#include <unistd.h>
 #include <fcntl.h>
 
 #include <glib.h>
@@ -65,10 +64,6 @@
 static void
 g_vfs_read_channel_finalize (GObject *object)
 {
-  GVfsReadChannel *read_channel;
-
-  read_channel = G_VFS_READ_CHANNEL (object);
-  
   if (G_OBJECT_CLASS (g_vfs_read_channel_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_vfs_read_channel_parent_class)->finalize) (object);
 }
@@ -177,7 +172,7 @@
     default:
       g_set_error (error, G_IO_ERROR,
 		   G_IO_ERROR_FAILED,
-		   "Unknown stream command %d\n", command);
+		   "Unknown stream command %"G_GINT32_FORMAT"\n", command);
       break;
     }
 

Modified: trunk/daemon/gvfswritechannel.c
==============================================================================
--- trunk/daemon/gvfswritechannel.c	(original)
+++ trunk/daemon/gvfswritechannel.c	Tue Feb 19 09:41:06 2008
@@ -28,7 +28,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/un.h>
-#include <unistd.h>
 #include <fcntl.h>
 
 #include <glib.h>
@@ -61,10 +60,6 @@
 static void
 g_vfs_write_channel_finalize (GObject *object)
 {
-  GVfsWriteChannel *write_channel;
-
-  write_channel = G_VFS_WRITE_CHANNEL (object);
-  
   if (G_OBJECT_CLASS (g_vfs_write_channel_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_vfs_write_channel_parent_class)->finalize) (object);
 }
@@ -144,7 +139,7 @@
     default:
       g_set_error (error, G_IO_ERROR,
 		   G_IO_ERROR_FAILED,
-		   "Unknown stream command %d\n", command);
+		   "Unknown stream command %"G_GINT32_FORMAT"\n", command);
       break;
     }
 

Modified: trunk/daemon/main.c
==============================================================================
--- trunk/daemon/main.c	(original)
+++ trunk/daemon/main.c	Tue Feb 19 09:41:06 2008
@@ -97,19 +97,19 @@
   if (!no_fuse)
     {
       char *fuse_path;
-      char *argv[3];
+      char *argv2[3];
       
       fuse_path = g_build_filename (g_get_home_dir (), ".gvfs", NULL);
       
       if (!g_file_test (fuse_path, G_FILE_TEST_EXISTS))
 	g_mkdir (fuse_path, 0700);
       
-      argv[0] = LIBEXEC_DIR "/gvfs-fuse-daemon";
-      argv[1] = fuse_path;
-      argv[2] = NULL;
+      argv2[0] = LIBEXEC_DIR "/gvfs-fuse-daemon";
+      argv2[1] = fuse_path;
+      argv2[2] = NULL;
       
       g_spawn_async (NULL,
-		     argv,
+		     argv2,
 		     NULL,
 		     G_SPAWN_STDOUT_TO_DEV_NULL |
 		     G_SPAWN_STDERR_TO_DEV_NULL, 

Modified: trunk/daemon/soup-input-stream.c
==============================================================================
--- trunk/daemon/soup-input-stream.c	(original)
+++ trunk/daemon/soup-input-stream.c	Tue Feb 19 09:41:06 2008
@@ -33,7 +33,7 @@
 
 G_DEFINE_TYPE_WITH_CODE (SoupInputStream, soup_input_stream, G_TYPE_INPUT_STREAM,
 			 G_IMPLEMENT_INTERFACE (G_TYPE_SEEKABLE,
-						soup_input_stream_seekable_iface_init));
+						soup_input_stream_seekable_iface_init))
 
 typedef void (*SoupInputStreamCallback) (GInputStream *);
 
@@ -121,9 +121,7 @@
   g_signal_handlers_disconnect_by_func (priv->msg, G_CALLBACK (soup_input_stream_got_chunk), stream);
   g_signal_handlers_disconnect_by_func (priv->msg, G_CALLBACK (soup_input_stream_finished), stream);
   g_object_unref (priv->msg);
-
-  if (priv->leftover_buffer)
-    g_free (priv->leftover_buffer);
+  g_free (priv->leftover_buffer);
 
   if (G_OBJECT_CLASS (soup_input_stream_parent_class)->finalize)
     (*G_OBJECT_CLASS (soup_input_stream_parent_class)->finalize) (object);
@@ -459,11 +457,9 @@
 			GCancellable *cancellable,
 			GError      **error)
 {
-  SoupInputStreamPrivate *priv;
   gboolean result;
 
   g_return_val_if_fail (SOUP_IS_INPUT_STREAM (stream), FALSE);
-  priv = SOUP_INPUT_STREAM_GET_PRIVATE (stream);
 
   if (!g_input_stream_set_pending (stream, error))
       return FALSE;
@@ -646,11 +642,9 @@
 			      GAsyncReadyCallback  callback,
 			      gpointer             user_data)
 {
-  SoupInputStreamPrivate *priv = SOUP_INPUT_STREAM_GET_PRIVATE (stream);
   GError *error = NULL;
 
   g_return_if_fail (SOUP_IS_INPUT_STREAM (stream));
-  priv = SOUP_INPUT_STREAM_GET_PRIVATE (stream);
 
   if (!g_input_stream_set_pending (stream, &error))
     {

Modified: trunk/daemon/soup-output-stream.c
==============================================================================
--- trunk/daemon/soup-output-stream.c	(original)
+++ trunk/daemon/soup-output-stream.c	Tue Feb 19 09:41:06 2008
@@ -30,7 +30,7 @@
 #include "soup-output-stream.h"
 #include "soup-input-stream.h"
 
-G_DEFINE_TYPE (SoupOutputStream, soup_output_stream, G_TYPE_OUTPUT_STREAM);
+G_DEFINE_TYPE (SoupOutputStream, soup_output_stream, G_TYPE_OUTPUT_STREAM)
 
 typedef void (*SoupOutputStreamCallback) (GOutputStream *);
 
@@ -266,7 +266,7 @@
   return count;
 }
 
-static gboolean
+static int
 soup_output_stream_close (GOutputStream  *stream,
 			  GCancellable   *cancellable,
 			  GError        **error)

Modified: trunk/gconf/gapplookupgconf.c
==============================================================================
--- trunk/gconf/gapplookupgconf.c	(original)
+++ trunk/gconf/gapplookupgconf.c	Tue Feb 19 09:41:06 2008
@@ -56,10 +56,6 @@
 static void
 g_app_lookup_gconf_finalize (GObject *object)
 {
-  GAppLookupGConf *lookup;
-
-  lookup = G_APP_LOOKUP_GCONF (object);
-  
   if (G_OBJECT_CLASS (g_app_lookup_gconf_parent_class)->finalize)
     (*G_OBJECT_CLASS (g_app_lookup_gconf_parent_class)->finalize) (object);
 }
@@ -70,7 +66,6 @@
                                 GObjectConstructParam *construct_properties)
 {
   GObject *object;
-  GAppLookupGConf *lookup;
   GAppLookupGConfClass *klass;
   GObjectClass *parent_class;  
 
@@ -83,8 +78,6 @@
                                       n_construct_properties,
                                       construct_properties);
 
-  lookup = G_APP_LOOKUP_GCONF (object);
-
   return object;
 }
 

Modified: trunk/hal/ghalmount.c
==============================================================================
--- trunk/hal/ghalmount.c	(original)
+++ trunk/hal/ghalmount.c	Tue Feb 19 09:41:06 2008
@@ -138,7 +138,7 @@
 {
 }
 
-const static struct {
+static const struct {
   const char *disc_type;
   const char *icon_name;
   char *ui_name;
@@ -161,7 +161,7 @@
   {"hddvd_r",       "media-optical-hddvd-r", N_("HD DVD-R Disc"), N_("Blank HD DVD-R Disc")},
   {"hddvd_rw",      "media-optical-hddvd-rw", N_("HD DVD-RW Disc"), N_("Blank HD DVD-RW Disc")},
   {"mo",            "media-optical-mo", N_("MO Disc"), N_("Blank MO Disc")},
-  {NULL,            "media-optical", N_("Disc"), N_("Blank Disc")},
+  {NULL,            "media-optical", N_("Disc"), N_("Blank Disc")}
 };
 
 static const char *
@@ -589,8 +589,7 @@
 void 
 g_hal_mount_override_name (GHalMount *mount, const char *name)
 {
-  if (mount->override_name != NULL)
-    g_free (mount->override_name);
+  g_free (mount->override_name);
 
   if (name != NULL)
     mount->override_name = g_strdup (name);
@@ -1152,8 +1151,7 @@
 {
   if (data->root)
     g_object_unref (data->root);
-  if (data->original_path)
-    g_free (data->original_path);
+  g_free (data->original_path);
   if (data->split_path)
     g_strfreev (data->split_path);
   if (data->enumerator)

Modified: trunk/hal/ghalvolume.c
==============================================================================
--- trunk/hal/ghalvolume.c	(original)
+++ trunk/hal/ghalvolume.c	Tue Feb 19 09:41:06 2008
@@ -129,7 +129,7 @@
 {
 }
 
-const static struct {
+static const struct {
   const char *disc_type;
   const char *icon_name;
   char *ui_name;
@@ -152,7 +152,7 @@
   {"hddvd_r",       "media-optical-hddvd-r", N_("HD DVD-R Disc"), N_("Blank HD DVD-R Disc")},
   {"hddvd_rw",      "media-optical-hddvd-rw", N_("HD DVD-RW Disc"), N_("Blank HD DVD-RW Disc")},
   {"mo",            "media-optical-mo", N_("MO Disc"), N_("Blank MO Disc")},
-  {NULL,            "media-optical", N_("Disc"), N_("Blank Disc")},
+  {NULL,            "media-optical", N_("Disc"), N_("Blank Disc")}
 };
 
 static const char *

Modified: trunk/hal/ghalvolumemonitor.c
==============================================================================
--- trunk/hal/ghalvolumemonitor.c	(original)
+++ trunk/hal/ghalvolumemonitor.c	Tue Feb 19 09:41:06 2008
@@ -54,7 +54,7 @@
 
   HalPool *pool;
 
-  GList *last_camera_devices;;
+  GList *last_camera_devices;
   GList *last_optical_disc_devices;
   GList *last_drive_devices;
   GList *last_volume_devices;
@@ -88,7 +88,7 @@
 static void update_cameras           (GHalVolumeMonitor *monitor);
 
 #define g_hal_volume_monitor_get_type g_hal_volume_monitor_get_type
-G_DEFINE_DYNAMIC_TYPE (GHalVolumeMonitor, g_hal_volume_monitor, G_TYPE_NATIVE_VOLUME_MONITOR);
+G_DEFINE_DYNAMIC_TYPE (GHalVolumeMonitor, g_hal_volume_monitor, G_TYPE_NATIVE_VOLUME_MONITOR)
 
 static HalPool *
 get_hal_pool (void)

Modified: trunk/hal/hal-device.c
==============================================================================
--- trunk/hal/hal-device.c	(original)
+++ trunk/hal/hal-device.c	Tue Feb 19 09:41:06 2008
@@ -40,7 +40,7 @@
 
 static guint signals[LAST_SIGNAL] = { 0 };
 
-G_DEFINE_DYNAMIC_TYPE (HalDevice, hal_device, G_TYPE_OBJECT);
+G_DEFINE_DYNAMIC_TYPE (HalDevice, hal_device, G_TYPE_OBJECT)
 
 static void
 hal_device_finalize (HalDevice *device)

Modified: trunk/hal/hal-pool.c
==============================================================================
--- trunk/hal/hal-pool.c	(original)
+++ trunk/hal/hal-pool.c	Tue Feb 19 09:41:06 2008
@@ -49,7 +49,7 @@
   GHashTable *devices;
 };
 
-G_DEFINE_DYNAMIC_TYPE (HalPool, hal_pool, G_TYPE_OBJECT);
+G_DEFINE_DYNAMIC_TYPE (HalPool, hal_pool, G_TYPE_OBJECT)
 
 static void
 hal_pool_finalize (HalPool *pool)

Modified: trunk/programs/gvfs-copy.c
==============================================================================
--- trunk/programs/gvfs-copy.c	(original)
+++ trunk/programs/gvfs-copy.c	Tue Feb 19 09:41:06 2008
@@ -67,7 +67,7 @@
 	       goffset total_num_bytes,
 	       gpointer user_data)
 {
-  g_print ("progress %"G_GUINT64_FORMAT"/%"G_GUINT64_FORMAT"\n",
+  g_print ("progress %"G_GINT64_FORMAT"/%"G_GINT64_FORMAT"\n",
 	   current_num_bytes, total_num_bytes);
 }
 

Modified: trunk/programs/gvfs-mount.c
==============================================================================
--- trunk/programs/gvfs-mount.c	(original)
+++ trunk/programs/gvfs-mount.c	Tue Feb 19 09:41:06 2008
@@ -59,7 +59,6 @@
 #ifdef HAVE_TERMIOS_H
   struct termios term_attr; 
   int old_flags;
-  int res;
   gboolean restore_flags;
 #endif
   char data[256];
@@ -74,7 +73,7 @@
 
 #ifdef HAVE_TERMIOS_H
   restore_flags = FALSE;
-  if (!echo && (res = tcgetattr (STDIN_FILENO, &term_attr)) == 0)
+  if (!echo && tcgetattr (STDIN_FILENO, &term_attr) == 0)
     {
       old_flags = term_attr.c_lflag; 
       term_attr.c_lflag &= ~ECHO;

Modified: trunk/programs/gvfs-move.c
==============================================================================
--- trunk/programs/gvfs-move.c	(original)
+++ trunk/programs/gvfs-move.c	Tue Feb 19 09:41:06 2008
@@ -63,7 +63,7 @@
 	       goffset total_num_bytes,
 	       gpointer user_data)
 {
-  g_print ("progress %"G_GUINT64_FORMAT"/%"G_GUINT64_FORMAT"\n",
+  g_print ("progress %"G_GINT64_FORMAT"/%"G_GINT64_FORMAT"\n",
 	   current_num_bytes, total_num_bytes);
 }
 

Modified: trunk/test/benchmark-posix-big-files.c
==============================================================================
--- trunk/test/benchmark-posix-big-files.c	(original)
+++ trunk/test/benchmark-posix-big-files.c	Tue Feb 19 09:41:06 2008
@@ -62,10 +62,8 @@
 create_file (const gchar *base_dir)
 {
   gchar         *scratch_file;
-  gchar         *scratch_name;
   gint           output_fd;
   gint           pid;
-  GError        *error = NULL;
   gchar          buffer [BUFFER_SIZE];
   gint           i;
 
@@ -110,7 +108,6 @@
 read_file (const gchar *scratch_file)
 {
   gint          input_fd;
-  GError       *error = NULL;
   gint          i;
 
   input_fd = open (scratch_file, O_RDONLY);
@@ -146,8 +143,6 @@
 static void
 delete_file (const gchar *scratch_file)
 {
-  GError *error = NULL;
-
   if (unlink (scratch_file) < 0)
     {
       g_printerr ("Failed to delete scratch file: %s\n", strerror (errno));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]