gnome-commander r1570 - in trunk: . doc/C src

[epiotr svn gnome org]

Author: epiotr
Date: Mon Feb 18 19:26:57 2008
New Revision: 1570
URL: http://svn.gnome.org/viewvc/gnome-commander?rev=1570&view=rev

Log:
Fix for problem #448942 (SHIFT+ENTER: running a command in a separate terminal)

Modified:
   trunk/ChangeLog
   trunk/NEWS
   trunk/doc/C/gnome-commander.xml
   trunk/src/Makefile.am
   trunk/src/gnome-cmd-data.cc
   trunk/src/utils.cc

Modified: trunk/NEWS
==============================================================================
--- trunk/NEWS	(original)
+++ trunk/NEWS	Mon Feb 18 19:26:57 2008
@@ -10,6 +10,7 @@
  * Fixed problem #424159 (column sort problem)
  * Fixed problem #434545 (Debian bug #421480: HUGE icons for device icons)
  * Fixed problem #447415 (inability to launch executables)
+ * Fixed problem #448942 (SHIFT+ENTER: running a command in a separate terminal)
  * Fixed problem #468685 (crash in python module)
  * Fixed problem #490431 (view files with name containing '%')
  * Fixed problem #508565 (improper utf-8 handling in advanced file rename tool)

Modified: trunk/doc/C/gnome-commander.xml
==============================================================================
--- trunk/doc/C/gnome-commander.xml	(original)
+++ trunk/doc/C/gnome-commander.xml	Mon Feb 18 19:26:57 2008
@@ -5487,7 +5487,7 @@
                                 </row>
                                 <row valign="top">
                                     <entry><para></para></entry>
-                                    <entry><para>term</para></entry>
+                                    <entry><para>terminal</para></entry>
                                     <entry><para></para></entry>
                                     <entry><para></para></entry>
                                     <entry><para></para></entry>
@@ -5802,6 +5802,9 @@
                             <para>Fixed problem #447415 (inability to launch executables)</para>
                         </listitem>
                         <listitem>
+                            <para>Fixed problem #448942 (SHIFT+ENTER: running a command in a separate terminal)</para>
+                        </listitem>
+                        <listitem>
                             <para>Fixed problem #468685 (crash in python module)</para>
                         </listitem>
                         <listitem>

Modified: trunk/src/Makefile.am
==============================================================================
--- trunk/src/Makefile.am	(original)
+++ trunk/src/Makefile.am	Mon Feb 18 19:26:57 2008
@@ -11,7 +11,7 @@
 	-DDATADIR=\""$(datadir)"\"\
 	-DPLUGIN_DIR=\""$(libdir)/$(PACKAGE)/plugins"\"
 
-bin_PROGRAMS = gnome-commander gcmd-block
+bin_PROGRAMS = gnome-commander
 
 gnome_commander_SOURCES = \
 	cap.cc cap.h \
@@ -105,5 +105,3 @@
 gnome_commander_LDFLAGS = \
 	$(GNOMEUI_LIBS) \
 	$(GNOMEVFS_LIBS)
-
-gcmd_block_SOURCES = block.cc

Modified: trunk/src/gnome-cmd-data.cc
==============================================================================
--- trunk/src/gnome-cmd-data.cc	(original)
+++ trunk/src/gnome-cmd-data.cc	Mon Feb 18 19:26:57 2008
@@ -1280,7 +1280,7 @@
     gnome_cmd_data_set_string ("/programs/viewer",data->priv->viewer);
     gnome_cmd_data_set_string ("/programs/editor",data->priv->editor);
     gnome_cmd_data_set_string ("/programs/differ",data->priv->differ);
-    gnome_cmd_data_set_string ("/programs/term",data->priv->term);
+    gnome_cmd_data_set_string ("/programs/terminal",data->priv->term);
 
     gnome_cmd_data_set_bool   ("/devices/only_icon",data->priv->device_only_icon);
     gnome_cmd_data_set_int    ("/options/dir_cache_size",data->priv->dir_cache_size);
@@ -1509,7 +1509,7 @@
     data->priv->viewer = gnome_cmd_data_get_string ("/programs/viewer", "gedit %s");
     data->priv->editor = gnome_cmd_data_get_string ("/programs/editor", "gedit %s");
     data->priv->differ = gnome_cmd_data_get_string ("/programs/differ", "meld %s");
-    data->priv->term   = gnome_cmd_data_get_string ("/programs/term", "gnome-terminal -e %s");
+    data->priv->term   = gnome_cmd_data_get_string ("/programs/terminal", "xterm -hold -e %s");
 
     data->priv->device_only_icon = gnome_cmd_data_get_bool ("/devices/only_icon", FALSE);
     data->priv->dir_cache_size = gnome_cmd_data_get_int ("/options/dir_cache_size", 10);

Modified: trunk/src/utils.cc
==============================================================================
--- trunk/src/utils.cc	(original)
+++ trunk/src/utils.cc	Mon Feb 18 19:26:57 2008
@@ -119,18 +119,17 @@
 
     if (term)
     {
-        gchar *tmp, *arg;
+        gchar *arg = g_shell_quote (in_command);
 
-        tmp = g_strdup_printf ("%s; %s/bin/gcmd-block", in_command, PREFIX);
-        arg = g_shell_quote (tmp);
         command = g_strdup_printf (gnome_cmd_data_get_term (), arg);
+
         g_free (arg);
-        g_free (tmp);
     }
     else
         command = g_strdup (in_command);
 
-    DEBUG ('g', "running: %s\n", command);
+    DEBUG ('g', "running%s: %s\n", (term?" in terminal":""), command);
+
     gnome_execute_shell (dir, command);
     g_free (command);
 }