gnome-desktop r4988 - in trunk: . libgnome-desktop



Author: vuntz
Date: Tue Feb  5 16:05:38 2008
New Revision: 4988
URL: http://svn.gnome.org/viewvc/gnome-desktop?rev=4988&view=rev

Log:
2008-02-05  Vincent Untz  <vuntz gnome org>

	* libgnome-desktop/gnome-desktop-item.c: (ditem_load): free the
	readbuf after its last use, not before...
	Fix bug #514560.


Modified:
   trunk/ChangeLog
   trunk/libgnome-desktop/gnome-desktop-item.c

Modified: trunk/libgnome-desktop/gnome-desktop-item.c
==============================================================================
--- trunk/libgnome-desktop/gnome-desktop-item.c	(original)
+++ trunk/libgnome-desktop/gnome-desktop-item.c	Tue Feb  5 16:05:38 2008
@@ -3797,13 +3797,13 @@
 
 	encoding = get_encoding (rb);
 	if (encoding == ENCODING_UNKNOWN) {
-		readbuf_close (rb);
 		/* spec says, don't read this file */
 		g_set_error (error,
 			     GNOME_DESKTOP_ITEM_ERROR,
 			     GNOME_DESKTOP_ITEM_ERROR_UNKNOWN_ENCODING,
 			     _("Unknown encoding of: %s"),
 			     rb->uri);
+		readbuf_close (rb);
 		return NULL;
 	}
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]