vala r969 - in trunk: . vala

[juergbi svn gnome org]

Author: juergbi
Date: Tue Feb  5 00:13:47 2008
New Revision: 969
URL: http://svn.gnome.org/viewvc/vala?rev=969&view=rev

Log:
2008-02-05  Juerg Billeter  <j bitron ch>

	* vala/valaclass.vala, vala/valastruct.vala: improve error reporting
	  for methods missing the return type, fixes bug 514344


Modified:
   trunk/ChangeLog
   trunk/vala/valaclass.vala
   trunk/vala/valastruct.vala

Modified: trunk/vala/valaclass.vala
==============================================================================
--- trunk/vala/valaclass.vala	(original)
+++ trunk/vala/valaclass.vala	Tue Feb  5 00:13:47 2008
@@ -202,6 +202,14 @@
 			} else {
 				m.name = ".new." + m.name;
 			}
+
+			var cm = (CreationMethod) m;
+			if (cm.type_name != null && cm.type_name != name) {
+				// type_name is null for constructors generated by GIdlParser
+				Report.error (m.source_reference, "missing return type in method `%s.%sÂ".printf (get_full_name (), cm.type_name));
+				m.error = true;
+				return;
+			}
 		}
 
 		methods.add (m);

Modified: trunk/vala/valastruct.vala
==============================================================================
--- trunk/vala/valastruct.vala	(original)
+++ trunk/vala/valastruct.vala	Tue Feb  5 00:13:47 2008
@@ -129,6 +129,14 @@
 			} else {
 				m.name = ".new." + m.name;
 			}
+
+			var cm = (CreationMethod) m;
+			if (cm.type_name != null && cm.type_name != name) {
+				// type_name is null for constructors generated by GIdlParser
+				Report.error (m.source_reference, "missing return type in method `%s.%sÂ".printf (get_full_name (), cm.type_name));
+				m.error = true;
+				return;
+			}
 		}
 
 		methods.add (m);