orca r4394 - in trunk: . src/orca/scripts/toolkits/Gecko test/keystrokes/firefox

[joanied svn gnome org]

Author: joanied
Date: Mon Dec 29 15:40:06 2008
New Revision: 4394
URL: http://svn.gnome.org/viewvc/orca?rev=4394&view=rev

Log:
* src/orca/scripts/toolkits/Gecko/script.py:
  test/keystrokes/firefox/label_guess_entries.py:
  test/keystrokes/firefox/label_guess_bug_546815.py:
  Fix for bug #565944 - Missing whitespace when the end of line
  braille indicator is followed by an image in FF 3.x.



Modified:
   trunk/ChangeLog
   trunk/src/orca/scripts/toolkits/Gecko/script.py
   trunk/test/keystrokes/firefox/label_guess_bug_546815.py
   trunk/test/keystrokes/firefox/label_guess_entries.py

Modified: trunk/src/orca/scripts/toolkits/Gecko/script.py
==============================================================================
--- trunk/src/orca/scripts/toolkits/Gecko/script.py	(original)
+++ trunk/src/orca/scripts/toolkits/Gecko/script.py	Mon Dec 29 15:40:06 2008
@@ -2265,7 +2265,8 @@
                 if line.regions[-1].__class__ == regions[0].__class__ \
                    or line.regions[-1].__class__ in [braille.Component,
                                                      braille.Region] \
-                   or lastObj.getRole() == pyatspi.ROLE_IMAGE:
+                   or lastObj.getRole() == pyatspi.ROLE_IMAGE \
+                   or obj.getRole() == pyatspi.ROLE_IMAGE:
                     line.addRegion(braille.Region(" "))
 
                 # The above check will catch table cells with uniform

Modified: trunk/test/keystrokes/firefox/label_guess_bug_546815.py
==============================================================================
--- trunk/test/keystrokes/firefox/label_guess_bug_546815.py	(original)
+++ trunk/test/keystrokes/firefox/label_guess_bug_546815.py	Mon Dec 29 15:40:06 2008
@@ -67,8 +67,7 @@
 sequence.append(KeyReleaseAction(0, None, "KP_Insert"))
 sequence.append(utils.AssertPresentationAction(
     "Next form field",
-    ["BUG? - Should have a space between the EOL indicator and Image",
-     "BRAILLE LINE:  '2. Enter your City:Â $l 3. Enter your State:Â $l 4. Enter your Country:ÂUS $lImage text field using value'",
+    ["BRAILLE LINE:  '2. Enter your City:Â $l 3. Enter your State:Â $l 4. Enter your Country:ÂUS $l Image text field using value'",
      "     VISIBLE:  ' $l 3. Enter your State:Â $l 4. ', cursor=1",
      "SPEECH OUTPUT: '2. Enter your City: text'"]))
 
@@ -78,8 +77,7 @@
 sequence.append(KeyReleaseAction(0, None, "KP_Insert"))
 sequence.append(utils.AssertPresentationAction(
     "Next form field", 
-    ["BUG? - Should have a space between the EOL indicator and Image",
-     "BRAILLE LINE:  '2. Enter your City:Â $l 3. Enter your State:Â $l 4. Enter your Country:ÂUS $lImage text field using value'",
+    ["BRAILLE LINE:  '2. Enter your City:Â $l 3. Enter your State:Â $l 4. Enter your Country:ÂUS $l Image text field using value'",
      "     VISIBLE:  ' $l 4. Enter your Country:ÂUS $l', cursor=1",
      "SPEECH OUTPUT: '3. Enter your State: text'"]))
 
@@ -89,8 +87,7 @@
 sequence.append(KeyReleaseAction(0, None, "KP_Insert"))
 sequence.append(utils.AssertPresentationAction(
     "Next form field", 
-    ["BUG? - Should have a space between the EOL indicator and Image",
-     "BRAILLE LINE:  '2. Enter your City:Â $l 3. Enter your State:Â $l 4. Enter your Country:ÂImage US $l text field using value'",
+    ["BRAILLE LINE:  '2. Enter your City:Â $l 3. Enter your State:Â $l 4. Enter your Country:ÂImage US $l text field using value'",
      "     VISIBLE:  'US $l text field using value', cursor=1",
      "SPEECH OUTPUT: '4. Enter your Country: text US'"]))
 

Modified: trunk/test/keystrokes/firefox/label_guess_entries.py
==============================================================================
--- trunk/test/keystrokes/firefox/label_guess_entries.py	(original)
+++ trunk/test/keystrokes/firefox/label_guess_entries.py	Mon Dec 29 15:40:06 2008
@@ -410,9 +410,8 @@
 sequence.append(KeyReleaseAction(0, None, "KP_Insert"))
 sequence.append(utils.AssertPresentationAction(
     "Next form field", 
-    ["BUG? - Need a space between the EOL symbol and bandaid",
-     "BRAILLE LINE:  ' $lbandaid graphic redux Image'",
-     "     VISIBLE:  ' $lbandaid graphic redux Image', cursor=1",
+    ["BRAILLE LINE:  ' $l bandaid graphic redux Image'",
+     "     VISIBLE:  ' $l bandaid graphic redux Image', cursor=1",
      "SPEECH OUTPUT: 'bandaid graphic redux text'"]))
 
 sequence.append(utils.StartRecordingAction())
@@ -425,8 +424,6 @@
      "     VISIBLE:  'tab to me and I disappear $l', cursor=26",
      "BRAILLE LINE:  'Magic disappearing text trick:   $l'",
      "     VISIBLE:  ' $l', cursor=1",
-     "BRAILLE LINE:  'Magic disappearing text trick:   $l'",
-     "     VISIBLE:  ' $l', cursor=1",
      "SPEECH OUTPUT: 'Magic disappearing text trick: text'"]))
 
 sequence.append(utils.StartRecordingAction())